chore: adds mapping to show < on gas speed for fast chains (megaETH)#39824
Merged
chore: adds mapping to show < on gas speed for fast chains (megaETH)#39824
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [2a70296]
UI Startup Metrics (1407 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (12 files, +151 -35)
|
wantedsystem
reviewed
Feb 5, 2026
Contributor
Builds ready [adf3f78]
UI Startup Metrics (1402 ± 79 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [79ff472]
UI Startup Metrics (1395 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [bbf3546]
UI Startup Metrics (1436 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [a3863c8]
UI Startup Metrics (1424 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
test/integration/confirmations/transactions/contract-deployment.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
Builds ready [2489aa0]
UI Startup Metrics (1392 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [98a16cc]
UI Startup Metrics (1372 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [2a69a31]
UI Startup Metrics (1375 ± 93 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| // get options from .prettierrc | ||
| ...prettierOptions, | ||
| filepath: TARGET_FILE, | ||
| trailingComma: 'none', // Ensure no trailing commas for JSONC compatibility |
Contributor
There was a problem hiding this comment.
You tried to make a different change to development/circular-deps.ts, but it didn't really work correctly. I fixed it properly here.
Contributor
Builds ready [54679eb]
UI Startup Metrics (1349 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Feb 11, 2026
wantedsystem
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira ticket NEB-352
We need to show "<" for MegaETH chain if the gas speed is bellow 1 second. The gas API returns 250ms as minimum speed. In order to not modify the current behavior we will just show a "<" instead of a "~"
We need to merge it before tomorrow wednesday 11, Feb end of RC.
Changelog
CHANGELOG entry: Show "<" for MegaETH chain if the gas speed is bellow 1 second
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only formatting changes to gas timing output plus test updates; limited blast radius aside from potential string formatting regressions in confirmation screens.
Overview
Improves gas timing UX for very fast networks by formatting sub-second estimates and displaying them as
"<1 sec"(instead of"~0 sec") while keeping0msdisplayed as"~0 sec".Threads
chainIdintoGasTimingwhere missing, updatestoHumanReadableTimeto support decimal seconds for values under 1s, and adds/updates unit tests and confirmation snapshots to cover the new output.Written by Cursor Bugbot for commit 54679eb. This will update automatically on new commits. Configure here.