fix: refetch subscription on update payment card close tab by tuna1207 · Pull Request #39814 · MetaMask/metamask-extension

tuna1207 · 2026-02-05T05:36:24Z

Description

In shield subscription, we are missing subscription reload after user close tab and back to metamask from card update tab
This PR handle subscription reload even if user close tab only in card payment update tab

Changelog

CHANGELOG entry: handle subscription reload when user close shield card payment update stripe tab

Related issues

Fixes:

Manual testing steps

Subscribe to shield
When subscription is past due
Change payment method open stripe payment tab
Change to new accepted card
Close tab insead of press back to metamask
new subscription active status should be reloaded

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small control-flow change limited to the card payment-method update flow; main risk is unintentionally swallowing non-tab-close errors and masking failures.

Overview
Fixes Shield card payment-method updates so subscriptions are still re-fetched when the Stripe tab is closed manually (instead of waiting for a redirect).

updateSubscriptionCardPaymentMethod now catches the specific SHIELD_ERROR.tabActionFailed case from #openAndWaitForTabToClose and continues the flow, while rethrowing other errors.

^{Written by Cursor Bugbot for commit f9cb776. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-05T06:08:29Z

Builds ready [f9cb776]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1338 ± 121 ms)

Platform	BuildType	Page	Metric	Test Title (ms)	Persona (ms)	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1338	1092	1712	121	1410	1542
			load	-	-	1148	927	1451	109	1217	1340
			domContentLoaded	-	-	1140	920	1445	109	1209	1331
			domInteractive	-	-	26	14	133	20	21	76
			firstPaint	-	-	210	60	1225	207	200	333
			backgroundConnect	-	-	217	199	261	12	222	242
			firstReactRender	-	-	16	9	30	4	18	22
			initialActions	-	-	1	0	5	1	1	3
			loadScripts	-	-	939	724	1236	108	1010	1132
			setupStore	-	-	12	6	40	6	14	26
			numNetworkReqs	-	-	23	15	101	22	15	86
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1724	1397	3560	237	1753	2117
			load	-	-	1123	1011	1670	141	1111	1539
			domContentLoaded	-	-	1107	1004	1660	136	1099	1500
			domInteractive	-	-	33	17	139	23	32	101
			firstPaint	-	-	192	65	1556	199	234	345
			backgroundConnect	-	-	324	275	1337	108	319	420
			firstReactRender	-	-	23	15	57	9	25	45
			initialActions	-	-	1	0	4	1	1	2
			loadScripts	-	-	873	778	1388	123	866	1228
			setupStore	-	-	15	8	44	7	17	29
			numNetworkReqs	-	-	82	43	261	41	88	191
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	850	678	1111	106	944	1034
load			-	-	713	596	1007	100	792	915
domContentLoaded			-	-	708	591	988	98	787	906
domInteractive			-	-	26	16	91	17	22	78
firstPaint			-	-	110	62	834	85	130	204
backgroundConnect			-	-	33	16	132	20	37	76
firstReactRender			-	-	16	10	39	6	17	29
initialActions			-	-	1	0	7	1	1	3
loadScripts			-	-	705	589	982	98	777	904
setupStore			-	-	11	5	36	5	12	22
numNetworkReqs			-	-	23	15	95	21	15	86
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	1234	854	1973	210	1340	1727
		load	-	-	712	615	1174	117	705	1045
		domContentLoaded	-	-	703	609	1169	117	696	1036
		domInteractive	-	-	35	18	142	26	34	111
		firstPaint	-	-	140	65	526	92	177	345
		backgroundConnect	-	-	170	129	421	64	162	338
		firstReactRender	-	-	22	18	38	3	24	27
		initialActions	-	-	1	0	2	1	1	1
		loadScripts	-	-	700	607	1161	115	693	1027
		setupStore	-	-	12	5	33	4	13	17
		numNetworkReqs	-	-	117	45	282	55	146	268
		19	-	-	-	-	-	-	-	-
Firefox	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1629	1322	2143	175	1744	1980
			load	-	-	1372	1168	1908	144	1452	1598
			domContentLoaded	-	-	1371	1168	1908	144	1452	1592
			domInteractive	-	-	74	33	210	37	91	144
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	76	26	214	44	107	169
			firstReactRender	-	-	12	9	28	3	12	18
			initialActions	-	-	1	0	2	0	2	2
			loadScripts	-	-	1330	1154	1849	133	1393	1560
			setupStore	-	-	13	6	67	13	12	42
			numNetworkReqs	-	-	25	12	101	23	18	90
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	2765	1984	4302	500	2982	3823
			load	-	-	1549	1211	2410	284	1735	2214
			domContentLoaded	-	-	1548	1204	2410	284	1735	2214
			domInteractive	-	-	123	34	703	131	109	488
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	298	113	1052	241	338	904
			firstReactRender	-	-	19	14	107	9	19	23
			initialActions	-	-	1	0	3	1	2	2
			loadScripts	-	-	1502	1186	2314	263	1615	2146
			setupStore	-	-	116	6	772	176	100	606
			numNetworkReqs	-	-	66	36	160	34	86	140
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	1628	1385	2176	158	1712	1932
load			-	-	1397	1183	1655	104	1469	1594
domContentLoaded			-	-	1397	1183	1655	104	1469	1588
domInteractive			-	-	93	33	234	42	132	153
firstPaint			-	-	-	-	-	-	-	-
backgroundConnect			-	-	62	23	188	36	76	147
firstReactRender			-	-	14	11	22	2	15	17
initialActions			-	-	1	0	2	0	2	2
loadScripts			-	-	1360	1168	1611	98	1423	1537
setupStore			-	-	21	6	228	37	13	91
numNetworkReqs			-	-	24	12	90	20	18	85
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	2787	1923	7114	670	3192	3940
		load	-	-	1593	1212	5771	561	1724	2487
		domContentLoaded	-	-	1593	1212	5771	561	1724	2487
		domInteractive	-	-	141	30	1887	227	109	629
		firstPaint	-	-	-	-	-	-	-	-
		backgroundConnect	-	-	340	113	1380	284	399	933
		firstReactRender	-	-	22	16	65	7	23	30
		initialActions	-	-	2	0	6	1	2	3
		loadScripts	-	-	1541	1191	5745	545	1622	2436
		setupStore	-	-	200	7	813	239	337	715
		numNetworkReqs	-	-	64	36	195	35	87	133
		19	-	-	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: f9cb776 | Date: 2/5/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±36ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 718ms (±34ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	36ms	1.00s	1.29s	1.06s	1.29s
domContentLoaded	718ms	34ms	696ms	962ms	737ms	962ms
firstPaint	76ms	12ms	60ms	184ms	84ms	184ms
firstContentfulPaint	76ms	12ms	60ms	184ms	84ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 121 Bytes (0%)
ui: -1 Bytes (0%)
common: 2.5 KiB (0.03%)

fix: refetch subscription on update payment card close tab

f9cb776

tuna1207 temporarily deployed to pr-comment February 5, 2026 05:36 — with GitHub Actions Inactive

metamaskbot added the team-onboarding Onboarding team label Feb 5, 2026

tuna1207 added area-shield team-shield Shield team and removed team-onboarding Onboarding team labels Feb 5, 2026

tuna1207 requested review from chaitanyapotti, lionellbriones and lwin-kyaw February 5, 2026 05:36

tuna1207 marked this pull request as ready for review February 5, 2026 05:37

tuna1207 temporarily deployed to pr-comment February 5, 2026 05:37 — with GitHub Actions Inactive

github-actions bot added the size-S label Feb 5, 2026

chaitanyapotti approved these changes Feb 5, 2026

View reviewed changes

tuna1207 temporarily deployed to pr-comment February 5, 2026 06:04 — with GitHub Actions Inactive

chaitanyapotti enabled auto-merge February 5, 2026 07:26

lionellbriones approved these changes Feb 5, 2026

View reviewed changes

chaitanyapotti added this pull request to the merge queue Feb 5, 2026

Merged via the queue into main with commit 5e6d11a Feb 5, 2026
199 of 201 checks passed

chaitanyapotti deleted the fix/shield-update-card-payment-refetch branch February 5, 2026 08:40

github-actions bot locked and limited conversation to collaborators Feb 5, 2026

metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: refetch subscription on update payment card close tab#39814

fix: refetch subscription on update payment card close tab#39814
chaitanyapotti merged 1 commit intomainfrom
fix/shield-update-card-payment-refetch

tuna1207 commented Feb 5, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Feb 5, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tuna1207 commented Feb 5, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 5, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tuna1207 commented Feb 5, 2026 •

edited by cursor bot

Loading