fix: Add wallet_snap permission middleware#39805
Merged
Mrtenz merged 2 commits intogr/bump-snaps-v142from Feb 5, 2026
Merged
Conversation
Contributor
Builds ready [bba6809]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
FrederikBolding
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches the RPC middleware stack and permission gating for snaps, so ordering/compatibility issues could block or mis-handle snap requests, but the change is small and localized.
Overview
Adds the
wallet_snappermission middleware into the background JSON-RPC engine by importingcreateWalletSnapPermissionMiddlewarefrom@metamask/snaps-rpc-methodsand pushing it onto the engine.Wraps the new middleware with
asLegacyMiddleware(from@metamask/json-rpc-engine/v2) and installs it before the legacyeth_accountshandler and the main permission middleware, ensuringwallet_snappermission checks run early in the request pipeline.Written by Cursor Bugbot for commit bba6809. This will update automatically on new commits. Configure here.