fix: render "Dapp Connections" pages with constrained max width by jeffsmale90 · Pull Request #39801 · MetaMask/metamask-extension

jeffsmale90 · 2026-02-04T19:59:03Z

Description

When reviewing Dapp Connections, the user must navigate the page hierarchy to refine the permissions list. Some of these interim pages were rendered fullscreen instead of with an appropriate max width constraint.

This PR fixes that by updating the "layout" to "DefaultLayout" (previously "LegacyLayout").

Also:

remove unused ref from first permissions page
rename page variables in routes component for clarity (GatorPermissions prefix)

Changelog

CHANGELOG entry: fixes fullscreen rendering of Dapp Connections pages by updating layout from "LegacyLayout" to "DefaultLayout"

Related issues

Fixes:

Manual testing steps

The following should be tested in Popup, Fullscreen, and side panel modes.

Via "Sites"

Navigate to "Dapp Connections" page (previously "All Permissions")
Click "Sites"
Click any connected site
Click any listed network

Via "Token transfer" permissions

Navigate to "Dapp Connections" page (previously "All Permissions")
Click "Token transfer"
Click any listed network

Note that all pages are rendered with the appropriate max width constraint consistent with the rest of the wallet interface.

Screenshots/Recordings

Before

Note this page is rendered in full width

After

Note that all pages are now constrained to an appropriate max width

dapp.connections.with.constrained.max.width.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI routing/layout change; main risk is unintended styling/navigation regressions on the GATOR_PERMISSIONS/token-transfer/review routes due to layout swap and route component renames.

Overview
Ensures the Dapp Connections (Gator Permissions) route set renders with the standard max-width constraints by switching these routes from LegacyLayout to RootLayout (including token transfer and review subpages).

Cleans up related plumbing by removing an unused useRef/placeholder Box in GatorPermissionsPage and renaming the lazy-loaded route variables with a GatorPermissions prefix; updates the Jest snapshot accordingly.

^{Written by Cursor Bugbot for commit e794234. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-04T19:59:17Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-02-04T19:59:51Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +2 -9)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 pages/
      - 📁 gator-permissions/
        
        📁 __snapshots__/
        
        📄 gator-permissions-page.test.tsx.snap +0 -3
        
        📄 gator-permissions-page.tsx +2 -6

…riate fixed width - remove unused ref from first permissions page - rename page variables in routes component for clarity (GatorPermissions prefix)

metamaskbotv2 · 2026-02-04T20:51:27Z

Builds ready [e794234]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1385 ± 85 ms)

Platform	BuildType	Page	Metric	Test Title (ms)	Persona (ms)	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1385	1173	1642	85	1441	1509
			load	-	-	1185	985	1425	85	1241	1303
			domContentLoaded	-	-	1179	980	1382	83	1232	1297
			domInteractive	-	-	26	16	95	18	22	81
			firstPaint	-	-	153	67	353	66	195	299
			backgroundConnect	-	-	234	213	304	16	238	262
			firstReactRender	-	-	17	10	38	5	18	27
			initialActions	-	-	1	0	5	1	1	2
			loadScripts	-	-	961	769	1149	83	1016	1085
			setupStore	-	-	12	7	28	4	15	19
			numNetworkReqs	-	-	23	15	90	20	15	82
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1829	1491	3319	246	1882	2285
			load	-	-	1198	1051	2280	211	1173	1754
			domContentLoaded	-	-	1182	1047	2181	204	1159	1717
			domInteractive	-	-	37	19	134	24	35	106
			firstPaint	-	-	225	75	1849	258	241	591
			backgroundConnect	-	-	336	293	419	32	354	410
			firstReactRender	-	-	23	15	54	7	25	41
			initialActions	-	-	1	0	5	1	1	3
			loadScripts	-	-	929	797	1860	189	898	1447
			setupStore	-	-	15	8	37	5	17	31
			numNetworkReqs	-	-	120	46	282	51	143	266
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	842	665	1061	103	915	1028
load			-	-	715	593	970	103	793	938
domContentLoaded			-	-	710	589	963	102	785	933
domInteractive			-	-	25	15	98	18	22	77
firstPaint			-	-	116	60	654	83	136	299
backgroundConnect			-	-	31	16	94	16	34	68
firstReactRender			-	-	15	10	34	5	17	28
initialActions			-	-	1	0	3	1	1	2
loadScripts			-	-	707	587	961	101	776	931
setupStore			-	-	11	5	37	5	12	23
numNetworkReqs			-	-	23	15	92	21	15	85
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	1206	894	1810	205	1312	1704
		load	-	-	693	606	1302	128	682	1042
		domContentLoaded	-	-	684	599	1293	127	668	1033
		domInteractive	-	-	35	17	229	35	34	121
		firstPaint	-	-	141	65	1039	123	154	356
		backgroundConnect	-	-	165	128	378	56	158	318
		firstReactRender	-	-	21	17	33	3	23	28
		initialActions	-	-	1	0	2	1	1	1
		loadScripts	-	-	681	597	1285	125	666	1023
		setupStore	-	-	11	4	21	3	13	17
		numNetworkReqs	-	-	119	43	284	55	145	263
		19	-	-	-	-	-	-	-	-
Firefox	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1553	1277	2135	174	1646	1891
			load	-	-	1309	1113	1788	139	1380	1547
			domContentLoaded	-	-	1307	1108	1788	140	1380	1547
			domInteractive	-	-	73	32	159	38	94	142
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	63	26	210	39	61	150
			firstReactRender	-	-	12	9	24	2	12	16
			initialActions	-	-	1	0	2	0	1	2
			loadScripts	-	-	1278	1092	1747	131	1344	1523
			setupStore	-	-	11	4	58	8	10	29
			numNetworkReqs	-	-	24	12	95	22	17	93
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	2957	2027	5341	668	3197	4458
			load	-	-	1706	1304	3303	419	1901	2489
			domContentLoaded	-	-	1705	1297	3303	419	1900	2489
			domInteractive	-	-	140	35	1688	189	126	417
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	341	113	1365	288	356	1026
			firstReactRender	-	-	21	14	85	10	21	32
			initialActions	-	-	2	1	3	1	2	2
			loadScripts	-	-	1649	1269	3269	395	1828	2345
			setupStore	-	-	142	9	1204	218	126	699
			numNetworkReqs	-	-	65	35	167	32	84	136
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	1628	1342	2366	181	1751	1953
load			-	-	1391	1147	1902	130	1455	1601
domContentLoaded			-	-	1390	1147	1901	131	1454	1601
domInteractive			-	-	95	29	237	44	130	173
firstPaint			-	-	-	-	-	-	-	-
backgroundConnect			-	-	62	25	192	39	66	167
firstReactRender			-	-	14	11	29	3	15	22
initialActions			-	-	1	0	2	1	2	2
loadScripts			-	-	1358	1132	1870	120	1419	1550
setupStore			-	-	21	4	189	35	13	128
numNetworkReqs			-	-	23	12	79	17	18	75
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	2660	2061	4179	453	2763	3834
		load	-	-	1497	1171	2532	289	1631	2154
		domContentLoaded	-	-	1496	1171	2531	289	1630	2154
		domInteractive	-	-	119	32	633	127	106	498
		firstPaint	-	-	-	-	-	-	-	-
		backgroundConnect	-	-	294	118	1353	234	285	863
		firstReactRender	-	-	21	16	74	8	22	29
		initialActions	-	-	2	0	3	1	2	3
		loadScripts	-	-	1454	1148	2515	263	1594	2011
		setupStore	-	-	148	6	1265	219	162	630
		numNetworkReqs	-	-	64	34	145	33	93	134
		19	-	-	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: e794234 | Date: 2/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±44ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 721ms (±40ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	44ms	1.00s	1.33s	1.06s	1.33s
domContentLoaded	721ms	40ms	695ms	992ms	749ms	992ms
firstPaint	76ms	11ms	56ms	160ms	84ms	160ms
firstContentfulPaint	76ms	11ms	56ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: -681 Bytes (-0.01%)
common: 20 Bytes (0%)

jeffsmale90 temporarily deployed to pr-comment February 4, 2026 19:59 — with GitHub Actions Inactive

metamaskbot added the team-delegation MetaMask Delegation Team label Feb 4, 2026

github-actions bot added the size-S label Feb 4, 2026

jeffsmale90 force-pushed the fix/permissions-layout branch from 5d6bc1d to dd0be9d Compare February 4, 2026 20:01

jeffsmale90 temporarily deployed to pr-comment February 4, 2026 20:01 — with GitHub Actions Inactive

Fix layout in routes so that gator permissions pages show with approp…

e794234

…riate fixed width - remove unused ref from first permissions page - rename page variables in routes component for clarity (GatorPermissions prefix)

jeffsmale90 force-pushed the fix/permissions-layout branch from dd0be9d to e794234 Compare February 4, 2026 20:16

jeffsmale90 marked this pull request as ready for review February 4, 2026 20:16

jeffsmale90 requested a review from a team as a code owner February 4, 2026 20:16

jeffsmale90 requested a deployment to pr-comment February 4, 2026 20:16 — with GitHub Actions In progress

jeffsmale90 temporarily deployed to pr-comment February 4, 2026 20:16 — with GitHub Actions Inactive

jeffsmale90 mentioned this pull request Feb 4, 2026

fix: GatorPermissionsController state syncing #39778

Closed

7 tasks

n3ps approved these changes Feb 4, 2026

View reviewed changes

mj-kiwi approved these changes Feb 4, 2026

View reviewed changes

jeffsmale90 enabled auto-merge February 4, 2026 20:41

jeffsmale90 temporarily deployed to pr-comment February 4, 2026 20:47 — with GitHub Actions Inactive

jeffsmale90 added this pull request to the merge queue Feb 4, 2026

Merged via the queue into main with commit c22bdf1 Feb 4, 2026
361 of 364 checks passed

jeffsmale90 deleted the fix/permissions-layout branch February 4, 2026 22:12

github-actions bot locked and limited conversation to collaborators Feb 4, 2026

metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: render "Dapp Connections" pages with constrained max width#39801

fix: render "Dapp Connections" pages with constrained max width#39801
jeffsmale90 merged 1 commit intomainfrom
fix/permissions-layout

jeffsmale90 commented Feb 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jeffsmale90 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jeffsmale90 commented Feb 4, 2026 •

edited

Loading

metamaskbotv2 bot commented Feb 4, 2026 •

edited

Loading