feat: handle in app shield notification nav by tuna1207 · Pull Request #39788 · MetaMask/metamask-extension

tuna1207 · 2026-02-04T14:10:46Z

Description

Handle in app navigation for shield feature announcement notification

Changelog

CHANGELOG entry: Shield notification in app navigation

Related issues

Fixes:

Manual testing steps

Go to notfications page
Select shield announcement notification
Click on CTA button
Should navigate to shield page in app instead of opening new tab

Screenshots/Recordings

Before

After

Screen.Recording.2026-02-04.at.19.46.32.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI routing change limited to Shield-specific carousel/notification IDs, with URL parsing guarded by try/catch. Main risk is a mis-match on IDs or query-param handling causing the CTA to do nothing or navigate incorrectly.

Overview
Routes Shield marketing entry points in-app instead of opening a new tab. Adds SHIELD_ANNOUNCEMENT_NOTIFICATION_ID plus a shared helper (getShieldInAppNavigationFromExternalLink) that converts an external Shield URL into an internal SETTINGS_ROUTE navigation with showShieldEntryModal and preserved query params.

Updates the Shield carousel card click handler to use the shared helper, and changes the feature-announcement external CTA so the Shield announcement notification uses react-router navigation (no href/external icon) while still emitting the same analytics event.

^{Written by Cursor Bugbot for commit 77ce10f. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-04T14:11:45Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +3 -7)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 carousel/
      - 📁 stack-card/
        
        📄 stack-card.tsx +3 -7

🔔 @MetaMask/notifications (1 files, +38 -3)

📁 ui/
- 📁 pages/
  - 📁 notifications/
    - 📁 notification-components/
      - 📁 feature-announcement/
        
        📄 annonucement-footer-buttons.tsx +38 -3

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

...s/notifications/notification-components/feature-announcement/annonucement-footer-buttons.tsx

shared/modules/shield/constants.ts

metamaskbotv2 · 2026-02-04T15:11:48Z

Builds ready [77ce10f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1359 ± 102 ms)

Platform	BuildType	Page	Metric	Test Title (ms)	Persona (ms)	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1359	1142	1675	102	1429	1518
			load	-	-	1172	963	1440	96	1232	1336
			domContentLoaded	-	-	1166	959	1434	96	1221	1330
			domInteractive	-	-	27	15	96	18	24	78
			firstPaint	-	-	151	66	379	72	197	287
			backgroundConnect	-	-	234	212	282	15	241	264
			firstReactRender	-	-	17	10	30	4	19	25
			initialActions	-	-	1	0	4	1	1	3
			loadScripts	-	-	948	751	1214	95	1005	1107
			setupStore	-	-	12	6	30	5	16	22
			numNetworkReqs	-	-	23	15	94	20	15	83
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1981	1357	6432	881	1887	4360
			load	-	-	1158	1014	1793	154	1164	1565
			domContentLoaded	-	-	1144	1001	1781	152	1146	1556
			domInteractive	-	-	36	18	161	27	34	115
			firstPaint	-	-	187	72	548	91	240	378
			backgroundConnect	-	-	448	282	2459	426	341	1616
			firstReactRender	-	-	23	15	74	9	24	42
			initialActions	-	-	1	0	5	1	1	4
			loadScripts	-	-	903	771	1424	136	900	1296
			setupStore	-	-	15	7	38	6	17	33
			numNetworkReqs	-	-	120	47	258	46	150	194
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	984	778	1426	118	1052	1170
load			-	-	813	668	1307	121	910	1010
domContentLoaded			-	-	806	661	1300	121	900	1004
domInteractive			-	-	32	20	118	23	27	91
firstPaint			-	-	135	67	401	70	179	280
backgroundConnect			-	-	41	20	170	28	44	127
firstReactRender			-	-	25	11	288	38	24	40
initialActions			-	-	1	0	5	1	1	3
loadScripts			-	-	803	659	1298	120	895	1001
setupStore			-	-	16	8	57	9	18	41
numNetworkReqs			-	-	23	15	96	21	15	83
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	1248	889	1975	213	1324	1786
		load	-	-	721	609	1206	119	715	1068
		domContentLoaded	-	-	711	604	1198	119	705	1054
		domInteractive	-	-	34	18	114	22	32	101
		firstPaint	-	-	152	64	635	98	192	358
		backgroundConnect	-	-	161	130	386	48	162	319
		firstReactRender	-	-	22	16	47	5	24	30
		initialActions	-	-	1	0	4	1	1	1
		loadScripts	-	-	708	602	1191	117	703	1045
		setupStore	-	-	12	4	21	4	15	19
		numNetworkReqs	-	-	133	46	287	52	154	262
		19	-	-	-	-	-	-	-	-
Firefox	Browserify	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	1640	1374	2233	183	1751	2028
			load	-	-	1379	1182	1830	142	1484	1638
			domContentLoaded	-	-	1379	1176	1830	143	1483	1638
			domInteractive	-	-	82	33	243	43	101	152
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	77	33	246	47	103	168
			firstReactRender	-	-	12	9	17	1	13	14
			initialActions	-	-	1	0	3	1	2	2
			loadScripts	-	-	1337	1156	1681	126	1423	1609
			setupStore	-	-	16	5	159	23	12	62
			numNetworkReqs	-	-	25	12	100	22	18	86
			19	-	-	-	-	-	-	-	-
	Browserify	Power User Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
			2	-	-	-	-	-	-	-	-
			3	-	-	-	-	-	-	-	-
			4	-	-	-	-	-	-	-	-
			5	-	-	-	-	-	-	-	-
			6	-	-	-	-	-	-	-	-
			7	-	-	-	-	-	-	-	-
			8	-	-	-	-	-	-	-	-
			9	-	-	-	-	-	-	-	-
			10	-	-	-	-	-	-	-	-
			11	-	-	-	-	-	-	-	-
			12	-	-	-	-	-	-	-	-
			13	-	-	-	-	-	-	-	-
			14	-	-	-	-	-	-	-	-
			15	-	-	-	-	-	-	-	-
			16	-	-	-	-	-	-	-	-
			17	-	-	-	-	-	-	-	-
			18	-	-	-	-	-	-	-	-
			uiStartup	-	-	2793	2113	7206	777	2876	3946
			load	-	-	1597	1219	5664	627	1618	2349
			domContentLoaded	-	-	1596	1219	5664	627	1618	2349
			domInteractive	-	-	130	34	632	112	130	370
			firstPaint	-	-	-	-	-	-	-	-
			backgroundConnect	-	-	310	106	1473	300	295	1085
			firstReactRender	-	-	18	14	67	9	18	26
			initialActions	-	-	2	0	7	1	2	3
			loadScripts	-	-	1552	1194	5607	617	1547	2217
			setupStore	-	-	143	7	761	195	181	640
			numNetworkReqs	-	-	72	40	138	29	93	134
			19	-	-	-	-	-	-	-	-
	Webpack	Standard Home	0	-	-	-	-	-	-	-	-
			1	-	-	-	-	-	-	-	-
2			-	-	-	-	-	-	-	-
3			-	-	-	-	-	-	-	-
4			-	-	-	-	-	-	-	-
5			-	-	-	-	-	-	-	-
6			-	-	-	-	-	-	-	-
7			-	-	-	-	-	-	-	-
8			-	-	-	-	-	-	-	-
9			-	-	-	-	-	-	-	-
10			-	-	-	-	-	-	-	-
11			-	-	-	-	-	-	-	-
12			-	-	-	-	-	-	-	-
13			-	-	-	-	-	-	-	-
14			-	-	-	-	-	-	-	-
15			-	-	-	-	-	-	-	-
16			-	-	-	-	-	-	-	-
17			-	-	-	-	-	-	-	-
18			-	-	-	-	-	-	-	-
uiStartup			-	-	1665	1379	2145	170	1802	2004
load			-	-	1420	1205	1726	113	1518	1606
domContentLoaded			-	-	1420	1205	1726	113	1514	1606
domInteractive			-	-	101	28	246	43	131	182
firstPaint			-	-	-	-	-	-	-	-
backgroundConnect			-	-	72	26	191	43	117	155
firstReactRender			-	-	14	11	24	2	15	19
initialActions			-	-	1	0	3	1	2	2
loadScripts			-	-	1376	1185	1697	96	1439	1531
setupStore			-	-	17	6	256	31	12	53
numNetworkReqs			-	-	24	12	96	21	18	83
19			-	-	-	-	-	-	-	-
Webpack	Power User Home	0	-	-	-	-	-	-	-	-
		1	-	-	-	-	-	-	-	-
		2	-	-	-	-	-	-	-	-
		3	-	-	-	-	-	-	-	-
		4	-	-	-	-	-	-	-	-
		5	-	-	-	-	-	-	-	-
		6	-	-	-	-	-	-	-	-
		7	-	-	-	-	-	-	-	-
		8	-	-	-	-	-	-	-	-
		9	-	-	-	-	-	-	-	-
		10	-	-	-	-	-	-	-	-
		11	-	-	-	-	-	-	-	-
		12	-	-	-	-	-	-	-	-
		13	-	-	-	-	-	-	-	-
		14	-	-	-	-	-	-	-	-
		15	-	-	-	-	-	-	-	-
		16	-	-	-	-	-	-	-	-
		17	-	-	-	-	-	-	-	-
		18	-	-	-	-	-	-	-	-
		uiStartup	-	-	2617	1966	3912	406	2731	3701
		load	-	-	1530	1216	2503	248	1663	2054
		domContentLoaded	-	-	1530	1216	2503	249	1663	2054
		domInteractive	-	-	115	33	546	90	121	355
		firstPaint	-	-	-	-	-	-	-	-
		backgroundConnect	-	-	253	107	1263	196	252	834
		firstReactRender	-	-	20	15	59	5	23	28
		initialActions	-	-	2	0	4	1	2	3
		loadScripts	-	-	1490	1202	2481	237	1607	2025
		setupStore	-	-	215	7	1162	265	334	755
		numNetworkReqs	-	-	67	36	159	29	93	119
		19	-	-	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: 77ce10f | Date: 2/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 997ms (±38ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 691ms (±36ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	997ms	38ms	975ms	1.26s	1.04s	1.26s
domContentLoaded	691ms	36ms	672ms	940ms	733ms	940ms
firstPaint	77ms	10ms	64ms	168ms	88ms	168ms
firstContentfulPaint	77ms	10ms	64ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 451 Bytes (0.01%)
ui: 3.67 KiB (0.04%)
common: 2.79 KiB (0.03%)

feat: handle in app shield notification nav

ae7da18

tuna1207 temporarily deployed to pr-comment February 4, 2026 14:10 — with GitHub Actions Inactive

metamaskbot added the team-onboarding Onboarding team label Feb 4, 2026

github-actions bot added the size-S label Feb 4, 2026

tuna1207 added area-shield team-shield Shield team and removed team-onboarding Onboarding team labels Feb 4, 2026

tuna1207 requested review from chaitanyapotti, lionellbriones and lwin-kyaw February 4, 2026 14:13

tuna1207 marked this pull request as ready for review February 4, 2026 14:13

tuna1207 requested review from a team as code owners February 4, 2026 14:13

tuna1207 temporarily deployed to pr-comment February 4, 2026 14:13 — with GitHub Actions Inactive

cursor bot reviewed Feb 4, 2026

View reviewed changes

tuna1207 added 2 commits February 4, 2026 21:35

fix: constant name type

dd85ad2

fix: try catch url params

77ce10f

tuna1207 temporarily deployed to pr-comment February 4, 2026 14:35 — with GitHub Actions Inactive

lionellbriones approved these changes Feb 4, 2026

View reviewed changes

lwin-kyaw approved these changes Feb 4, 2026

View reviewed changes

tuna1207 temporarily deployed to pr-comment February 4, 2026 15:07 — with GitHub Actions Inactive

chaitanyapotti enabled auto-merge February 5, 2026 09:13

Prithpal-Sooriya approved these changes Feb 5, 2026

View reviewed changes

chaitanyapotti added this pull request to the merge queue Feb 5, 2026

Merged via the queue into main with commit 062761f Feb 5, 2026
183 checks passed

chaitanyapotti deleted the feat/notification-shield-in-app-nav branch February 5, 2026 11:13

github-actions bot locked and limited conversation to collaborators Feb 5, 2026

metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: handle in app shield notification nav#39788

feat: handle in app shield notification nav#39788
chaitanyapotti merged 3 commits intomainfrom
feat/notification-shield-in-app-nav

tuna1207 commented Feb 4, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

tuna1207 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tuna1207 commented Feb 4, 2026 •

edited

Loading

metamaskbotv2 bot commented Feb 4, 2026 •

edited

Loading