fix: Update activity log header to use arrow disclosure variant#39767
Merged
georgewrmarshall merged 2 commits intomainfrom Feb 5, 2026
Merged
fix: Update activity log header to use arrow disclosure variant#39767georgewrmarshall merged 2 commits intomainfrom
georgewrmarshall merged 2 commits intomainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +2 -0)
|
| <Disclosure | ||
| title={t('activityLog')} | ||
| size="small" | ||
| variant="arrow" |
There was a problem hiding this comment.
Missing size argument causes small text variant to be ignored
Low Severity
The size="small" prop passed to Disclosure has no effect when using variant="arrow". In disclosure.js, renderSummaryByType(variant, title) is called without the size argument, so the arrow variant's text sizing logic (size === 'small' ? TextVariant.bodySm : TextVariant.bodyMd) always evaluates to bodyMd. The Activity Log header will render with medium text instead of the intended small text.
ea06d95 to
61dff95
Compare
ui/components/app/transaction-list-item-details/transaction-list-item-details.component.js
Outdated
Show resolved
Hide resolved
Contributor
Builds ready [61dff95]
UI Startup Metrics (1352 ± 84 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Replace string literal "arrow" with DisclosureVariant.Arrow enum constant in transaction-list-item-details component for improved type safety and consistency with other usages across the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Builds ready [61ed57b]
UI Startup Metrics (1371 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brianacnguyen
approved these changes
Feb 5, 2026
n3ps
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses MDP-464 by updating the Activity Log header in the transaction details modal to use a more intuitive accordion-style interface.
What is the reason for the change?
The Activity Log header was using a "+" icon which didn't follow standard accordion UI patterns and the interaction was inconsistent with typical disclosure components.
What is the improvement/solution?
Changelog
CHANGELOG entry: Updated Activity Log header to use arrow disclosure variant for better UX consistency
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MDP-464
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small UI-only change that alters the
Disclosurevariant used for the transaction details Activity Log; minimal functional risk beyond potential styling/regression in that section.Overview
Updates the transaction details modal’s Activity Log section to use the
DisclosureVariant.Arrowaccordion styling instead of the default disclosure presentation.This adds an import for
DisclosureVariantand passesvariant={DisclosureVariant.Arrow}to the Activity LogDisclosure, aligning the header behavior/iconography with standard accordion patterns.Written by Cursor Bugbot for commit 61ed57b. This will update automatically on new commits. Configure here.