Skip to content

fix: missing swap activity in token details#39753

Merged
n3ps merged 3 commits intomainfrom
fix/swap-in-token-page-activity
Feb 5, 2026
Merged

fix: missing swap activity in token details#39753
n3ps merged 3 commits intomainfrom
fix/swap-in-token-page-activity

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Feb 3, 2026

Description

Fix missing swap activity from showing up when in the token details page

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: missing token activity in details page

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-1831

Manual testing steps

  1. Make a swap transaction
  2. Observe item in Activity tab
  3. Observe item in the token details page of the swapped asset

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adjusts token-details transaction filtering to treat swaps to the swap contract as involving the native token even when the native address is not present in calldata, which may slightly increase false-positive matches for routed swaps.

Overview
Fixes missing swap entries in the token details Activity view for the native asset by loosening getTransactionGroupRecipientAddressFilter.

When filtering by NATIVE_TOKEN_ADDRESS, swap transactions sent to the swap contract are now accepted even if the native token address is not encoded in calldata (e.g., ETH via msg.value or internal transfers), improving visibility of native-token swap activity.

Written by Cursor Bugbot for commit d991787. This will update automatically on new commits. Configure here.

@n3ps n3ps requested a review from a team as a code owner February 3, 2026 20:13
@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@n3ps n3ps enabled auto-merge February 3, 2026 20:14
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 3, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +29 -3)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 transaction-list/
          • 📄 unified-transaction-list.component.js +29 -3

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 3, 2026

Builds ready [d991787]
UI Startup Metrics (1386 ± 81 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1386118715938114431522
load--118197214108912451305
domContentLoaded--117596714038912401299
domInteractive--2716104182374
firstPaint--148681087111181291
backgroundConnect--23221327913235265
firstReactRender--17103341925
initialActions--104112
loadScripts--95875111859110261082
setupStore--1362951624
numNetworkReqs--221583181577
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--20411705246813821062320
load--11881058195816211731636
domContentLoaded--11711048185815411561606
domInteractive--39191652939120
firstPaint--228751875278248407
backgroundConnect--33329949534343415
firstReactRender--24165972639
initialActions--104112
loadScripts--92480916121459111343
setupStore--1684061832
numNetworkReqs--1245326054149250
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--8206621138948751009
load--702590102790763862
domContentLoaded--696586101889759855
domInteractive--251687172275
firstPaint--1166128954153230
backgroundConnect--3318132213479
firstReactRender--15103551625
initialActions--105112
loadScripts--694584101689757846
setupStore--1264361123
numNetworkReqs--221584181576
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13001023187722614151774
load--73862011541177361078
domContentLoaded--72861511401187261072
domInteractive--37191502740116
firstPaint--16264698111190440
backgroundConnect--16413342751164293
firstReactRender--25174552638
initialActions--104111
loadScripts--72561311251157241064
setupStore--1365251420
numNetworkReqs--1255126057154249
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15531283203917316481930
load--13111108176514714101609
domContentLoaded--13101107176514714091604
domInteractive--70322394294146
firstPaint--------
backgroundConnect--57271762856132
firstReactRender--1291911214
initialActions--103112
loadScripts--12811090171513313811569
setupStore--136138191037
numNetworkReqs--221187171877
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29802225476358830494337
load--15681282265032816982372
domContentLoaded--15671282265032816972371
domInteractive--11635691112118380
firstPaint--------
backgroundConnect--3281211431275341938
firstReactRender--19147681927
initialActions--107122
loadScripts--15121215262430515912227
setupStore--1428770207173674
numNetworkReqs--72362004497188
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16271364224918117331966
load--13951199196313314691666
domContentLoaded--13941199196213314691666
domInteractive--822831852125184
firstPaint--------
backgroundConnect--742223448114165
firstReactRender--14102831519
initialActions--103122
loadScripts--13521179185511814201571
setupStore--193310381270
numNetworkReqs--231284171970
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--311422068806102532074360
load--17791313726690018482457
domContentLoaded--17791312726690018482457
domInteractive--12033724129112495
firstPaint--------
backgroundConnect--3471171386296340920
firstReactRender--21153232327
initialActions--203123
loadScripts--17071289723789017502290
setupStore--1818932232310728
numNetworkReqs--70351964389181
19--------
📊 Page Load Benchmark Results

Current Commit: d991787 | Date: 2/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±62ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±84ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 91ms (±151ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 62ms 1.01s 1.60s 1.06s 1.60s
domContentLoaded 730ms 84ms 699ms 1.53s 746ms 1.53s
firstPaint 91ms 151ms 64ms 1.59s 84ms 1.59s
firstContentfulPaint 91ms 151ms 64ms 1.59s 84ms 1.59s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 50 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps marked this pull request as draft February 3, 2026 21:54
auto-merge was automatically disabled February 3, 2026 21:54

Pull request was converted to draft

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 4, 2026

Builds ready [ff8156e]
UI Startup Metrics (1402 ± 117 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14021179175111714791596
load--12061001153410912711397
domContentLoaded--1198995152510712651392
domInteractive--2514100192179
firstPaint--167661057117215297
backgroundConnect--23221129516234272
firstReactRender--1894372234
initialActions--106114
loadScripts--983776130210810521178
setupStore--1364161527
numNetworkReqs--221582171571
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--21811638672264921612865
load--11621025173614611921523
domContentLoaded--11441016172114511651514
domInteractive--35181832732103
firstPaint--195711735175243321
backgroundConnect--4042763161384346639
firstReactRender--26166192946
initialActions--106112
loadScripts--90677614451359291237
setupStore--1675271828
numNetworkReqs--1225124653141239
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--85566611101099471051
load--7255981005105782939
domContentLoaded--720594996104775934
domInteractive--2514100172176
firstPaint--996122041128183
backgroundConnect--301878113653
firstReactRender--1593251526
initialActions--104112
loadScripts--717592994104767932
setupStore--1162641122
numNetworkReqs--221586171575
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1288852230826915101798
load--72261612911187251045
domContentLoaded--71260812851187151038
domInteractive--43182494535158
firstPaint--1557055798198382
backgroundConnect--16812939356167324
firstReactRender--22173232328
initialActions--102111
loadScripts--70960612751167121029
setupStore--1153741317
numNetworkReqs--1304926157154254
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15131247195015016281760
load--12801082175612813771497
domContentLoaded--12791082175012813771497
domInteractive--65312614187138
firstPaint--------
backgroundConnect--60271753259147
firstReactRender--1293431214
initialActions--103012
loadScripts--12481058172511813421471
setupStore--1154261129
numNetworkReqs--221286171870
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29002124458647530334024
load--15261251248226816732189
domContentLoaded--15251251247926816732189
domInteractive--13134548113145390
firstPaint--------
backgroundConnect--3191091403266355929
firstReactRender--19136291826
initialActions--103122
loadScripts--14781230245924216122092
setupStore--1238771183128670
numNetworkReqs--803523646100189
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16491394214117517642004
load--14171199180412515071617
domContentLoaded--14171199180412515061617
domInteractive--963023144131165
firstPaint--------
backgroundConnect--72253515586186
firstReactRender--14103031420
initialActions--103112
loadScripts--13761179177911114501553
setupStore--134125171133
numNetworkReqs--231286191879
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--28062183508446729543738
load--15661243409834416942112
domContentLoaded--15661243409734416932112
domInteractive--1223461095125304
firstPaint--------
backgroundConnect--2651091345203283815
firstReactRender--22155862531
initialActions--215123
loadScripts--15161228402832716301959
setupStore--1707802219242671
numNetworkReqs--81352765093206
19--------
📊 Page Load Benchmark Results

Current Commit: ff8156e | Date: 2/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±36ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 38ms 1.01s 1.32s 1.07s 1.32s
domContentLoaded 723ms 36ms 697ms 984ms 756ms 984ms
firstPaint 78ms 10ms 64ms 164ms 88ms 164ms
firstContentfulPaint 78ms 10ms 64ms 164ms 88ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 87 Bytes (0%)
  • ui: -38.52 KiB (-0.47%)
  • common: 92 Bytes (0%)

Copy link
Contributor

@AndyMBridges AndyMBridges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated swap activity on token details page

Image

@n3ps n3ps marked this pull request as ready for review February 4, 2026 15:12
@n3ps n3ps added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 15162c3 Feb 5, 2026
175 checks passed
@n3ps n3ps deleted the fix/swap-in-token-page-activity branch February 5, 2026 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.18.0 Issue or pull request that will be included in release 13.18.0 size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants