fix: restore swap/bridge quote if using extension in popup mode#39654
Merged
fix: restore swap/bridge quote if using extension in popup mode#39654
Conversation
Contributor
Builds ready [ed4a86d]
UI Startup Metrics (1337 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [5fc28c5]
UI Startup Metrics (1299 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
ghgoodreau
approved these changes
Jan 30, 2026
Contributor
Builds ready [27a3c04]
UI Startup Metrics (1318 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
SteP-n-s
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug in which the extension could get in an invalid state when it's open both in fullscreen and sidepanel mode.
Changelog
CHANGELOG entry: fix: restore swap quote only when using extension in popup mode
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3598
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes routing logic that controls automatic navigation into swap/bridge flows, which could alter user navigation behavior across fullscreen/notification/popup environments. Risk is moderate because it affects swap/bridge UX but does not touch security-sensitive code.
Overview
Popup-only swap/bridge restoration: Updates
ConfirmationHandlerto detectENVIRONMENT_TYPE_POPUPand only auto-redirect to the cross-chain swap prepare route when bridge quotes exist in popup mode.This removes the prior auto-redirect into
PREPARE_SWAP_ROUTEbased on swap quotes/fetch params, reducing unexpected navigation in non-popup contexts while preserving the awaiting-swap redirect and approval-routing behavior.Written by Cursor Bugbot for commit 27a3c04. This will update automatically on new commits. Configure here.