Merged
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (1 files, +4 -16)
|
Contributor
Builds ready [0e92735]
UI Startup Metrics (1315 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [bb0f509]
UI Startup Metrics (1354 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
ghgoodreau
approved these changes
Jan 30, 2026
Contributor
Builds ready [834a00c]
UI Startup Metrics (1352 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
SteP-n-s
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the MM fee disclaimer condition to check the MM feeData amount
Changelog
CHANGELOG entry: chore: check MM feeData amount to determine swap MM fee disclaimer visibility
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3249
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: only changes when a UI disclaimer renders and updates localized string copy, with no auth/security or state mutation changes.
Overview
Updates the bridge “no MetaMask fee” disclaimer to render based on
activeQuote.quote.feeData.metabridge.amount === 0instead of a destination-asset allowlist, and removes the token-symbol interpolation.Adjusts
noMMFeeSwappinglocale strings (en/en_GB) to the new static copy: "No MetaMask fee".Written by Cursor Bugbot for commit 834a00c. This will update automatically on new commits. Configure here.