chore: remove network dropdown from Activity tab#39565
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (4 files, +27 -354)
|
4814adf to
d4e00e6
Compare
Contributor
Builds ready [5046fae]
UI Startup Metrics (1276 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
n3ps
commented
Jan 27, 2026
| @@ -529,13 +528,11 @@ const AssetPage = ({ | |||
| {showUnifiedTransactionList ? ( | |||
| <UnifiedTransactionList | |||
| tokenAddress={address} | |||
Contributor
Author
There was a problem hiding this comment.
- Remove the need to "hide"
n3ps
commented
Jan 27, 2026
|
|
||
| <Box className="transaction-list" {...boxProps}> | ||
| {!hideNetworkFilter && ( | ||
| <AssetListControlBar |
n3ps
commented
Jan 27, 2026
| groupEvmAddress, | ||
| ]); | ||
|
|
||
| const enabledNetworksForAllNamespaces = useSelector( |
Contributor
Author
There was a problem hiding this comment.
- Leads to removing now-unnecessary code
vinnyhoward
approved these changes
Jan 27, 2026
AndyMBridges
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the network dropdown from the Activity tab
This reduces confusion as the dropdown effect is across the app. This is also in preparation for a proper Activity view refactor with its own sort and filter.
Changelog
CHANGELOG entry: chore: remove network dropdown from Activity tab
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-845
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes the network selector from the Activity tab and simplifies activity filtering to improve consistency across views.
AssetListControlBarand thehideNetworkFilterprop fromTransactionListandUnifiedTransactionList; removes chain-based filtering utility (filterTransactionByChain) and its testsTransactionList/UnifiedTransactionListnow display completed transactions from all networks by default (token/chain overrides still honored); adjusts grouping and pagination accordinglyWritten by Cursor Bugbot for commit 5046fae. This will update automatically on new commits. Configure here.