Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
requested changes
Jan 26, 2026
Contributor
Builds ready [f441676]
UI Startup Metrics (1147 ± 109 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
matthewwalsh0
requested changes
Jan 26, 2026
Contributor
Builds ready [e497bec]
UI Startup Metrics (1307 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [8e9bb95]
UI Startup Metrics (1348 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [d68c38f]
UI Startup Metrics (1328 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Feb 3, 2026
pedronfigueiredo
approved these changes
Feb 3, 2026
Contributor
Builds ready [8db4cc1]
UI Startup Metrics (1352 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [2e49310]
UI Startup Metrics (1377 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug where EIP-7702 delegation publish transactions were being dropped when a nonce remained in txParams. The delegation system manages nonces externally; leaving a nonce in the tx params caused the delegation relay/path to reject or drop the transaction.
Changelog
CHANGELOG entry: Fixed a bug where EIP-7702 delegation publish transactions are being dropped by removing nonce from txParams.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Successful 7702 dapp transaction are being dropped and not visible in activity tab.
Screen.Recording.2026-01-26.at.15.15.55.mov
After
Successful 7702 dapp transaction are visible in activity tab.
Screen.Recording.2026-01-26.at.15.13.30.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches the EIP-7702 delegation publish path and mutates persisted
TransactionMetaviaTransactionController:updateTransaction, which could affect relay submission and activity state if incorrect. Change is scoped and covered by updated unit tests.Overview
Fixes EIP-7702 delegation publish transactions being dropped by removing
txParams.noncebefore constructing relay requests (delegation, executions, and optional authorization list), letting the relay choose the nonce.When a nonce is present, the hook now persists the nonce-stripped
TransactionMetaviaTransactionController:updateTransactionwith an explicit reason; tests were updated to wire the new messenger action and assert update/no-update behavior, plus nonce sourcing for authorization list now relies ongetNextNoncewhen needed.Written by Cursor Bugbot for commit 2e49310. This will update automatically on new commits. Configure here.