Skip to content

feat: enable require-pr-numbers flag for changelog generation#38520

Merged
Qbandev merged 3 commits intomainfrom
feat/require-pr-numbers-changelog
Dec 4, 2025
Merged

feat: enable require-pr-numbers flag for changelog generation#38520
Qbandev merged 3 commits intomainfrom
feat/require-pr-numbers-changelog

Conversation

@Qbandev
Copy link
Copy Markdown
Contributor

@Qbandev Qbandev commented Dec 3, 2025

Description

This PR updates the changelog workflows to use the new @metamask/auto-changelog@5.3.0 which always filters out direct commits without PR numbers. This ensures all changelog entries represent reviewed and approved changes.

Changes:

  • Update @metamask/auto-changelog from ^5.1.0 to ^5.3.0
  • Update workflows to use github-tools@v1.1.2 which includes the --requirePrNumbers flag enabled by default

The --requirePrNumbers flag is now always applied by default in github-tools, so no additional configuration is needed.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Manual testing steps

  1. Tested on consensys-test/metamask-extension-test with release/1100.0.0
  2. Verified PR commits are included in changelog
  3. Verified direct commits are excluded from changelog
  4. See generated changelog

Screenshots/Recordings

Before

Direct commits without PR numbers would appear in the changelog.

After

Only commits with PR numbers (representing reviewed changes) appear in the changelog.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Update changelog workflows to filter out direct commits without PR numbers,
ensuring all changelog entries represent reviewed and approved changes.

Changes:
- Update @metamask/auto-changelog to ^5.3.0
- Add require-pr-numbers: 'true' to update-release-changelog workflow
- Add require-pr-numbers: 'true' to create-release-pr workflow
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Dec 3, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 3, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​auto-changelog@​5.1.0 ⏵ 5.3.098 -210010093 -7100

View full report

@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 3, 2025

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
Network access: npm @metamask/auto-changelog in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: package.jsonnpm/@metamask/auto-changelog@5.3.0

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/auto-changelog@5.3.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1843af0]
UI Startup Metrics (1158 ± 91 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup115897314219112091326
load96980911577810161132
domContentLoaded96480611527710111126
domInteractive231484161975
firstPaint4787811593739481071
backgroundConnect20318523111209223
firstReactRender301988113451
getState3315103154060
initialActions106112
loadScripts76762494973811905
setupStore1052441218
numNetworkReqs1056716561
BrowserifyPower User HomeuiStartup20161750263718921052425
load1018888176312810251300
domContentLoaded1002873168512410101290
domInteractive3218120213394
firstPaint54011017454249661309
backgroundConnect260205786119235652
firstReactRender5741106146289
getState19613270876208240
initialActions102112
loadScripts79166514341207921074
setupStore21124482441
numNetworkReqs1346628257190241
WebpackStandard HomeuiStartup826701121682868967
load64156880765685774
domContentLoaded63656580064681768
domInteractive2615115192288
firstPaint21882805154210638
backgroundConnect1053151117
firstReactRender2920194183238
getState25135193344
initialActions103111
loadScripts63356379263673765
setupStore1163651320
numNetworkReqs1057116557
WebpackPower User HomeuiStartup15751278207720616781993
load67757495389688915
domContentLoaded66656894589675910
domInteractive36171672935115
firstPaint258102991171251680
backgroundConnect78864617320578
firstReactRender58448286575
getState17112923617178197
initialActions104113
loadScripts66456693787673901
setupStore21769122550
numNetworkReqs1616541363220286
FirefoxBrowserifyStandard HomeuiStartup13521086231818614761621
load1116937198414411861357
domContentLoaded1116937198414411861356
domInteractive70318838887131
firstPaint------
backgroundConnect48231943352124
firstReactRender23185662337
getState127154161019
initialActions113022
loadScripts1084920188712911591287
setupStore136107141333
numNetworkReqs1256717664
BrowserifyPower User HomeuiStartup25561875548756526333864
load1204921296933011832056
domContentLoaded1203921296933011832055
domInteractive1123243889113356
firstPaint------
backgroundConnect131251153155135424
firstReactRender5634248235887
getState25028908205253757
initialActions207123
loadScripts1155907275327111421549
setupStore1765809217216763
numNetworkReqs89572554482207
WebpackStandard HomeuiStartup15101296184712315891779
load12491066153810413251435
domContentLoaded12491064153810413251435
domInteractive62232053884134
firstPaint------
backgroundConnect48171582752113
firstReactRender27218282939
getState147172181245
initialActions102012
loadScripts12221050150910213011406
setupStore15687161457
numNetworkReqs1256616763
WebpackPower User HomeuiStartup28992079496964429164463
load14551202300338014642633
domContentLoaded14541202300238014632632
domInteractive1113265395108310
firstPaint------
backgroundConnect165381185217143857
firstReactRender5840171176193
getState27944897222389811
initialActions501031527
loadScripts13891166285230514282349
setupStore1417730179129594
numNetworkReqs915230743100183
📊 Page Load Benchmark Results

Current Commit: 1843af0 | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±63ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±60ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 63ms 1.00s 1.31s 1.26s 1.31s
domContentLoaded 724ms 60ms 691ms 992ms 928ms 992ms
firstPaint 75ms 10ms 60ms 152ms 88ms 152ms
firstContentfulPaint 75ms 10ms 60ms 152ms 88ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 3.81 KiB (0.07%)
  • ui: 6 Bytes (0%)
  • common: -34.17 KiB (-0.38%)

The github-tools actions now always use --requirePrNumbers by default,
so the parameter is no longer needed.
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [dfffec5]
UI Startup Metrics (1273 ± 111 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12731078169011113451471
load106688313179511391235
domContentLoaded106088013099411321229
domInteractive2816163242286
firstPaint53784124542010451188
backgroundConnect22219828213230249
firstReactRender331982133967
getState39171352244103
initialActions106114
loadScripts8446801103919161004
setupStore1373761526
numNetworkReqs1156917561
BrowserifyPower User HomeuiStartup19841668277322121142397
load1016887173413610461316
domContentLoaded1004880171513510401310
domInteractive3116119213190
firstPaint4948817283969321248
backgroundConnect258200821122227566
firstReactRender50396665462
getState20014671488199284
initialActions102112
loadScripts79666814621308211095
setupStore15103961534
numNetworkReqs78611592274145
WebpackStandard HomeuiStartup77265495670803920
load60853482273650776
domContentLoaded60353081673645770
domInteractive2414104202084
firstPaint27897774203541687
backgroundConnect1054161022
firstReactRender25183963036
getState22125493041
initialActions102111
loadScripts60152881472643767
setupStore1054251116
numNetworkReqs1156717565
WebpackPower User HomeuiStartup16411249228225418852082
load67358895982694868
domContentLoaded66558294782687862
domInteractive31171052130100
firstPaint28187909210261787
backgroundConnect1626655234475582
firstReactRender6046104106482
getState1749929122181208
initialActions103012
loadScripts66258094480685852
setupStore18957111645
numNetworkReqs81652503473152
FirefoxBrowserifyStandard HomeuiStartup13081075169614614031625
load107892413549411391282
domContentLoaded107792413539411371281
domInteractive56301452983121
firstPaint------
backgroundConnect45211773142123
firstReactRender23183842435
getState147214241037
initialActions103112
loadScripts105190612988511121237
setupStore12683111236
numNetworkReqs1256617763
BrowserifyPower User HomeuiStartup30341916486786138274649
load1373994262147713452553
domContentLoaded1373994262047713442553
domInteractive1043239268122258
firstPaint------
backgroundConnect2562315363672921187
firstReactRender63372632863100
getState281761030240298865
initialActions3057727
loadScripts1241978250033412032294
setupStore111677716789576
numNetworkReqs855316231113153
WebpackStandard HomeuiStartup14921245199915315531843
load12341061149710013071415
domContentLoaded12341061149710013071415
domInteractive58281703285111
firstPaint------
backgroundConnect48191823055121
firstReactRender2720147132834
getState187177291494
initialActions103122
loadScripts1206104514209312751355
setupStore146143151336
numNetworkReqs1256617762
WebpackPower User HomeuiStartup32662242621486041694723
load17211168459760621992766
domContentLoaded17211168459760621992765
domInteractive150301249210148400
firstPaint------
backgroundConnect2182512492892021020
firstReactRender64402393063108
getState30281974255363885
initialActions208123
loadScripts16061108449852916032582
setupStore104779115891523
numNetworkReqs865420534114163
📊 Page Load Benchmark Results

Current Commit: dfffec5 | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.09s (±133ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 772ms (±156ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 90ms (±116ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.09s 133ms 1.03s 2.17s 1.37s 2.17s
domContentLoaded 772ms 156ms 714ms 2.13s 1.03s 2.13s
firstPaint 90ms 116ms 60ms 1.24s 92ms 1.24s
firstContentfulPaint 90ms 116ms 60ms 1.24s 92ms 1.24s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 25.64 KiB (0.5%)
  • ui: 7.9 KiB (0.1%)
  • common: -33.64 KiB (-0.37%)

Update workflows to use the released v1.1.2 version of github-tools
which includes the --requirePrNumbers flag enabled by default.
@Qbandev Qbandev marked this pull request as ready for review December 4, 2025 09:19
@Qbandev Qbandev requested a review from Copilot December 4, 2025 09:19
@Qbandev Qbandev enabled auto-merge December 4, 2025 09:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the changelog generation tooling to enforce that all changelog entries represent reviewed changes by filtering out direct commits without PR numbers. The upgrade involves updating the @metamask/auto-changelog package and the GitHub Actions workflows that use it.

Key changes:

  • Upgrade @metamask/auto-changelog from ^5.1.0 to ^5.3.0 to support PR number filtering
  • Update GitHub workflow actions to use github-tools@v1.1.2 which includes the --requirePrNumbers flag enabled by default

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updates @metamask/auto-changelog dependency version from ^5.1.0 to ^5.3.0
yarn.lock Reflects the package.json change with updated version and checksum for @metamask/auto-changelog
.github/workflows/update-release-changelog.yml Updates action reference from @v1.1.0 to @v1.1.2 and sets github-tools-version parameter to v1.1.2
.github/workflows/create-release-pr.yml Updates action reference from @v1.1.0 to @v1.1.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [506f535]
UI Startup Metrics (1245 ± 107 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12451042173610713181405
load103787112868410891191
domContentLoaded103186612638310821183
domInteractive261594192285
firstPaint4957412143919921136
backgroundConnect21820233918222244
firstReactRender311966113456
getState3715138214493
initialActions108114
loadScripts819654102781865968
setupStore1363961431
numNetworkReqs1157517561
BrowserifyPower User HomeuiStartup20511762284025522532528
load1016881180614010481326
domContentLoaded1004875177513910401320
domInteractive3117124232999
firstPaint4858713723689381082
backgroundConnect264199820131234633
firstReactRender52397475767
getState18914029832208268
initialActions103112
loadScripts79567815551368151121
setupStore1674071637
numNetworkReqs81652653374158
WebpackStandard HomeuiStartup812694112377844973
load63756588473676793
domContentLoaded63256187972672787
domInteractive2715121242292
firstPaint24190818185193739
backgroundConnect1062751223
firstReactRender271910093036
getState261358103444
initialActions102111
loadScripts62955987171670779
setupStore1052831114
numNetworkReqs1157017561
WebpackPower User HomeuiStartup16951307229225019272154
load706617122299718920
domContentLoaded698609121199707907
domInteractive35181492534105
firstPaint270981222190256701
backgroundConnect12810686212106577
firstReactRender644994107180
getState18714777262191221
initialActions107112
loadScripts695607120297704897
setupStore181067101646
numNetworkReqs80642253174153
FirefoxBrowserifyStandard HomeuiStartup13231068186815814181656
load1094923153311011591287
domContentLoaded1093923153311011591286
domInteractive61301693385134
firstPaint------
backgroundConnect50211523259131
firstReactRender23187172436
getState12692111126
initialActions103122
loadScripts106390515129911171213
setupStore145142181140
numNetworkReqs1256417662
BrowserifyPower User HomeuiStartup29871947488677536494494
load1380980270245313992525
domContentLoaded1380980270145313992524
domInteractive144311054179127399
firstPaint------
backgroundConnect207251566270256860
firstReactRender65372523166122
getState306861105273409906
initialActions217123
loadScripts1307964263339813372413
setupStore1347899202108626
numNetworkReqs77581362271125
WebpackStandard HomeuiStartup14731277193612915531711
load12281066144310013031411
domContentLoaded12281066144310013031411
domInteractive55281283083109
firstPaint------
backgroundConnect48151812859106
firstReactRender27187073037
getState147120151347
initialActions102122
loadScripts1198105114089212751366
setupStore13695131337
numNetworkReqs1256717764
WebpackPower User HomeuiStartup337022876933103242875422
load16941135443360622552735
domContentLoaded16931129443360622552735
domInteractive136292742304102258
firstPaint------
backgroundConnect2322811923242031138
firstReactRender66401912868143
getState324841202276484925
initialActions2035426
loadScripts15551118440851916212533
setupStore10861140158107367
numNetworkReqs78561402278125
📊 Page Load Benchmark Results

Current Commit: 506f535 | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±61ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 720ms (±59ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 61ms 999ms 1.31s 1.24s 1.31s
domContentLoaded 720ms 59ms 692ms 983ms 917ms 983ms
firstPaint 75ms 11ms 56ms 164ms 92ms 164ms
firstContentfulPaint 75ms 11ms 56ms 164ms 92ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 25.82 KiB (0.5%)
  • ui: 3.15 KiB (0.04%)
  • common: -33.15 KiB (-0.37%)

@Qbandev Qbandev added this pull request to the merge queue Dec 4, 2025
Merged via the queue into main with commit 4f6037d Dec 4, 2025
181 of 182 checks passed
@Qbandev Qbandev deleted the feat/require-pr-numbers-changelog branch December 4, 2025 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
@metamaskbot metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.13.0 Issue or pull request that will be included in release 13.13.0 size-XS team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants