Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [8fa30b6]
UI Startup Metrics (1227 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [af62975]
UI Startup Metrics (1342 ± 145 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [10e38cf]
UI Startup Metrics (1297 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Battambang
previously approved these changes
Dec 3, 2025
Collaborator
Builds ready [de1029a]
UI Startup Metrics (1311 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [784c258]
UI Startup Metrics (1276 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [3d36559]
UI Startup Metrics (1288 ± 120 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [be63189]
UI Startup Metrics (1282 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [6139ee6]
UI Startup Metrics (1286 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| const expectedUrl = `https://${match[1]}.infura.io/v3/${escapeRegExp( | ||
| process.env.INFURA_PROJECT_ID, | ||
| )}`; | ||
| return rpcEndpoint.url.startsWith(expectedUrl); |
There was a problem hiding this comment.
Incorrect use of escapeRegExp for string comparison
Low Severity
The escapeRegExp function is incorrectly applied to INFURA_PROJECT_ID when building a URL for startsWith() comparison. escapeRegExp escapes regex special characters (like . becoming \\.), but startsWith is a plain string comparison, not a regex match. If the project ID contains special characters, the escaped string won't match the actual URL, causing isInfuraEndpoint to return false when it should return true, and the failover URL won't be added.
Contributor
Builds ready [0cc2f6d]
UI Startup Metrics (1288 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
salimtb
approved these changes
Jan 19, 2026
OGPoyraz
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds QuickNode fallback RPC for Monad
Changelog
CHANGELOG entry: added QuickNode fallback RPC for Monad.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
BEFORE MIGRATION
After
AFTER MIGRATION
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds failover support for Monad RPC via QuickNode and migrates existing state to include it.
188updates MonadrpcEndpointsto addfailoverUrlswithQUICKNODE_MONAD_URLfor Infura endpoints lacking failover; includes comprehensive testsshared/constants/network.tsto map'monad-mainnet'toQUICKNODE_MONAD_URLand sets failover for the featured Monad RPCQUICKNODE_MONAD_URLthrough build config and CI (bundle.sh,builds.yml,development/build/config.js, workflows)app/scripts/migrations/index.jsand bumps snapshotmeta.versionto188Written by Cursor Bugbot for commit 0cc2f6d. This will update automatically on new commits. Configure here.