chore: add Keycard Shell to the list of supported QR hardware wallets by bitgamma · Pull Request #36911 · MetaMask/metamask-extension

bitgamma · 2025-10-16T03:04:10Z

Description

This PR adds Keycard Shell to the list of supported QR hardware wallets. We have performed extensive tests between Keycard Shell and MetaMask and can confirm full compatibility.

Changelog

CHANGELOG entry: Added Keycard Shell to the list of QR-based hardware wallets

Related issues

Fixes: N/A

Manual testing steps

Add hardware wallet account
Select QR-based
See Keycard Shell in the list of wallets

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: this is primarily additive UI/content/config changes (new device name, links, and i18n strings) with no changes to signing, key management, or authentication logic.

Overview
Adds Keycard Shell to the QR hardware wallet selection flow, including new Buy Now and Tutorial outbound links and associated marketing event tracking.

Updates i18n (keycardShell in en/en_GB) and extends hardware wallet constants/enums to include the new device and affiliate URLs. Also adds Keycard Shell to the bug report issue template’s hardware wallet list.

^{Written by Cursor Bugbot for commit 54fced0. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-16T03:04:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

bitgamma · 2025-10-16T03:05:26Z

I have read the CLA Document and I hereby sign the CLA

ui/pages/create-account/connect-hardware/select-hardware.js

cursor

Bug: Missing Keycard Shell in QrHardwareDeviceNames enum

The QrHardwareDeviceNames enum is missing a Keycard Shell entry, while the new code in select-hardware.js references it. All other QR wallet implementations use an entry from this enum for tracking, but Keycard Shell doesn't have a corresponding entry, creating an inconsistency in how device names are managed across QR hardware wallets.

shared/constants/hardware-wallets.ts#L59-L67

metamask-extension/shared/constants/hardware-wallets.ts

Lines 59 to 67 in 6b7ecb0

    
           export enum QrHardwareDeviceNames { 
        
             Keystone = 'Keystone', 
        
             AirGap = 'AirGap Vault', 
        
             CoolWallet = 'CoolWallet', 
        
             DCent = 'DCent', 
        
             Ngrave = 'Ngrave', 
        
             ImToken = 'imToken', 
        
           }

ui/pages/create-account/connect-hardware/select-hardware.js

hesterbruikman · 2026-01-20T13:56:45Z

@Akaryatrh @owencraston can I request a re-review on this PR please? Just received my Keycard Shell and very eager to use it with Metamask! 🙏

shared/constants/hardware-wallets.ts

Akaryatrh

@bitgamma can you remove changes done to locale files but the en and en_GB ones? (the others will be handled on our side by an external service)

Thanks in advance 🙂

…en_GB

bitgamma · 2026-01-21T09:55:17Z

@bitgamma can you remove changes done to locale files but the en and en_GB ones? (the others will be handled on our side by an external service)

Thanks in advance 🙂

@Akaryatrh done!

Akaryatrh

LGTM 👍

bitgamma · 2026-02-04T08:52:45Z

anything else to be done to get this merged?

HowardBraham · 2026-02-04T16:35:04Z

Oops, there is an issue here blocking PRs from external contributors, I'll work on it.

metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 16, 2025

metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 16, 2025

bitgamma marked this pull request as ready for review October 16, 2025 03:23

This comment was marked as outdated.

Sign in to view

bitgamma mentioned this pull request Oct 27, 2025

Add tighter integration with 3rd party wallets keycard-tech/keycard-shell#182

Closed

Akaryatrh previously approved these changes Nov 21, 2025

View reviewed changes

bitgamma added 3 commits November 21, 2025 11:55

add Keycard Shell to the list of supported QR wallets

081cf0f

add Keycard Shell string in localizations

868878c

correct tracking event

4f661a8

bitgamma dismissed Akaryatrh’s stale review via 4f661a8 November 21, 2025 10:56

bitgamma force-pushed the add-keycard-shell branch from de3419a to 4f661a8 Compare November 21, 2025 10:56

update tracking event names

3fe481b

cursor bot reviewed Nov 21, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/select-hardware.js Show resolved Hide resolved

bitgamma added 2 commits November 21, 2025 17:02

use trackMarketingEvent

0ee4d91

typo

6b7ecb0

cursor bot reviewed Nov 21, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/select-hardware.js Show resolved Hide resolved

add keycar shell to QrHardwareDeviceNames

2a80dad

owencraston reviewed Jan 20, 2026

View reviewed changes

shared/constants/hardware-wallets.ts Outdated Show resolved Hide resolved

bitgamma and others added 2 commits January 21, 2026 07:24

Merge branch 'main' into add-keycard-shell

db646ce

update Keycard Shell documentation link

ab96ee1

Akaryatrh requested changes Jan 21, 2026

View reviewed changes

bitgamma temporarily deployed to pr-comment January 21, 2026 09:47 — with GitHub Actions Inactive

Revert "add Keycard Shell string in localizations" except for en and …

0061b17

…en_GB

Akaryatrh approved these changes Jan 21, 2026

View reviewed changes

bitgamma temporarily deployed to pr-comment January 21, 2026 11:18 — with GitHub Actions Inactive

owencraston approved these changes Jan 21, 2026

View reviewed changes

Merge branch 'main' into add-keycard-shell

54fced0

HowardBraham temporarily deployed to pr-comment February 4, 2026 17:15 — with GitHub Actions Inactive

HowardBraham added this pull request to the merge queue Feb 4, 2026

Merged via the queue into MetaMask:main with commit 9fc979f Feb 4, 2026
172 checks passed

github-actions bot locked and limited conversation to collaborators Feb 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add Keycard Shell to the list of supported QR hardware wallets#36911

chore: add Keycard Shell to the list of supported QR hardware wallets#36911
HowardBraham merged 11 commits intoMetaMask:mainfrom
bitgamma:add-keycard-shell

bitgamma commented Oct 16, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

bitgamma commented Oct 16, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

hesterbruikman commented Jan 20, 2026

Uh oh!

Uh oh!

Akaryatrh left a comment

Uh oh!

bitgamma commented Jan 21, 2026

Uh oh!

Akaryatrh left a comment

Uh oh!

bitgamma commented Feb 4, 2026

Uh oh!

HowardBraham commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


	export enum QrHardwareDeviceNames {
	Keystone = 'Keystone',
	AirGap = 'AirGap Vault',
	CoolWallet = 'CoolWallet',
	DCent = 'DCent',
	Ngrave = 'Ngrave',
	ImToken = 'imToken',
	}

Conversation

bitgamma commented Oct 16, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bitgamma commented Oct 16, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Missing Keycard Shell in QrHardwareDeviceNames enum

Uh oh!

Uh oh!

hesterbruikman commented Jan 20, 2026

Uh oh!

Uh oh!

Akaryatrh left a comment

Choose a reason for hiding this comment

Uh oh!

bitgamma commented Jan 21, 2026

Uh oh!

Akaryatrh left a comment

Choose a reason for hiding this comment

Uh oh!

bitgamma commented Feb 4, 2026

Uh oh!

HowardBraham commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bitgamma commented Oct 16, 2025 •

edited by cursor bot

Loading

github-actions bot commented Oct 16, 2025 •

edited

Loading