fix: notify the client when native balance goes to zero by xavier-brochard · Pull Request #35739 · MetaMask/metamask-extension

xavier-brochard · 2025-09-08T13:30:54Z

Description

This PR bumps the Solana snap to its latest version.

Changelog

CHANGELOG entry: Notify client when native SOL balance reaches zero (#519)

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-09-08T13:31:05Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-09-08T13:33:52Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/solana-wallet-snap@2.3.7 ⏵ 2.3.8	⁺¹		⁺¹	⁺¹

View full report

metamaskbot · 2025-09-08T13:57:26Z

📊 Page Load Benchmark Results

Current Commit: 144f004 | Date: 9/8/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.30s (±66ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
domContentLoaded-> current mean value: 973ms (±64ms) 🟢 | historical mean value: 986ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±18ms) 🟢 | historical mean value: 93ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.30s	66ms	1.26s	1.74s	1.36s	1.74s
domContentLoaded	973ms	64ms	940ms	1.42s	1.02s	1.42s
firstPaint	88ms	18ms	72ms	176ms	140ms	176ms
firstContentfulPaint	88ms	18ms	72ms	176ms	140ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-08T13:57:30Z

Builds ready [144f004]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1209	1109	1373	54	1244	1304
			load	1047	929	1205	53	1083	1124
			domContentLoaded	1038	921	1174	53	1074	1118
			domInteractive	17	14	41	5	17	32
			firstPaint	596	90	1198	424	1060	1125
			backgroundConnect	244	230	286	9	247	257
			firstReactRender	25	17	123	11	25	37
			getState	14	4	82	10	15	33
			initialActions	5	0	21	4	6	12
			loadScripts	803	687	926	51	838	885
			setupStore	9	6	20	3	10	17
	Webpack	Home	uiStartup	2006	1518	2514	243	2141	2438
			load	1621	1214	1956	185	1739	1877
			domContentLoaded	1611	1200	1932	184	1728	1864
			domInteractive	17	12	92	14	14	58
			firstPaint	170	64	434	64	198	311
			backgroundConnect	35	17	351	44	30	59
			firstReactRender	85	36	346	66	82	291
			getState	35	5	292	76	15	285
			initialActions	5	2	19	4	6	14
			loadScripts	1607	1197	1920	183	1726	1853
			setupStore	12	6	27	4	13	18
Firefox	Browserify	Home	uiStartup	1410	1201	1791	105	1467	1619
			load	1228	1054	1444	81	1290	1380
			domContentLoaded	1228	1054	1444	81	1290	1380
			domInteractive	101	33	290	48	106	219
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	19	109	17	36	81
			firstReactRender	28	23	66	6	29	37
			getState	6	2	43	6	6	9
			initialActions	5	1	198	20	3	7
			loadScripts	1201	1037	1425	82	1268	1347
			setupStore	9	5	81	11	7	24
	Webpack	Home	uiStartup	1546	1352	1901	140	1652	1811
			load	1323	1142	1662	123	1432	1545
			domContentLoaded	1322	1141	1662	123	1432	1545
			domInteractive	102	32	313	61	94	268
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	60	7	35	44
			firstReactRender	43	34	61	5	47	52
			getState	6	3	19	2	6	9
			initialActions	5	0	143	15	3	6
			loadScripts	1300	1123	1641	124	1410	1526
			setupStore	11	6	135	17	9	18

Benchmark value 244 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 258 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 285 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1410 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 81 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 7 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 268 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 285ms | Sum of p95 exceeds: 506.8ms
Sum of all benchmark exceeds: 791.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

fix: notify the client when native balance goes to zero

144f004

metamaskbot added the team-networks PRs from the Networks team label Sep 8, 2025

github-actions bot added the size-XS label Sep 8, 2025

ulissesferreira approved these changes Sep 8, 2025

View reviewed changes

xavier-brochard enabled auto-merge September 8, 2025 13:39

aganglada approved these changes Sep 9, 2025

View reviewed changes

xavier-brochard added this pull request to the merge queue Sep 9, 2025

Merged via the queue into main with commit f4bf5e2 Sep 9, 2025
153 of 154 checks passed

xavier-brochard deleted the solana-snap-notify-client-account-zero-balance branch September 9, 2025 08:16

github-actions bot locked and limited conversation to collaborators Sep 9, 2025

metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: notify the client when native balance goes to zero#35739

fix: notify the client when native balance goes to zero#35739
xavier-brochard merged 1 commit intomainfrom
solana-snap-notify-client-account-zero-balance

xavier-brochard commented Sep 8, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

socket-security bot commented Sep 8, 2025

Uh oh!

metamaskbot commented Sep 8, 2025

Uh oh!

metamaskbot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

xavier-brochard commented Sep 8, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

socket-security bot commented Sep 8, 2025

Uh oh!

metamaskbot commented Sep 8, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xavier-brochard commented Sep 8, 2025 •

edited by github-actions bot

Loading