Skip to content

fix: hyperevm false warnings#35609

Merged
Julink-eth merged 30 commits intomainfrom
fix/hyperevm-warnings
Sep 23, 2025
Merged

fix: hyperevm false warnings#35609
Julink-eth merged 30 commits intomainfrom
fix/hyperevm-warnings

Conversation

@Julink-eth
Copy link
Copy Markdown
Contributor

@Julink-eth Julink-eth commented Sep 3, 2025

Description

Currently there are warnings when adding the HyperEVM network on the name/symbol because it uses the chain ID 999 which is the same as WAN CHAIN, this PR is intented to deal with those warnings as an exception specific to HyperEVM to remove those warnings.
It uses a new list NETWORKS_BYPASSING_VALIDATION added in the common package controller-utils.

Changelog

CHANGELOG entry: Removed warnings when adding HyperEVM as a custom network

Related issues

NA

Manual testing steps

  1. Go to https://chainlist.org/
  2. Search for hyperevm
  3. Click on connect wallet
  4. It should ask you to approve adding the network with all the details about the network
  5. No warnings should be shown
  6. Then go to the Networks menu
  7. Click on the 3 dots menu next to HyperEvm and click on Edit
  8. In the popup there should not be any warnings
  9. Check the Tokens View with the network selected being HyperEVM
  10. There should not be a warning next to the HYPE Token

Screenshots/Recordings

NA

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Julink-eth Julink-eth requested a review from a team as a code owner September 3, 2025 10:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 3, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (2 files, +29 -7)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 confirmation/
          • 📁 templates/
            • 📄 add-ethereum-chain.js +16 -5
            • 📄 confirmation.js +13 -2

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: f0981b6 | Date: 9/3/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.31s (±65ms) 🟡 | historical mean value: 1.29s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 992ms (±56ms) 🟢 | historical mean value: 978ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 88ms (±19ms) 🟢 | historical mean value: 92ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.31s 65ms 1.27s 1.90s 1.38s 1.90s
domContentLoaded 992ms 56ms 957ms 1.50s 1.05s 1.50s
firstPaint 88ms 19ms 72ms 176ms 136ms 176ms
firstContentfulPaint 88ms 19ms 72ms 176ms 136ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [90fcd5c]
UI Startup Metrics (1204 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1204110914036112401326
load104694611996110751166
domContentLoaded103994111936110681161
domInteractive17134251729
firstPaint58372117842210461111
backgroundConnect2412292707246253
firstReactRender22164652332
getState1353661626
initialActions40163511
loadScripts80468295562837927
setupStore1052941118
WebpackHomeuiStartup20561542254426022362521
load16601242203720217811947
domContentLoaded16511230202720117721936
domInteractive181293161473
firstPaint1816046574221324
backgroundConnect3113286283062
firstReactRender91373307085307
getState3053167013276
initialActions5228368
loadScripts16471228201620017701926
setupStore156308301420
FirefoxBrowserifyHomeuiStartup13841169181710914431580
load1201102813738212741346
domContentLoaded1201102713738212741346
domInteractive1043425646114230
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect322086123554
firstReactRender27225452840
getState729612626
initialActions512132149
loadScripts1176101313488112501320
setupStore11416720833
WebpackHomeuiStartup15571355198614616401872
load13271148158711614331535
domContentLoaded13261148158711614331535
domInteractive95342864791250
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3121148143540
firstReactRender42345644448
getState63162611
initialActions8117725315
loadScripts13031131156611514111502
setupStore95626917
Benchmark value 242 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2522 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 73 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 276 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 230 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 250 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 270ms | Sum of p95 exceeds: 568.8ms
Sum of all benchmark exceeds: 838.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -200.13 KiB (-4.31%)
  • ui: 26.36 KiB (0.35%)
  • common: 140.57 KiB (1.88%)

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: a64089a | Date: 9/3/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.27s (±39ms) 🟡 | historical mean value: 1.29s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 955ms (±24ms) 🟢 | historical mean value: 978ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 88ms (±31ms) 🟢 | historical mean value: 92ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.27s 39ms 1.24s 1.60s 1.32s 1.60s
domContentLoaded 955ms 24ms 932ms 1.11s 1.00s 1.11s
firstPaint 88ms 31ms 68ms 332ms 132ms 332ms
firstContentfulPaint 88ms 31ms 68ms 332ms 132ms 332ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [dda488b]
UI Startup Metrics (1220 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1220109814076012571310
load106395012215811031151
domContentLoaded105694412105710961145
domInteractive17134251730
firstPaint65181121744110771148
backgroundConnect2412292747244253
firstReactRender23164352434
getState1362861625
initialActions41153611
loadScripts82271796856864913
setupStore943541021
WebpackHomeuiStartup19181498243327521732394
load15411217186320316881838
domContentLoaded15331206185320216791825
domInteractive161172121352
firstPaint1766146666219281
backgroundConnect28166792948
firstReactRender80363306077280
getState3052886813278
initialActions5213268
loadScripts15291204184120016761813
setupStore146284271420
FirefoxBrowserifyHomeuiStartup14371274185711115011662
load1243110314727912891399
domContentLoaded1243110314727912891399
domInteractive1023327440120181
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3620164203884
firstReactRender28235143035
getState9318921728
initialActions7125127312
loadScripts1216107014437912641369
setupStore12418621836
WebpackHomeuiStartup15401361203813716391761
load13161156179311914031526
domContentLoaded13161155179311914031526
domInteractive96313044895238
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3221152143644
firstReactRender42365944449
getState62213613
initialActions411061138
loadScripts12931131177411913851496
setupStore95737917
Benchmark value 242 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1437 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1243 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1662 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 84 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 238 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 312ms | Sum of p95 exceeds: 460.8ms
Sum of all benchmark exceeds: 772.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 307 Bytes (0%)
  • common: 820 Bytes (0.01%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 02f760b | Date: 9/3/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.29s (±103ms) 🟡 | historical mean value: 1.29s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 970ms (±101ms) 🟢 | historical mean value: 976ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 94ms (±45ms) 🟢 | historical mean value: 91ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.29s 103ms 1.25s 1.88s 1.48s 1.88s
domContentLoaded 970ms 101ms 935ms 1.55s 1.16s 1.55s
firstPaint 94ms 45ms 72ms 388ms 228ms 388ms
firstContentfulPaint 94ms 45ms 72ms 388ms 228ms 388ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [fc2e890]
UI Startup Metrics (1212 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1212108214876412491311
load105795012005811011160
domContentLoaded104993411915910951154
domInteractive17136371634
firstPaint66470120242510681146
backgroundConnect2432302667247255
firstReactRender22164142332
getState1353861525
initialActions40284513
loadScripts81470294158858914
setupStore962531014
WebpackHomeuiStartup19161458247628821542436
load15271182190221116841855
domContentLoaded15191169189321116771844
domInteractive161188121341
firstPaint1605937354182274
backgroundConnect3216323313060
firstReactRender78373194377125
getState3252907213272
initialActions5219269
loadScripts15151167188220916731833
setupStore1263241321
FirefoxBrowserifyHomeuiStartup13431166168110614081559
load1173101614938512301307
domContentLoaded1173101614938512291306
domInteractive993239152105223
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect36181822636106
firstReactRender26214852837
getState62728611
initialActions3041436
loadScripts1145100014748211961283
setupStore74355716
WebpackHomeuiStartup15721316208216716721943
load13401116171613414511582
domContentLoaded13391116171613414511581
domInteractive106343266198289
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3220149173641
firstReactRender43365544551
getState7312312611
initialActions4112413310
loadScripts13161098169613214311520
setupStore95264919
Benchmark value 244 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 255 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 272 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 106 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1943 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 280ms | Sum of p95 exceeds: 545.8ms
Sum of all benchmark exceeds: 825.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.99 KiB (0.09%)
  • ui: 294 Bytes (0%)
  • common: 818 Bytes (0.01%)

Battambang
Battambang previously approved these changes Sep 3, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 292330f | Date: 9/3/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.32s (±54ms) 🟡 | historical mean value: 1.30s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 995ms (±51ms) 🟢 | historical mean value: 979ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 92ms (±32ms) 🟢 | historical mean value: 95ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.32s 54ms 1.28s 1.71s 1.37s 1.71s
domContentLoaded 995ms 51ms 959ms 1.36s 1.03s 1.36s
firstPaint 92ms 32ms 72ms 392ms 124ms 392ms
firstContentfulPaint 92ms 32ms 72ms 392ms 124ms 392ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [111183d]
UI Startup Metrics (1234 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1234109014216612761360
load107394812656311111207
domContentLoaded106594212586411031200
domInteractive18136071737
firstPaint62780122343710701129
backgroundConnect2462312979249262
firstReactRender23174052436
getState1468091529
initialActions40173510
loadScripts827712101863866966
setupStore963331115
WebpackHomeuiStartup20731596257524822192510
load16561300200019017911911
domContentLoaded16461284198418817801897
domInteractive1712112141442
firstPaint1626043661190268
backgroundConnect3714345413364
firstReactRender100363337691319
getState3342887215275
initialActions62213711
loadScripts16421281197218717781885
setupStore196280371526
FirefoxBrowserifyHomeuiStartup13691210188912414111682
load1187104515038212351338
domContentLoaded1187104515028212351338
domInteractive1003328351105234
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect311883133366
firstReactRender25214532731
getState8218019613
initialActions5117617310
loadScripts1163102614858212091320
setupStore948310828
WebpackHomeuiStartup15801395202014616441889
load13451176161711914291558
domContentLoaded13451176161611914291557
domInteractive101313555497261
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect32209793745
firstReactRender44365644753
getState8312914613
initialActions4156639
loadScripts13221156159011914061534
setupStore95365919
Benchmark value 1073 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1208 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1200 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 967 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2510 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1682 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 234 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 261 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 281ms | Sum of p95 exceeds: 642.8ms
Sum of all benchmark exceeds: 923.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 294 Bytes (0%)
  • common: 820 Bytes (0.01%)

@vivek-consensys
Copy link
Copy Markdown
Contributor

Chrome:
image

Firefox:
image

@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: f6cd8c9 | Date: 9/5/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.29s (±44ms) 🟡 | historical mean value: 1.32s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 968ms (±39ms) 🟢 | historical mean value: 995ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 97ms (±41ms) 🟢 | historical mean value: 100ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.29s 44ms 1.25s 1.46s 1.40s 1.46s
domContentLoaded 968ms 39ms 933ms 1.13s 1.07s 1.13s
firstPaint 97ms 41ms 72ms 260ms 192ms 260ms
firstContentfulPaint 97ms 41ms 72ms 260ms 192ms 260ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [0dd1514]
UI Startup Metrics (1231 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1231109914096612861349
load106691512146611221178
domContentLoaded105790812046711101171
domInteractive17134341724
firstPaint71884120242910821166
backgroundConnect2452312799248265
firstReactRender2516109132537
getState15593111830
initialActions607011615
loadScripts82066997467877931
setupStore1063241120
WebpackHomeuiStartup20211484251024121952417
load16251203202017817241870
domContentLoaded16161193200717817141860
domInteractive1711132161347
firstPaint1666338456189277
backgroundConnect3518328433265
firstReactRender93363347287320
getState2743036215265
initialActions5219379
loadScripts16091191199717617111848
setupStore157250241427
FirefoxBrowserifyHomeuiStartup14031232188411414621607
load1216107814567712761337
domContentLoaded1216107814567712761337
domInteractive1063324746113223
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect311998133460
firstReactRender26224342838
getState729911612
initialActions7119722433
loadScripts1192106314267612531317
setupStore10517919829
WebpackHomeuiStartup15541333192513616591814
load13291135167011914471544
domContentLoaded13291134167011914461543
domInteractive103322785794261
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect31224463740
firstReactRender43366154654
getState62152612
initialActions4061739
loadScripts13061117165212114291526
setupStore95324919
Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 266 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 33 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 261 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 279ms | Sum of p95 exceeds: 513.8ms
Sum of all benchmark exceeds: 792.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 294 Bytes (0%)
  • common: 826 Bytes (0.01%)

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

OGPoyraz
OGPoyraz previously approved these changes Sep 22, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: f53b842 | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±67ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±14ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 70ms 1.00s 1.32s 1.25s 1.32s
domContentLoaded 728ms 67ms 693ms 996ms 926ms 996ms
firstPaint 76ms 14ms 60ms 200ms 84ms 200ms
firstContentfulPaint 76ms 14ms 60ms 200ms 84ms 200ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f53b842]
UI Startup Metrics (1196 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1196108413976612281312
load102992912216210571144
domContentLoaded102192112126210491135
domInteractive17135051728
firstPaint68670122940510491124
backgroundConnect2152032477217226
firstReactRender25175772839
getState1555081930
initialActions60527716
loadScripts814705100662840930
setupStore1062741119
WebpackHomeuiStartup1177931138011612571340
load987766118510710531138
domContentLoaded982762118210810491135
domInteractive171361111448
firstPaint1546547864178251
backgroundConnect18128991931
firstReactRender36335533743
getState74162713
initialActions62204814
loadScripts979759118010710461133
setupStore96192914
FirefoxBrowserifyHomeuiStartup14481208200213115261666
load1251106514999413301441
domContentLoaded1251106414999413301440
domInteractive1073329351118240
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect36191842336101
firstReactRender30245663142
getState8312416613
initialActions6120021329
loadScripts1223104714488513001358
setupStore12517520941
WebpackHomeuiStartup15651352221316116621861
load13341152165913014271587
domContentLoaded13331152165813014271586
domInteractive104313336299283
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3220103103743
firstReactRender44366754753
getState8316917611
initialActions411361337
loadScripts13101132161813014071566
setupStore95374919
Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 226 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1448 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1252 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1252 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1666 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 240 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 101 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 29 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 41 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 324ms | Sum of p95 exceeds: 489.8ms
Sum of all benchmark exceeds: 813.8ms

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Sep 23, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: a4d1d59 | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±79ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±68ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 79ms 1.01s 1.39s 1.31s 1.39s
domContentLoaded 736ms 68ms 697ms 998ms 946ms 998ms
firstPaint 76ms 13ms 56ms 192ms 84ms 192ms
firstContentfulPaint 76ms 13ms 56ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [a4d1d59]
UI Startup Metrics (1205 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1205108414496512511289
load104193212616210911140
domContentLoaded103592512546210851128
domInteractive18135271737
firstPaint69072122941910571133
backgroundConnect2132032416215223
firstReactRender25194262740
getState1353571628
initialActions60426719
loadScripts828711104261878924
setupStore1064761025
WebpackHomeuiStartup1151917133910812331287
load969755115510210441100
domContentLoaded964751115110210411097
domInteractive16124881440
firstPaint1526134953179246
backgroundConnect16103661529
firstReactRender36325543644
getState73233712
initialActions62154812
loadScripts961749114810210351095
setupStore86132911
FirefoxBrowserifyHomeuiStartup14711274195111715321695
load1274111616799613331414
domContentLoaded1273111616789613331413
domInteractive1123438760126270
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3520133203491
firstReactRender29244853141
getState62646613
initialActions4143539
loadScripts1245109816569413041389
setupStore11510613928
WebpackHomeuiStartup15601348188514316671842
load13351155161612814461562
domContentLoaded13351155161612814461562
domInteractive1063332064101281
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28214363339
firstReactRender44365754753
getState6220369
initialActions411251238
loadScripts13141138158412914261543
setupStore105657924
Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 25 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1471 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1274 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1274 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1245 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1695 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 270 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 398ms | Sum of p95 exceeds: 508.8ms
Sum of all benchmark exceeds: 906.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 584 Bytes (0.01%)
  • common: 457 Bytes (0.01%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 8bfc3c2 | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±74ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 740ms (±85ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 88ms (±128ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 74ms 1.01s 1.39s 1.28s 1.39s
domContentLoaded 740ms 85ms 700ms 1.29s 952ms 1.29s
firstPaint 88ms 128ms 60ms 1.36s 88ms 1.36s
firstContentfulPaint 88ms 128ms 60ms 1.36s 88ms 1.36s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [8bfc3c2]
UI Startup Metrics (1178 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1178106314717312061364
load101592512756610411190
domContentLoaded100892012716610331185
domInteractive17134651728
firstPaint63174126040710051077
backgroundConnect2101972305213219
firstReactRender26184972942
getState1353961526
initialActions50396519
loadScripts804722104564831973
setupStore1052841117
WebpackHomeuiStartup1168918144211912481355
load985755126711210601126
domContentLoaded981751126211310551123
domInteractive16125991443
firstPaint1506640654174245
backgroundConnect16113661430
firstReactRender35325233541
getState64132611
initialActions62204815
loadScripts978749126011210531120
setupStore86202914
FirefoxBrowserifyHomeuiStartup14701274191411915271694
load1274111117019513461435
domContentLoaded1273111117019513451435
domInteractive1103229761109282
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3221105143459
firstReactRender31245573346
getState739710613
initialActions41244313
loadScripts1249109216819213181404
setupStore11518919928
WebpackHomeuiStartup16381435209415217491890
load14011197175813615091637
domContentLoaded14001197175713615081637
domInteractive1103234862106300
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect32225373844
firstReactRender48376555157
getState63495712
initialActions3155637
loadScripts13771173173713814851618
setupStore1068181022
Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1191 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 220 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 973 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1471 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1274 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1274 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1249 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1694 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 282 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1639 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 48 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1377 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 491ms | Sum of p95 exceeds: 555.8ms
Sum of all benchmark exceeds: 1046.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 584 Bytes (0.01%)
  • common: 457 Bytes (0.01%)

@Julink-eth Julink-eth added this pull request to the merge queue Sep 23, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 23, 2025
@Julink-eth Julink-eth added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit 3b4fbdf Sep 23, 2025
149 checks passed
@Julink-eth Julink-eth deleted the fix/hyperevm-warnings branch September 23, 2025 09:35
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 23, 2025
@metamaskbot metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed release-13.5.0 Issue or pull request that will be included in release 13.5.0 size-S team-network-enablement

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants