fix: hyperevm false warnings#35609
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +29 -7)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [90fcd5c]
UI Startup Metrics (1204 ± 61 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2522 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 73 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 276 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 230 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 250 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 270ms | Sum of p95 exceeds: 568.8ms Sum of all benchmark exceeds: 838.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [dda488b]
UI Startup Metrics (1220 ± 60 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1437 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1243 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1662 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 84 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 238 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 312ms | Sum of p95 exceeds: 460.8ms Sum of all benchmark exceeds: 772.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [fc2e890]
UI Startup Metrics (1212 ± 64 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 255 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 272 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 106 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1943 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 280ms | Sum of p95 exceeds: 545.8ms Sum of all benchmark exceeds: 825.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [111183d]
UI Startup Metrics (1234 ± 66 ms)
Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1208 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1200 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 967 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2510 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1682 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 234 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 261 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 281ms | Sum of p95 exceeds: 642.8ms Sum of all benchmark exceeds: 923.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0dd1514]
UI Startup Metrics (1231 ± 66 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 266 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 33 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 261 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 279ms | Sum of p95 exceeds: 513.8ms Sum of all benchmark exceeds: 792.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f53b842]
UI Startup Metrics (1196 ± 66 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 226 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1448 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1252 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1252 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1666 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 240 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 101 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 29 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 41 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 324ms | Sum of p95 exceeds: 489.8ms Sum of all benchmark exceeds: 813.8ms |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [a4d1d59]
UI Startup Metrics (1205 ± 65 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 25 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1471 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1274 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1274 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1245 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1695 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 270 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 398ms | Sum of p95 exceeds: 508.8ms Sum of all benchmark exceeds: 906.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [8bfc3c2]
UI Startup Metrics (1178 ± 73 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1191 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 220 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 973 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1471 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1274 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1274 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1249 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1694 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 282 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1639 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 48 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1377 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 491ms | Sum of p95 exceeds: 555.8ms Sum of all benchmark exceeds: 1046.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|


Description
Currently there are warnings when adding the HyperEVM network on the name/symbol because it uses the chain ID 999 which is the same as WAN CHAIN, this PR is intented to deal with those warnings as an exception specific to HyperEVM to remove those warnings.
It uses a new list
NETWORKS_BYPASSING_VALIDATIONadded in the common packagecontroller-utils.Changelog
CHANGELOG entry: Removed warnings when adding HyperEVM as a custom network
Related issues
NA
Manual testing steps
Screenshots/Recordings
NA
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist