chore: bump `@metamask/profile-sync-controller` to `^20.0.0` by mathieuartu · Pull Request #34078 · MetaMask/metamask-extension

mathieuartu · 2025-07-04T09:25:39Z

Description

This PR bumps:

@metamask/profile-sync-controller to ^20.0.0

Updates from the package changelog since ^18.0.0:

## [20.0.0]

### Added

- Add new `AuthenticationController:getUserProfileMetaMetrics` method ([#6068](https://github.com/MetaMask/core/pull/6068))
  - This method fetches data using the Authentication API, returning all MetaMetrics sessions related to the currently authenticated user, in the form of `typeof UserProfileMetaMetrics`

### Changed

- **BREAKING:** Bump peer dependency `@metamask/snaps-controllers` from `^12.0.0` to `^14.0.0` ([#6035](https://github.com/MetaMask/core/pull/6035))
- Bump `@metamask/snaps-sdk` from `^7.1.0` to `^9.0.0` ([#6035](https://github.com/MetaMask/core/pull/6035))
- Bump `@metamask/snaps-utils` from `^9.4.0` to `^11.0.0` ([#6035](https://github.com/MetaMask/core/pull/6035))

## [19.0.0]

### Changed

- **BREAKING:** Bump peer dependency `@metamask/accounts-controller` to `^31.0.0` ([#5999](https://github.com/MetaMask/core/pull/5999))
- **BREAKING:** Bump peer dependency `@metamask/network-controller` to `^24.0.0` ([#5999](https://github.com/MetaMask/core/pull/5999))

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-04T09:25:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-07-04T09:27:01Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/profile-sync-controller@18.0.0 ⏵ 20.0.0			⁺¹	⁺¹

View full report

mathieuartu · 2025-07-04T09:52:28Z

@metamaskbot update-policies

metamaskbot · 2025-07-04T10:04:27Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

lavamoat/browserify/beta/policy.json

metamaskbot · 2025-07-04T10:29:55Z

Builds ready [4ca89c5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1103	1444	63	1244	1332
			load	1036	922	1231	55	1073	1117
			domContentLoaded	1029	913	1225	56	1064	1111
			domInteractive	18	13	57	8	16	39
			firstPaint	613	80	1156	410	1044	1113
			backgroundConnect	9	4	71	8	9	12
			firstReactRender	25	16	124	12	27	40
			getState	15	6	88	10	19	30
			initialActions	4	0	29	6	6	16
			loadScripts	786	658	957	54	820	866
			setupStore	9	4	54	6	8	20
	Webpack	Home	uiStartup	2256	1725	2764	242	2405	2745
			load	1692	1290	2064	190	1786	2033
			domContentLoaded	1685	1285	2053	188	1780	2023
			domInteractive	20	13	112	17	15	59
			firstPaint	176	64	1926	188	187	305
			backgroundConnect	24	11	51	9	29	42
			firstReactRender	261	90	416	110	373	398
			getState	16	5	45	8	20	33
			initialActions	15	3	290	39	10	39
			loadScripts	1682	1283	2039	186	1778	2010
			setupStore	17	7	37	7	20	32
Firefox	Browserify	Home	uiStartup	1403	1196	1858	129	1436	1699
			load	1213	1061	1424	77	1261	1349
			domContentLoaded	1213	1061	1424	77	1261	1349
			domInteractive	113	36	360	55	127	253
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	13	182	27	26	93
			firstReactRender	26	21	60	5	26	34
			getState	15	5	203	27	9	62
			initialActions	6	0	102	14	3	28
			loadScripts	1190	1048	1406	75	1235	1323
			setupStore	16	4	256	35	9	89
	Webpack	Home	uiStartup	1650	1368	2295	199	1784	2017
			load	1424	1165	1929	157	1563	1675
			domContentLoaded	1424	1165	1928	157	1562	1675
			domInteractive	105	32	417	60	111	255
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	17	261	25	27	43
			firstReactRender	41	34	56	4	43	46
			getState	14	6	178	19	13	32
			initialActions	12	0	233	38	5	62
			loadScripts	1402	1149	1714	151	1546	1649
			setupStore	9	5	31	4	8	20

Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2256 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 15 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2746 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2034 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2023 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 39 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2010 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1699 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 253 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 93 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 62 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 28 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 89 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1650 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1425 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1424 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 13 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1402 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2017 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 255 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 62 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1649 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 316ms | Sum of p95 exceeds: 970.8ms
Sum of all benchmark exceeds: 1286.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 916 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 5.23 KiB (0.06%)

metamaskbot · 2025-07-04T12:23:59Z

Builds ready [6c59f50]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1217	1125	1367	54	1255	1316
			load	1044	955	1214	52	1082	1123
			domContentLoaded	1037	943	1204	52	1077	1115
			domInteractive	18	13	47	8	17	42
			firstPaint	647	98	1214	429	1068	1120
			backgroundConnect	9	4	68	7	8	23
			firstReactRender	24	17	56	7	26	42
			getState	15	6	55	9	22	31
			initialActions	4	0	20	5	7	17
			loadScripts	792	703	949	51	827	874
			setupStore	9	5	33	5	8	20
	Webpack	Home	uiStartup	2226	1637	2834	245	2359	2645
			load	1664	1232	2096	182	1749	1983
			domContentLoaded	1657	1226	2082	180	1744	1964
			domInteractive	19	12	127	18	14	65
			firstPaint	176	63	1711	170	189	322
			backgroundConnect	27	11	269	26	27	50
			firstReactRender	279	91	410	117	380	400
			getState	18	5	311	30	19	33
			initialActions	11	2	277	28	9	25
			loadScripts	1653	1224	2070	178	1740	1952
			setupStore	19	7	314	30	20	33
Firefox	Browserify	Home	uiStartup	1426	1255	1903	121	1488	1665
			load	1241	1103	1533	82	1297	1378
			domContentLoaded	1241	1103	1533	82	1297	1378
			domInteractive	118	37	441	59	125	260
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	13	170	24	27	81
			firstReactRender	26	22	54	5	26	35
			getState	15	4	213	26	9	50
			initialActions	5	0	124	14	3	20
			loadScripts	1218	1085	1516	81	1274	1351
			setupStore	12	4	209	25	8	38
	Webpack	Home	uiStartup	1712	1357	2368	213	1815	2200
			load	1477	1181	1944	175	1595	1809
			domContentLoaded	1476	1181	1943	175	1595	1809
			domInteractive	113	34	389	77	104	340
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	73	8	27	42
			firstReactRender	42	35	54	4	44	49
			getState	16	5	234	26	12	39
			initialActions	8	0	215	29	6	14
			loadScripts	1457	1166	1884	173	1574	1785
			setupStore	13	5	291	30	9	28

Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2227 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 279 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2645 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 25 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1427 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1665 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 260 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 81 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 50 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1712 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1477 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1477 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1457 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2200 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1809 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1809 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 340 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1785 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 557ms | Sum of p95 exceeds: 1329.8ms
Sum of all benchmark exceeds: 1886.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 916 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 5.23 KiB (0.06%)

seaona · 2025-07-07T15:27:50Z

hi there 👋 The failed test are legit. It seems that this PR broke the dapp connectivity in FF. You can reproduce this by building MM for FF ENABLE_MV3=false yarn start and then trying to connect to any dapp -- it fails with all dapps, not just our test-dapp.

Hopefully, you can debug from this point 🙏

dapp-connectivity-broken-ff.mp4

metamaskbot · 2025-07-08T08:53:03Z

Builds ready [fffedc5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1254 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1254	1120	1463	64	1303	1355
			load	1079	932	1242	63	1133	1177
			domContentLoaded	1072	920	1231	63	1125	1170
			domInteractive	18	14	51	7	17	37
			firstPaint	787	72	1217	425	1121	1176
			backgroundConnect	8	4	26	3	9	11
			firstReactRender	23	16	66	6	24	33
			getState	16	6	67	9	23	29
			initialActions	4	0	64	8	3	15
			loadScripts	823	684	970	62	876	919
			setupStore	8	5	24	3	8	16
	Webpack	Home	uiStartup	2290	1686	2798	213	2394	2717
			load	1731	1259	2104	187	1853	2052
			domContentLoaded	1724	1255	2098	186	1849	2045
			domInteractive	19	13	82	15	15	65
			firstPaint	167	69	377	75	193	345
			backgroundConnect	24	10	54	9	31	41
			firstReactRender	265	92	421	117	378	409
			getState	18	5	283	28	18	34
			initialActions	11	2	158	17	11	36
			loadScripts	1721	1253	2095	184	1847	2043
			setupStore	21	7	326	32	22	35
Firefox	Browserify	Home	uiStartup	1380	1183	2020	157	1444	1697
			load	1201	1044	1673	109	1256	1397
			domContentLoaded	1201	1044	1673	109	1256	1397
			domInteractive	119	35	565	80	117	316
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	12	237	24	22	48
			firstReactRender	25	21	51	4	25	30
			getState	12	4	241	25	9	28
			initialActions	8	0	203	26	3	44
			loadScripts	1181	1031	1536	100	1239	1375
			setupStore	13	4	172	23	8	70
	Webpack	Home	uiStartup	1688	1419	2664	214	1773	2085
			load	1424	1187	1866	153	1529	1711
			domContentLoaded	1424	1187	1866	154	1528	1710
			domInteractive	109	58	547	79	96	295
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	119	13	25	49
			firstReactRender	59	47	82	6	62	69
			getState	19	6	400	43	15	36
			initialActions	7	0	213	23	4	20
			loadScripts	1404	1171	1828	153	1509	1690
			setupStore	13	5	227	23	10	32

Benchmark value 1254 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2290 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1732 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1725 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 265 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1721 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2717 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2053 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2046 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 65 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 345 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 409 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 36 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2044 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1697 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 316 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 44 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 70 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1689 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1424 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1424 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 20 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1404 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2085 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1711 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1710 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 295 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 20 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1690 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 512ms | Sum of p95 exceeds: 1243.8ms
Sum of all benchmark exceeds: 1755.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 916 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 961 Bytes (0.01%)

cursor

Bug: Profile Sync Update Breaks Firefox Dapp Connectivity

Updating @metamask/profile-sync-controller to ^20.0.0 introduced a peer dependency mismatch. The new version requires @metamask/accounts-controller ^31.0.0, but the project still uses ^30.0.0. This incompatibility causes runtime issues, specifically broken dapp connectivity in Firefox.

package.json#L322-L323

metamask-extension/package.json

Lines 322 to 323 in fffedc5

    
           "@metamask/preinstalled-example-snap": "^0.6.0", 
        
           "@metamask/profile-sync-controller": "^20.0.0",

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

mathieuartu · 2025-07-08T08:57:10Z

Bug: Profile Sync Update Breaks Firefox Dapp Connectivity

Updating @metamask/profile-sync-controller to ^20.0.0 introduced a peer dependency mismatch. The new version requires @metamask/accounts-controller ^31.0.0, but the project still uses ^30.0.0. This incompatibility causes runtime issues, specifically broken dapp connectivity in Firefox.

package.json#L322-L323
Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

Bumping @metamask/notification-services-controller to ^13.0.0 introduced the Firefox Dapp connectivity issues.
I fixed this by not bumping this controller in this PR.

chore: bump notification & identity controllers

c683a42

mathieuartu self-assigned this Jul 4, 2025

mathieuartu added the team-identity-deprecated DEPRECATED: team no longer exists label Jul 4, 2025

Update LavaMoat policies

4ca89c5

mathieuartu commented Jul 4, 2025

View reviewed changes

lavamoat/browserify/beta/policy.json Outdated Show resolved Hide resolved

fabiobozzo previously approved these changes Jul 4, 2025

View reviewed changes

mathieuartu added 3 commits July 8, 2025 09:32

Merge branch 'main' into chore/bump-identity-notification-controllers

4629cc5

Merge branch 'main' into chore/bump-identity-notification-controllers

dc8afb7

fix: only bump profile-sync-controller

ec38d00

mathieuartu dismissed fabiobozzo’s stale review via ec38d00 July 8, 2025 08:23

mathieuartu force-pushed the chore/bump-identity-notification-controllers branch from 6c59f50 to ec38d00 Compare July 8, 2025 08:23

fix: revert unwanted changes

fffedc5

mathieuartu changed the title ~~chore: bump notification & identity controllers~~ chore: bump @metamask/profile-sync-controller to ^20.0.0 Jul 8, 2025

mathieuartu marked this pull request as ready for review July 8, 2025 08:53

cursor bot reviewed Jul 8, 2025

View reviewed changes

cmd-ob approved these changes Jul 8, 2025

View reviewed changes

mathieuartu enabled auto-merge July 8, 2025 08:59

fabiobozzo approved these changes Jul 8, 2025

View reviewed changes

mathieuartu added this pull request to the merge queue Jul 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2025

mathieuartu added this pull request to the merge queue Jul 8, 2025

Merged via the queue into main with commit ab29298 Jul 8, 2025
156 checks passed

mathieuartu deleted the chore/bump-identity-notification-controllers branch July 8, 2025 10:29

github-actions bot locked and limited conversation to collaborators Jul 8, 2025

metamaskbot added the release-13.0.0 Issue or pull request that will be included in release 13.0.0 (also called 12.24.0) label Jul 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump `@metamask/profile-sync-controller` to `^20.0.0`#34078

chore: bump `@metamask/profile-sync-controller` to `^20.0.0`#34078
mathieuartu merged 6 commits intomainfrom
chore/bump-identity-notification-controllers

mathieuartu commented Jul 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

socket-security bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

mathieuartu commented Jul 4, 2025

Uh oh!

metamaskbot commented Jul 4, 2025

Uh oh!

Uh oh!

metamaskbot commented Jul 4, 2025

Uh oh!

metamaskbot commented Jul 4, 2025

Uh oh!

seaona commented Jul 7, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jul 8, 2025

Uh oh!

cursor bot left a comment

Uh oh!

mathieuartu commented Jul 8, 2025

Bug: Profile Sync Update Breaks Firefox Dapp Connectivity

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	"@metamask/preinstalled-example-snap": "^0.6.0",
	"@metamask/profile-sync-controller": "^20.0.0",

Conversation

mathieuartu commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

socket-security bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathieuartu commented Jul 4, 2025

Uh oh!

metamaskbot commented Jul 4, 2025

Uh oh!

Uh oh!

metamaskbot commented Jul 4, 2025

Uh oh!

metamaskbot commented Jul 4, 2025

Uh oh!

seaona commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Jul 8, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Profile Sync Update Breaks Firefox Dapp Connectivity

Uh oh!

mathieuartu commented Jul 8, 2025

Bug: Profile Sync Update Breaks Firefox Dapp Connectivity

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mathieuartu commented Jul 4, 2025 •

edited

Loading

socket-security bot commented Jul 4, 2025 •

edited

Loading

seaona commented Jul 7, 2025 •

edited

Loading