feat: add multi-SRP EVM Account Syncing by mathieuartu · Pull Request #32951 · MetaMask/metamask-extension

mathieuartu · 2025-05-15T06:49:43Z

Description

This PR implements the core changes seen in this PR.
In short, this changes the implementation of AuthenticationController so that it can manage parallel sessions based on entropySource.
In turn, this addition permits UserStorageController to scope user storage requests to a specific entropySource.

Using all those changes, account syncing now iterates over each entropySource present in the client and syncs accounts in consequence. This will ensure that each SRP has its own data, that can be synced independently of the context (e.g Device 1 (SRP 1 + SRP 2), Device 2 (SRP 2 only) will bi-directionally sync).

Related issues

Fixes:

Manual testing steps

Import or create an SRP, complete onboarding, add and rename an EVM account
Import a second SRP, add and rename an EVM account
Uninstall and reinstall extension, onboard with one or both previous SRPs
Verify that EVM accounts are restored

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-15T06:49:57Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-05-15T06:50:50Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/profile-sync-controller@16.0.0 ⏵ 17.1.0	⁺³		⁺¹	⁺¹

View full report

metamaskbot · 2025-05-15T06:51:54Z

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs (3 files, +0 -3)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +0 -1
  - 📁 flask/
    - 📄 policy.json +0 -1
  - 📁 main/
    - 📄 policy.json +0 -1

🪪 @MetaMask/identity (14 files, +340 -14)

📁 app/
- 📁 scripts/
  - 📁 controller-init/
    - 📁 messengers/
      - 📁 identity/
        
        📄 user-storage-controller-messenger.ts +3 -0
📁 test/
- 📁 e2e/
  - 📁 helpers/
    - 📁 identity/
      - 📁 user-storage/
        
        📄 generateEncryptedData.ts +6 -1
        
        📄 userStorageMockttpController.test.ts +66 -0
        
        📄 userStorageMockttpController.ts +31 -4
  - 📁 tests/
    - 📁 identity/
      - 📁 account-syncing/
        
        📄 helpers.ts +1 -1
        
        📄 new-user-sync.spec.ts +6 -2
        
        📄 sync-after-adding-account.spec.ts +1 -1
        
        📄 sync-with-multi-srp.spec.ts +170 -0
        
        📄 constants.ts +5 -1
        
        📄 mocks.ts +47 -4
📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 identity/
      - 📁 backup-and-sync-features-toggles/
        
        📄 backup-and-sync-features-toggles.test.tsx +1 -0
      - 📁 backup-and-sync-toggle/
        
        📄 backup-and-sync-toggle.test.tsx +1 -0
    - 📁 modals/
      - 📁 identity/
        
        📁 turn-on-backup-and-sync-modal/
        
        📄 turn-on-backup-and-sync-modal.test.tsx +1 -0
- 📁 hooks/
  - 📁 identity/
    - 📁 useAccountSyncing/
      - 📄 useAccountSyncing.test.tsx +1 -0

📜 @MetaMask/policy-reviewers (3 files, +0 -3)

[!TIP]
Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +0 -1
  - 📁 flask/
    - 📄 policy.json +0 -1
  - 📁 main/
    - 📄 policy.json +0 -1

🔗 @MetaMask/supply-chain (3 files, +0 -3)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +0 -1
  - 📁 flask/
    - 📄 policy.json +0 -1
  - 📁 main/
    - 📄 policy.json +0 -1

metamaskbot · 2025-05-15T07:23:53Z

Builds ready [3640442]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1103	1386	68	1255	1348
			load	1049	917	1211	67	1089	1193
			domContentLoaded	1043	911	1204	67	1083	1184
			domInteractive	16	13	28	3	16	25
			firstPaint	712	138	1190	413	1051	1146
			backgroundConnect	8	4	24	4	8	20
			firstReactRender	21	15	44	6	21	38
			getState	15	5	91	11	19	28
			initialActions	0	0	1	0	0	0
			loadScripts	801	674	965	66	837	944
			setupStore	8	5	27	3	8	17
	Webpack	Home	uiStartup	2114	1713	2487	165	2231	2328
			load	1645	1328	2088	133	1730	1829
			domContentLoaded	1638	1324	2083	132	1724	1818
			domInteractive	15	11	53	9	13	41
			firstPaint	160	66	337	56	185	293
			backgroundConnect	27	10	295	29	29	52
			firstReactRender	148	53	352	92	251	338
			getState	15	4	317	35	12	28
			initialActions	3	1	7	1	3	5
			loadScripts	1634	1323	2081	133	1723	1815
			setupStore	17	6	301	29	18	26
Firefox	Browserify	Home	uiStartup	1340	1179	2013	131	1378	1582
			load	1191	1045	1675	110	1236	1408
			domContentLoaded	1191	1045	1675	110	1235	1408
			domInteractive	104	36	496	49	110	160
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	103	13	21	34
			firstReactRender	23	19	61	6	22	30
			getState	11	4	214	27	8	18
			initialActions	0	0	1	0	0	1
			loadScripts	1173	1029	1580	106	1217	1391
			setupStore	10	4	216	23	6	25
	Webpack	Home	uiStartup	1509	1341	1951	115	1576	1727
			load	1290	1150	1655	105	1359	1502
			domContentLoaded	1290	1150	1654	105	1359	1502
			domInteractive	78	52	276	30	77	121
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	82	10	24	44
			firstReactRender	35	28	55	5	37	45
			getState	9	4	38	6	9	26
			initialActions	0	0	1	0	1	1
			loadScripts	1270	1133	1638	105	1341	1473
			setupStore	11	5	229	23	8	25

Benchmark value 1194 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 16ms
Sum of all benchmark exceeds: 18ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 708 Bytes (0.01%)
ui: 6.04 KiB (0.08%)
common: 3.14 KiB (0.03%)

metamaskbot · 2025-05-15T09:47:10Z

Builds ready [344b959]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1185 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1185	1078	1418	61	1223	1296
			load	1035	949	1255	58	1085	1123
			domContentLoaded	1028	927	1247	59	1078	1118
			domInteractive	16	13	40	4	16	23
			firstPaint	721	135	1174	401	1055	1122
			backgroundConnect	8	4	37	5	8	20
			firstReactRender	20	16	56	6	21	34
			getState	16	5	79	12	21	40
			initialActions	0	0	1	0	0	0
			loadScripts	790	694	1001	59	843	892
			setupStore	7	4	17	2	8	12
	Webpack	Home	uiStartup	2189	1696	2546	162	2294	2397
			load	1696	1298	2008	118	1776	1837
			domContentLoaded	1689	1293	1980	117	1767	1832
			domInteractive	16	11	67	11	13	52
			firstPaint	157	64	314	56	177	283
			backgroundConnect	29	9	118	18	36	60
			firstReactRender	198	55	358	109	306	348
			getState	14	4	161	16	16	33
			initialActions	3	1	8	1	4	5
			loadScripts	1684	1290	1955	119	1762	1830
			setupStore	17	7	41	7	22	30
Firefox	Browserify	Home	uiStartup	1320	1123	1834	137	1367	1602
			load	1179	1004	1684	125	1225	1429
			domContentLoaded	1179	1004	1684	125	1224	1429
			domInteractive	96	37	414	43	102	161
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	118	13	21	30
			firstReactRender	22	19	32	2	22	27
			getState	7	4	22	2	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1161	990	1570	121	1211	1410
			setupStore	11	4	221	29	6	36
	Webpack	Home	uiStartup	1542	1359	2068	140	1589	1849
			load	1322	1156	1779	117	1377	1557
			domContentLoaded	1321	1156	1779	117	1376	1556
			domInteractive	80	39	140	18	89	119
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	14	222	23	23	43
			firstReactRender	34	29	46	4	37	43
			getState	9	5	87	9	9	23
			initialActions	1	0	2	1	1	2
			loadScripts	1299	1140	1760	114	1351	1536
			setupStore	12	5	222	30	8	18

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 20 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 40 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Sum of mean exceeds: 3ms | Sum of p95 exceeds: 18ms
Sum of all benchmark exceeds: 21ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 708 Bytes (0.01%)
ui: 6.13 KiB (0.09%)
common: 4.16 KiB (0.04%)

mathieuartu · 2025-05-15T10:52:23Z

@metamaskbot update-policies

metamaskbot · 2025-05-15T11:06:47Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-05-15T11:39:17Z

Builds ready [48e60b8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1180 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1180	1088	1376	57	1205	1295
			load	1026	940	1168	51	1054	1129
			domContentLoaded	1020	933	1162	51	1049	1122
			domInteractive	16	13	42	4	16	24
			firstPaint	735	145	1168	396	1038	1110
			backgroundConnect	7	4	26	4	7	14
			firstReactRender	19	14	35	4	21	30
			getState	14	5	48	9	18	33
			initialActions	0	0	1	0	0	1
			loadScripts	782	683	919	49	813	879
			setupStore	8	4	17	2	8	14
	Webpack	Home	uiStartup	2160	1763	2643	174	2296	2372
			load	1672	1357	2045	126	1761	1847
			domContentLoaded	1664	1353	2039	125	1754	1844
			domInteractive	15	11	46	8	13	38
			firstPaint	169	72	393	64	197	314
			backgroundConnect	30	10	175	25	34	77
			firstReactRender	185	54	365	111	302	354
			getState	18	4	321	40	15	30
			initialActions	3	1	6	1	3	5
			loadScripts	1659	1352	2015	126	1751	1842
			setupStore	16	7	40	7	20	32
Firefox	Browserify	Home	uiStartup	1331	1126	1819	124	1393	1585
			load	1185	1004	1635	114	1234	1410
			domContentLoaded	1184	1004	1634	114	1234	1410
			domInteractive	100	37	232	30	111	158
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	65	8	21	30
			firstReactRender	22	19	31	2	22	27
			getState	11	4	184	25	8	29
			initialActions	0	0	1	0	0	1
			loadScripts	1167	990	1613	113	1217	1389
			setupStore	8	4	191	19	6	22
	Webpack	Home	uiStartup	1612	1437	2111	137	1659	1888
			load	1381	1211	1864	133	1444	1642
			domContentLoaded	1380	1211	1864	133	1444	1641
			domInteractive	81	36	147	18	91	113
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	61	7	24	42
			firstReactRender	37	29	54	5	40	49
			getState	9	5	47	6	9	20
			initialActions	0	0	2	1	1	1
			loadScripts	1360	1197	1841	133	1422	1626
			setupStore	9	5	30	3	9	12

Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 5ms
Sum of all benchmark exceeds: 9ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 789 Bytes (0.01%)
ui: 6.16 KiB (0.09%)
common: 4.16 KiB (0.04%)

…amask-extension into test/core-PR-5753-testdrive

metamaskbot · 2025-05-15T14:42:40Z

Builds ready [2d5db7e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1123	1364	54	1262	1324
			load	1068	977	1178	50	1098	1157
			domContentLoaded	1061	958	1169	51	1093	1149
			domInteractive	17	14	27	3	17	26
			firstPaint	722	138	1171	430	1087	1155
			backgroundConnect	8	4	33	5	7	23
			firstReactRender	20	15	43	4	20	28
			getState	14	5	34	8	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	819	728	924	50	851	905
			setupStore	8	5	19	2	8	14
	Webpack	Home	uiStartup	2161	1771	2407	152	2278	2345
			load	1694	1400	1895	117	1773	1878
			domContentLoaded	1687	1396	1885	117	1766	1871
			domInteractive	15	12	54	8	13	39
			firstPaint	162	65	367	61	191	275
			backgroundConnect	27	9	109	14	32	52
			firstReactRender	135	42	353	94	250	306
			getState	12	4	42	8	14	29
			initialActions	3	1	6	1	3	4
			loadScripts	1682	1373	1884	120	1762	1857
			setupStore	22	7	324	39	20	35
Firefox	Browserify	Home	uiStartup	1298	1102	2273	150	1347	1566
			load	1160	988	2095	142	1217	1396
			domContentLoaded	1160	988	2094	142	1217	1396
			domInteractive	107	38	1082	104	104	164
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	18	12	49	5	19	27
			firstReactRender	22	19	52	6	22	28
			getState	10	4	191	20	8	21
			initialActions	0	0	1	0	0	1
			loadScripts	1144	976	2076	142	1202	1379
			setupStore	7	3	34	5	6	13
	Webpack	Home	uiStartup	1573	1371	2183	171	1642	1921
			load	1344	1183	1935	146	1416	1595
			domContentLoaded	1344	1183	1934	146	1416	1595
			domInteractive	81	36	289	29	86	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	83	10	23	41
			firstReactRender	35	29	49	4	36	43
			getState	11	5	218	21	9	22
			initialActions	1	0	2	1	1	1
			loadScripts	1325	1168	1911	145	1399	1576
			setupStore	12	5	240	31	8	18

Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 6ms
Sum of all benchmark exceeds: 7ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 681 Bytes (0.01%)
ui: 346 Bytes (0%)
common: 1.25 KiB (0.01%)

mathieuartu · 2025-05-15T18:26:06Z

@metamaskbot update-policies

metamaskbot · 2025-05-15T18:40:40Z

No policy changes

metamaskbot · 2025-05-15T19:27:36Z

Builds ready [7a938a9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1198 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1198	1084	1378	60	1239	1306
			load	1036	941	1166	53	1070	1133
			domContentLoaded	1029	937	1156	53	1061	1128
			domInteractive	15	13	25	3	16	24
			firstPaint	678	94	1167	417	1056	1129
			backgroundConnect	8	4	34	5	8	22
			firstReactRender	18	15	26	2	19	23
			getState	14	5	35	8	20	29
			initialActions	0	0	1	0	0	1
			loadScripts	792	702	921	52	825	891
			setupStore	7	5	15	2	8	11
	Webpack	Home	uiStartup	2166	1776	2438	159	2282	2377
			load	1687	1377	2028	119	1743	1887
			domContentLoaded	1679	1373	2024	119	1737	1862
			domInteractive	15	11	52	9	13	40
			firstPaint	172	64	675	77	186	269
			backgroundConnect	31	9	277	36	32	57
			firstReactRender	141	43	353	101	248	338
			getState	15	4	170	23	14	32
			initialActions	3	1	7	1	4	6
			loadScripts	1674	1371	2001	119	1735	1857
			setupStore	18	7	269	26	20	29
Firefox	Browserify	Home	uiStartup	1346	1154	1775	132	1391	1642
			load	1187	1039	1597	115	1243	1444
			domContentLoaded	1187	1039	1597	115	1242	1444
			domInteractive	99	40	183	27	116	143
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	191	20	21	37
			firstReactRender	23	20	54	7	22	50
			getState	15	4	207	38	8	36
			initialActions	0	0	1	0	0	1
			loadScripts	1167	1021	1582	112	1230	1402
			setupStore	10	4	195	27	6	34
	Webpack	Home	uiStartup	1642	1446	2224	153	1690	1988
			load	1400	1225	1928	140	1463	1702
			domContentLoaded	1400	1225	1928	140	1463	1701
			domInteractive	83	38	215	25	90	125
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	229	21	25	34
			firstReactRender	37	31	53	5	39	46
			getState	10	5	33	6	10	29
			initialActions	1	0	2	1	1	1
			loadScripts	1378	1205	1910	138	1444	1687
			setupStore	8	6	37	4	9	11

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1642 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 1378 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1988 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1702 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1701 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1687 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 91ms | Sum of p95 exceeds: 216ms
Sum of all benchmark exceeds: 307ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 681 Bytes (0.01%)
ui: 3.27 KiB (0.05%)
common: 1.29 KiB (0.01%)

… account syncing

mathieuartu · 2025-05-16T18:57:12Z

@MetaMask/policy-reviewers the policy changes are coming from @metamask/profile-sync-controller.
We moved @metamask/keyring-api from being a dependency to a devDependency.

metamaskbot · 2025-06-04T09:46:27Z

Builds ready [877ce0c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1214	1109	1376	57	1255	1323
			load	1051	951	1176	53	1086	1137
			domContentLoaded	1045	945	1171	52	1081	1132
			domInteractive	16	13	37	4	16	28
			firstPaint	789	167	1187	395	1078	1137
			backgroundConnect	7	4	32	4	7	12
			firstReactRender	20	15	35	4	21	29
			getState	14	6	40	8	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	796	703	923	50	828	875
			setupStore	8	5	21	2	8	11
	Webpack	Home	uiStartup	2069	1615	2610	216	2212	2422
			load	1635	1277	2014	179	1760	1926
			domContentLoaded	1629	1273	2000	179	1756	1921
			domInteractive	15	11	48	9	13	44
			firstPaint	161	59	402	64	189	303
			backgroundConnect	25	10	324	40	22	38
			firstReactRender	105	43	353	81	95	330
			getState	10	4	40	5	11	17
			initialActions	3	1	8	1	3	5
			loadScripts	1627	1272	1989	178	1755	1910
			setupStore	22	6	311	50	15	39
Firefox	Browserify	Home	uiStartup	1351	1158	1790	116	1403	1624
			load	1196	1034	1518	99	1259	1411
			domContentLoaded	1196	1034	1518	99	1258	1410
			domInteractive	98	37	246	31	108	163
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	83	9	21	28
			firstReactRender	24	20	53	5	23	29
			getState	9	4	231	22	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1178	1020	1503	98	1233	1393
			setupStore	7	4	82	8	6	12
	Webpack	Home	uiStartup	1662	1429	2172	167	1761	2064
			load	1444	1237	1971	159	1540	1729
			domContentLoaded	1443	1237	1970	159	1540	1727
			domInteractive	80	38	152	18	84	122
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	64	6	24	34
			firstReactRender	44	30	61	6	47	55
			getState	12	5	89	10	10	31
			initialActions	0	0	1	0	1	1
			loadScripts	1423	1222	1950	159	1517	1708
			setupStore	9	5	68	6	8	12

Benchmark value 1662 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1444 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1444 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1423 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2064 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1729 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1727 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 1708 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 244ms | Sum of p95 exceeds: 348ms
Sum of all benchmark exceeds: 592ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 188 Bytes (0%)
ui: 346 Bytes (0%)
common: 1.17 KiB (0.01%)

metamaskbot · 2025-06-04T11:57:04Z

Builds ready [69d884f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1194 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1194	1095	1343	59	1242	1296
			load	1036	950	1172	54	1068	1144
			domContentLoaded	1030	943	1167	54	1059	1138
			domInteractive	16	13	39	5	15	31
			firstPaint	705	131	1182	406	1035	1125
			backgroundConnect	8	4	28	4	8	18
			firstReactRender	20	16	45	4	20	28
			getState	13	5	80	9	18	28
			initialActions	0	0	1	0	0	0
			loadScripts	783	701	921	53	809	893
			setupStore	7	5	18	2	8	11
	Webpack	Home	uiStartup	2094	1581	2650	229	2229	2482
			load	1629	1251	2047	171	1748	1885
			domContentLoaded	1623	1247	2034	170	1743	1875
			domInteractive	15	11	53	8	13	38
			firstPaint	157	61	407	65	175	275
			backgroundConnect	23	10	261	25	23	36
			firstReactRender	143	43	352	110	299	343
			getState	11	4	53	7	12	31
			initialActions	3	1	5	1	3	4
			loadScripts	1620	1245	2023	168	1741	1864
			setupStore	28	6	316	62	17	263
Firefox	Browserify	Home	uiStartup	1379	1210	1826	123	1431	1648
			load	1219	1056	1615	103	1278	1428
			domContentLoaded	1219	1055	1614	103	1278	1428
			domInteractive	94	37	177	26	107	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	94	12	22	43
			firstReactRender	24	21	50	4	24	31
			getState	12	4	187	25	9	26
			initialActions	0	0	1	0	0	1
			loadScripts	1200	1031	1576	102	1259	1403
			setupStore	8	4	76	10	7	12
	Webpack	Home	uiStartup	1566	1351	2132	163	1673	1910
			load	1359	1169	1956	147	1454	1663
			domContentLoaded	1358	1168	1956	147	1454	1663
			domInteractive	77	38	246	23	82	116
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	77	8	22	37
			firstReactRender	40	29	51	4	43	49
			getState	12	5	201	20	10	30
			initialActions	0	0	2	1	1	1
			loadScripts	1339	1151	1940	146	1429	1640
			setupStore	11	5	274	27	8	11

Benchmark value 2482 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 263 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1663 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1663 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1640 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 244ms
Sum of all benchmark exceeds: 248ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 513 Bytes (0.01%)
ui: 346 Bytes (0%)
common: 1.17 KiB (0.01%)

metamaskbot · 2025-06-04T12:38:43Z

Builds ready [591d616]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1205	1077	1425	71	1248	1332
			load	1044	932	1238	65	1087	1152
			domContentLoaded	1038	927	1228	65	1081	1144
			domInteractive	16	13	33	5	16	29
			firstPaint	760	133	1234	399	1062	1144
			backgroundConnect	7	4	26	4	8	13
			firstReactRender	20	17	40	4	21	29
			getState	14	5	45	8	20	28
			initialActions	0	0	1	0	0	0
			loadScripts	792	685	960	63	829	905
			setupStore	7	5	16	2	8	11
	Webpack	Home	uiStartup	2094	1621	2581	214	2247	2440
			load	1631	1281	1993	164	1750	1864
			domContentLoaded	1622	1277	1981	162	1732	1851
			domInteractive	16	11	70	11	12	49
			firstPaint	168	59	322	52	201	275
			backgroundConnect	25	11	259	25	26	42
			firstReactRender	148	43	357	109	279	348
			getState	11	4	35	6	12	26
			initialActions	3	1	7	1	3	5
			loadScripts	1619	1276	1970	160	1730	1840
			setupStore	20	6	307	41	17	31
Firefox	Browserify	Home	uiStartup	1455	1255	1917	139	1523	1772
			load	1283	1090	1746	130	1345	1534
			domContentLoaded	1282	1090	1746	130	1345	1534
			domInteractive	102	39	248	27	116	143
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	97	12	24	52
			firstReactRender	26	22	63	5	26	34
			getState	10	5	194	19	9	14
			initialActions	0	0	1	0	0	1
			loadScripts	1261	1073	1718	129	1326	1515
			setupStore	10	4	191	19	7	16
	Webpack	Home	uiStartup	1584	1356	2101	160	1651	1966
			load	1381	1173	1881	157	1452	1770
			domContentLoaded	1380	1173	1881	157	1452	1769
			domInteractive	76	36	192	21	82	116
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	77	9	22	42
			firstReactRender	41	29	54	4	44	47
			getState	9	4	32	5	9	24
			initialActions	0	0	2	1	1	1
			loadScripts	1362	1158	1863	157	1435	1751
			setupStore	8	5	28	4	8	19

Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1283 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1283 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 1262 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1772 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1534 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1534 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1515 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1363 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1966 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1770 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1769 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1751 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 175ms | Sum of p95 exceeds: 601ms
Sum of all benchmark exceeds: 776ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 182 Bytes (0%)
ui: 346 Bytes (0%)
common: 1.17 KiB (0.01%)

Copilot

Pull Request Overview

This PR adds multi-SRP support to EVM account syncing by updating controllers and storage logic to handle parallel sessions based on each SRP’s entropySource. Key changes include the introduction of SRP-specific identifiers in mocks and encrypted data, modifications to test cases and helper utilities to support multi-SRP flows, and updates to controller state and messaging to replace the legacy sessionData with srpSessionData.

Reviewed Changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/e2e/tests/identity/mocks.ts	Added SRP identifier generation logic for multi-SRP support
test/e2e/tests/identity/constants.ts	Added new constants for the second SRP
test/e2e/tests/identity/account-syncing/*.spec.ts	Updated end-to-end tests to cover multi-SRP scenarios
test/e2e/tests/identity/account-syncing/helpers.ts	Adjusted waiting condition in event counter helper
test/e2e/helpers/identity/user-storage/*.ts	Updated user storage controller tests to handle SrpIdentifier
shared/types/background.ts, app/scripts/controllers/.ts, app/scripts/	Replaced legacy sessionData with srpSessionData to support multi-SRP
package.json, lavamoat/browserify/, app/scripts/migrations/	Upgraded dependencies and updated policies/migrations for new design

Comments suppressed due to low confidence (4)

app/scripts/controllers/metametrics-controller.ts:1207

Extracting the profileId from the first entry of srpSessionData may be ambiguous when multiple SRP sessions are present. Consider explicitly selecting the intended SRP session.

[MetaMetricsUserTrait.ProfileId]: Object.entries(metamaskState.srpSessionData || {})?.[0]?.[1]?.profile?.profileId,

app/scripts/metamask-controller.js:4648

If syncInternalAccountsWithUserStorage is asynchronous, consider awaiting its completion before releasing the lock to ensure data consistency.

this.userStorageController.syncInternalAccountsWithUserStorage();

test/e2e/tests/identity/account-syncing/sync-after-adding-account.spec.ts:108

The expected event count has changed from 2 to 1; please ensure that this adjustment aligns with the intended behavior for multi-SRP event emissions.

await waitUntilEventsEmittedNumberEquals(1);

test/e2e/tests/identity/account-syncing/helpers.ts:45

[nitpick] Using '>=' instead of '===' relaxes the wait condition, which may mask unexpected extra events; please verify that this behavior is intentional.

await driver.waitUntil(async () => counter >= expectedNumber, {

metamaskbot · 2025-06-05T14:57:48Z

Builds ready [070e647]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 77 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1239	1119	1576	77	1289	1366
			load	1074	951	1313	73	1111	1214
			domContentLoaded	1067	946	1308	73	1104	1204
			domInteractive	18	13	101	10	16	30
			firstPaint	836	133	1347	393	1090	1209
			backgroundConnect	8	4	29	4	8	21
			firstReactRender	21	16	72	7	21	35
			getState	14	6	40	7	19	26
			initialActions	0	0	2	0	0	1
			loadScripts	816	698	1048	72	851	960
			setupStore	8	5	16	2	8	12
	Webpack	Home	uiStartup	2184	1696	2675	216	2320	2557
			load	1703	1345	2050	172	1820	1967
			domContentLoaded	1697	1342	2037	170	1814	1954
			domInteractive	16	12	55	9	13	43
			firstPaint	177	61	639	83	219	329
			backgroundConnect	22	11	70	9	25	39
			firstReactRender	149	44	373	112	305	362
			getState	13	4	317	31	12	19
			initialActions	3	1	5	1	3	4
			loadScripts	1694	1340	2026	169	1812	1943
			setupStore	39	7	353	83	19	320
Firefox	Browserify	Home	uiStartup	1311	1159	1636	97	1350	1542
			load	1162	1032	1476	86	1214	1323
			domContentLoaded	1162	1032	1476	86	1214	1323
			domInteractive	93	35	240	31	101	155
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	64	10	20	47
			firstReactRender	22	19	44	3	23	28
			getState	11	4	178	24	8	28
			initialActions	0	0	1	0	0	1
			loadScripts	1144	1013	1462	86	1195	1304
			setupStore	8	3	159	17	6	13
	Webpack	Home	uiStartup	1513	1364	1878	107	1581	1697
			load	1315	1170	1660	101	1373	1499
			domContentLoaded	1315	1170	1660	101	1372	1499
			domInteractive	73	53	138	17	74	127
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	49	6	22	35
			firstReactRender	40	29	53	4	43	46
			getState	9	5	33	6	9	29
			initialActions	1	0	2	1	1	1
			loadScripts	1296	1147	1643	101	1355	1481
			setupStore	9	5	212	20	8	10

Benchmark value 1240 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 836 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 1366 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1215 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1204 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1209 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 961 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2557 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 320 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 65ms | Sum of p95 exceeds: 466ms
Sum of all benchmark exceeds: 531ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -105.46 KiB (-1.98%)
ui: 14.44 KiB (0.2%)
common: -4.4 KiB (-0.05%)

metamaskbot · 2025-06-10T09:46:14Z

Builds ready [e54a147]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1202 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1202	1089	1317	55	1249	1292
			load	1043	935	1158	53	1074	1134
			domContentLoaded	1036	927	1152	54	1070	1127
			domInteractive	16	13	40	5	15	30
			firstPaint	781	81	1158	396	1059	1128
			backgroundConnect	8	4	32	5	7	21
			firstReactRender	20	15	38	4	20	29
			getState	13	6	40	8	18	33
			initialActions	0	0	1	0	0	1
			loadScripts	793	695	907	53	828	887
			setupStore	8	5	18	2	8	13
	Webpack	Home	uiStartup	2056	1589	2564	231	2215	2434
			load	1601	1197	1963	185	1748	1887
			domContentLoaded	1596	1190	1950	184	1743	1882
			domInteractive	15	11	47	8	13	40
			firstPaint	154	66	495	66	177	298
			backgroundConnect	21	10	57	7	23	31
			firstReactRender	122	41	374	100	122	343
			getState	19	4	327	50	13	24
			initialActions	6	1	299	30	3	5
			loadScripts	1593	1186	1939	183	1741	1879
			setupStore	50	7	324	93	21	308
Firefox	Browserify	Home	uiStartup	1397	1219	1982	112	1446	1606
			load	1231	1057	1541	94	1298	1422
			domContentLoaded	1231	1057	1541	94	1297	1421
			domInteractive	100	36	298	33	115	152
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	202	21	23	54
			firstReactRender	25	21	61	7	25	31
			getState	10	4	242	23	9	11
			initialActions	0	0	1	0	0	1
			loadScripts	1211	1042	1527	94	1282	1403
			setupStore	9	4	185	19	7	15
	Webpack	Home	uiStartup	1589	1359	1835	115	1687	1795
			load	1371	1166	1633	110	1449	1597
			domContentLoaded	1371	1165	1633	110	1448	1597
			domInteractive	76	33	140	18	83	116
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	17	67	7	24	39
			firstReactRender	42	29	53	4	45	48
			getState	10	5	32	6	10	31
			initialActions	0	0	2	1	1	1
			loadScripts	1350	1150	1610	110	1428	1575
			setupStore	12	5	269	28	9	19

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 50 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 25ms | Sum of p95 exceeds: 247ms
Sum of all benchmark exceeds: 272ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 188 Bytes (0%)
ui: 346 Bytes (0%)
common: 1.17 KiB (0.01%)

metamaskbot · 2025-06-10T11:43:06Z

Builds ready [896f188]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1238 ± 83 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1238	1110	1773	83	1282	1337
			load	1069	945	1551	79	1111	1175
			domContentLoaded	1062	928	1544	80	1104	1170
			domInteractive	18	13	95	10	16	33
			firstPaint	783	82	1561	413	1090	1175
			backgroundConnect	8	4	31	5	8	23
			firstReactRender	20	16	35	3	21	27
			getState	14	5	34	7	20	27
			initialActions	0	0	1	0	0	0
			loadScripts	815	696	981	65	859	924
			setupStore	8	5	21	3	9	13
	Webpack	Home	uiStartup	2109	1594	2534	227	2287	2462
			load	1631	1252	1933	166	1739	1870
			domContentLoaded	1625	1248	1924	165	1733	1861
			domInteractive	15	11	44	8	13	39
			firstPaint	158	59	599	69	182	286
			backgroundConnect	21	14	42	6	24	34
			firstReactRender	134	43	352	103	124	348
			getState	10	4	25	4	12	19
			initialActions	3	1	6	1	3	5
			loadScripts	1622	1246	1913	164	1730	1850
			setupStore	39	7	339	82	18	314
Firefox	Browserify	Home	uiStartup	1368	1212	1680	96	1413	1562
			load	1212	1081	1529	94	1263	1429
			domContentLoaded	1212	1081	1529	94	1263	1428
			domInteractive	97	36	193	26	110	149
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	117	16	23	50
			firstReactRender	24	21	57	4	24	30
			getState	8	5	40	5	8	13
			initialActions	0	0	2	0	0	1
			loadScripts	1190	1064	1504	93	1241	1371
			setupStore	7	4	68	6	6	8
	Webpack	Home	uiStartup	1537	1362	1986	130	1621	1795
			load	1334	1165	1711	119	1431	1542
			domContentLoaded	1334	1165	1711	119	1430	1541
			domInteractive	76	32	145	16	82	109
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	49	5	21	31
			firstReactRender	40	26	47	3	43	46
			getState	8	5	31	4	9	17
			initialActions	0	0	2	1	1	1
			loadScripts	1316	1144	1689	119	1413	1523
			setupStore	9	5	220	21	8	11

Benchmark value 1238 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 39 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2462 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 314 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 262ms
Sum of all benchmark exceeds: 278ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 188 Bytes (0%)
ui: 346 Bytes (0%)
common: 2.13 KiB (0.03%)

test: multi-srp / multi-auth account syncing

3640442

mathieuartu self-assigned this May 15, 2025

mathieuartu added the team-identity-deprecated DEPRECATED: team no longer exists label May 15, 2025

mathieuartu mentioned this pull request May 15, 2025

feat(backup & sync): use entropySourceId to sync accounts for Multi-SRP MetaMask/core#5753

Merged

23 tasks

fix: UTs + deprecate sessionData in favor of srpSessionData

344b959

fix: srpSessionData & sentry state

68e80c8

Update LavaMoat policies

48e60b8

mathieuartu added 6 commits May 15, 2025 14:56

fix: UT

aa85297

fix: protect account syncing during conflicting operations

a2c9d32

Merge branch 'test/core-PR-5753-testdrive' of github.com:MetaMask/met…

289b920

…amask-extension into test/core-PR-5753-testdrive

Merge branch 'main' into test/core-PR-5753-testdrive

afa3300

fix: yarn.lock

0e81ecb

fix: identity UTs

2d5db7e

fix: update preview package

8194570

fix: E2E test

7a938a9

feat: add multi-srp E2E framework + one E2E test to support multi-SRP…

196ec6f

… account syncing

github-advanced-security AI found potential problems May 16, 2025

View reviewed changes

Comment thread test/e2e/tests/identity/mocks.ts Fixed

fix: manually call account sync after _addAccountsWithBalance

877ce0c

fix: improve account sync logic for multi-srp

69d884f

fix: improve account sync logic for multi-srp

591d616

chrisleewilcox requested a review from Copilot June 5, 2025 14:25

Copilot AI reviewed Jun 5, 2025

View reviewed changes

fix: await account sync after importing a new SRP

070e647

mathieuartu marked this pull request as ready for review June 5, 2025 15:00

mathieuartu requested review from a team as code owners June 5, 2025 15:00

mathieuartu marked this pull request as draft June 6, 2025 11:35

Merge branch 'main' into test/core-PR-5753-testdrive

e54a147

fix: bump profile-sync-controller to 17.1.0

896f188

fabiobozzo approved these changes Jun 11, 2025

View reviewed changes

Prithpal-Sooriya approved these changes Jun 11, 2025

View reviewed changes

Prithpal-Sooriya reviewed Jun 11, 2025

View reviewed changes

Comment thread lavamoat/browserify/beta/policy.json

mathieuartu marked this pull request as ready for review June 11, 2025 10:00

mathieuartu added this pull request to the merge queue Jun 11, 2025

Merged via the queue into main with commit 69ca296 Jun 11, 2025
146 checks passed

mathieuartu deleted the test/core-PR-5753-testdrive branch June 11, 2025 10:30

github-actions Bot locked and limited conversation to collaborators Jun 11, 2025

metamaskbot added the release-12.22.0 Issue or pull request that will be included in release 12.22.0 label Jun 11, 2025

Conversation

mathieuartu commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented May 15, 2025

Uh oh!

socket-security Bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

mathieuartu commented May 15, 2025

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

mathieuartu commented May 15, 2025

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

Uh oh!

mathieuartu commented May 16, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 10, 2025

Uh oh!

metamaskbot commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mathieuartu commented May 15, 2025 •

edited

Loading

socket-security Bot commented May 15, 2025 •

edited

Loading

metamaskbot commented May 15, 2025 •

edited

Loading