chore: upgrade to v60 by salimtb · Pull Request #32321 · MetaMask/metamask-extension

salimtb · 2025-04-27T19:05:41Z

Description

This update upgrades the asset controllers to version 60, which introduces important changes to the TokensController:

Refactored TokensController to eliminate reliance on a single selected network (#5659).
TokensController methods now require networkClientId to be explicitly passed as a parameter.
Token management logic is now fully parameterized by chainId, enabling multi-chain token handling and improving reliability across network changes.
Internal state updates and token metadata fetching are now scoped to the appropriate chainId.

Related issues

Fixes:

Manual testing steps

Go to MM
Test add tokens , hide tokens, and other flows

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-27T19:05:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-04-27T19:06:39Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/assets-controllers@59.0.0 ⏵ 60.0.0	⁺¹			⁺²

View full report

metamaskbot · 2025-04-30T09:48:45Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers

ui/pages/swaps/index.js
ui/pages/swaps/prepare-swap-page/prepare-swap-page.js

🖥️ @MetaMask/wallet-ux

ui/components/multichain/import-nfts-modal/import-nfts-modal.js
ui/components/multichain/import-nfts-modal/import-nfts-modal.test.js

metamaskbot · 2025-04-30T10:28:05Z

Builds ready [530da94]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1200 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1200	1084	1397	59	1241	1314
			load	1040	956	1198	50	1073	1129
			domContentLoaded	1033	900	1193	51	1068	1122
			domInteractive	17	13	60	7	16	27
			firstPaint	678	72	1197	414	1040	1133
			backgroundConnect	8	4	100	10	8	19
			firstReactRender	20	16	73	6	20	31
			getState	13	5	36	8	18	29
			initialActions	0	0	1	0	0	1
			loadScripts	796	665	953	49	828	887
			setupStore	8	4	60	6	8	13
	Webpack	Home	uiStartup	2141	1763	2575	187	2279	2409
			load	1655	1365	2102	148	1773	1857
			domContentLoaded	1648	1361	2096	147	1764	1853
			domInteractive	16	12	64	9	13	40
			firstPaint	162	68	603	75	206	280
			backgroundConnect	30	10	381	37	34	58
			firstReactRender	205	56	397	118	320	362
			getState	11	4	55	8	12	32
			initialActions	3	1	7	1	4	5
			loadScripts	1643	1360	2073	146	1760	1851
			setupStore	21	6	297	29	22	40
Firefox	Browserify	Home	uiStartup	1355	1180	1691	96	1408	1552
			load	1207	1053	1461	96	1272	1389
			domContentLoaded	1207	1053	1461	96	1272	1389
			domInteractive	104	37	250	37	116	179
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	147	17	20	34
			firstReactRender	23	19	54	5	23	28
			getState	7	4	33	4	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1188	1043	1447	98	1257	1368
			setupStore	8	4	180	18	6	11
	Webpack	Home	uiStartup	1492	1327	1787	105	1570	1700
			load	1281	1152	1552	91	1328	1487
			domContentLoaded	1280	1152	1552	91	1327	1487
			domInteractive	83	49	163	25	96	145
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	276	26	23	40
			firstReactRender	34	28	53	5	36	42
			getState	10	4	33	7	9	30
			initialActions	1	0	2	1	1	1
			loadScripts	1259	1136	1535	88	1305	1454
			setupStore	9	5	42	7	8	28

Benchmark value 19 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 1ms
Sum of all benchmark exceeds: 1ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43.97 KiB (0.83%)
ui: 1.17 KiB (0.02%)
common: 90.71 KiB (0.98%)

metamaskbot · 2025-04-30T11:29:24Z

Builds ready [6348b0b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1068	1410	59	1241	1328
			load	1050	946	1240	55	1075	1153
			domContentLoaded	1044	942	1233	54	1070	1147
			domInteractive	18	14	60	7	17	29
			firstPaint	685	86	1160	418	1058	1128
			backgroundConnect	7	4	26	3	7	13
			firstReactRender	21	14	49	6	22	35
			getState	14	5	43	8	18	30
			initialActions	0	0	6	1	0	1
			loadScripts	805	708	999	53	835	907
			setupStore	8	4	16	2	8	13
	Webpack	Home	uiStartup	2085	1676	2497	185	2219	2300
			load	1605	1313	1920	140	1704	1810
			domContentLoaded	1598	1310	1901	139	1698	1806
			domInteractive	15	11	58	10	13	44
			firstPaint	166	66	327	61	209	269
			backgroundConnect	27	9	226	24	28	65
			firstReactRender	203	54	409	116	318	366
			getState	14	4	250	25	15	25
			initialActions	3	1	6	1	3	5
			loadScripts	1594	1309	1878	137	1696	1804
			setupStore	23	6	311	40	21	38
Firefox	Browserify	Home	uiStartup	1369	1179	1667	100	1429	1588
			load	1222	1021	1498	103	1290	1437
			domContentLoaded	1222	1021	1497	103	1290	1437
			domInteractive	106	37	238	34	120	160
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	111	13	21	49
			firstReactRender	23	19	40	4	23	29
			getState	7	4	27	3	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1203	1007	1481	104	1273	1414
			setupStore	6	4	34	4	6	13
	Webpack	Home	uiStartup	1941	1634	2739	202	2050	2342
			load	1657	1411	2409	181	1763	2004
			domContentLoaded	1656	1410	2409	182	1762	2003
			domInteractive	106	47	206	30	121	177
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	16	79	11	32	53
			firstReactRender	45	30	73	9	51	64
			getState	17	4	309	31	14	43
			initialActions	1	0	4	1	1	1
			loadScripts	1632	1394	2395	179	1726	1974
			setupStore	10	6	36	5	11	20

cc: @HowardBraham
Benchmark value 1942 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1657 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1657 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1632 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2342 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 2004 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 2003 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 177 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 43 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1974 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 1173ms | Sum of p95 exceeds: 1488ms
Sum of all benchmark exceeds: 2661ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43.97 KiB (0.83%)
ui: 946 Bytes (0.01%)
common: 91.7 KiB (0.99%)

metamaskbot · 2025-04-30T13:49:03Z

Builds ready [bf3a4f0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1234 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1234	1116	1554	69	1270	1368
			load	1072	964	1359	67	1109	1214
			domContentLoaded	1066	961	1351	66	1101	1208
			domInteractive	18	14	63	8	17	30
			firstPaint	760	102	1220	413	1082	1168
			backgroundConnect	7	4	19	2	8	10
			firstReactRender	22	15	48	7	22	41
			getState	14	5	54	9	20	32
			initialActions	0	0	1	0	0	1
			loadScripts	825	722	1056	62	857	963
			setupStore	8	5	21	2	8	12
	Webpack	Home	uiStartup	2249	1865	2872	198	2388	2561
			load	1762	1395	2279	179	1879	2128
			domContentLoaded	1755	1391	2241	178	1874	2121
			domInteractive	17	12	76	11	14	54
			firstPaint	183	74	528	80	227	346
			backgroundConnect	36	10	396	54	35	82
			firstReactRender	198	59	396	119	315	362
			getState	19	4	336	41	17	35
			initialActions	3	1	8	1	4	6
			loadScripts	1747	1389	2235	177	1871	2096
			setupStore	23	7	288	29	27	47
Firefox	Browserify	Home	uiStartup	1361	1174	1734	103	1412	1572
			load	1216	1023	1549	101	1265	1442
			domContentLoaded	1216	1023	1549	101	1265	1442
			domInteractive	107	37	258	32	119	164
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	104	11	19	37
			firstReactRender	23	19	56	6	24	28
			getState	8	5	37	4	8	18
			initialActions	0	0	2	0	0	1
			loadScripts	1198	1009	1536	102	1249	1420
			setupStore	8	3	187	18	6	8
	Webpack	Home	uiStartup	1504	1346	1826	106	1579	1721
			load	1292	1163	1573	94	1352	1496
			domContentLoaded	1292	1163	1572	94	1352	1496
			domInteractive	82	54	230	27	93	135
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	77	8	23	42
			firstReactRender	35	29	48	4	37	45
			getState	9	4	33	5	9	11
			initialActions	1	0	2	1	1	1
			loadScripts	1272	1147	1542	94	1331	1479
			setupStore	8	5	27	4	8	20

cc: @HowardBraham
Benchmark value 1235 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1072 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1066 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1368 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1214 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1208 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 963 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2250 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1763 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1756 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1747 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2561 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2128 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2122 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 346 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 2096 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Sum of mean exceeds: 218ms | Sum of p95 exceeds: 538ms
Sum of all benchmark exceeds: 756ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: 412 Bytes (0.01%)
common: -615 Bytes (-0.01%)

metamaskbot · 2025-05-01T10:08:54Z

Builds ready [9743747]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1198 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1198	1075	1477	64	1237	1319
			load	1040	939	1226	56	1077	1151
			domContentLoaded	1034	934	1222	56	1070	1145
			domInteractive	17	13	61	7	16	28
			firstPaint	708	129	1208	411	1048	1109
			backgroundConnect	7	4	22	3	7	10
			firstReactRender	22	15	53	7	21	38
			getState	13	5	38	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	799	709	972	52	829	907
			setupStore	8	5	23	3	8	15
	Webpack	Home	uiStartup	2092	1722	2537	196	2230	2336
			load	1609	1242	1999	149	1731	1796
			domContentLoaded	1602	1234	1978	147	1722	1792
			domInteractive	16	11	60	11	13	50
			firstPaint	171	67	693	80	203	278
			backgroundConnect	29	10	368	37	30	60
			firstReactRender	203	55	370	114	321	361
			getState	15	4	422	41	13	32
			initialActions	3	1	5	1	3	4
			loadScripts	1597	1232	1955	146	1718	1789
			setupStore	17	6	41	7	20	28
Firefox	Browserify	Home	uiStartup	1397	1168	1916	116	1468	1573
			load	1250	1017	1616	113	1335	1433
			domContentLoaded	1249	1016	1616	113	1334	1433
			domInteractive	106	36	260	32	120	164
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	87	9	21	36
			firstReactRender	23	19	50	4	23	31
			getState	9	4	198	19	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1231	1002	1598	113	1319	1415
			setupStore	6	4	38	4	6	10
	Webpack	Home	uiStartup	1494	1333	1915	108	1541	1744
			load	1287	1139	1695	96	1334	1501
			domContentLoaded	1287	1139	1694	96	1334	1500
			domInteractive	77	52	137	15	85	107
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	43	5	21	32
			firstReactRender	33	28	47	4	35	42
			getState	11	4	260	25	9	28
			initialActions	0	0	1	0	1	1
			loadScripts	1270	1124	1669	95	1317	1478
			setupStore	7	5	21	2	8	11

Benchmark value 1250 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1250 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 1232 exceeds gate value 1230 for firefox browserify home mean loadScripts
Sum of mean exceeds: 18ms | Sum of p95 exceeds: 0ms
Sum of all benchmark exceeds: 18ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: 412 Bytes (0.01%)
common: -615 Bytes (-0.01%)

salimtb added 2 commits April 25, 2025 13:58

fix: integrate new token rate controller

97fcf8b

chore: upgrade to v60

7b14baa

metamaskbot added the team-assets label Apr 27, 2025

Base automatically changed from fix/integrate-token-rates-controller to main April 28, 2025 11:35

salimtb added 3 commits April 28, 2025 19:50

fix: upgrade to v60

88a7508

Merge branch 'main' into chore/upgrade-assets-to-v60

c74d816

fix: fix after merge

2512bfc

salimtb marked this pull request as ready for review April 28, 2025 18:09

salimtb added 5 commits April 29, 2025 01:09

Merge branch 'main' into chore/upgrade-assets-to-v60

f8248f0

Merge branch 'main' into chore/upgrade-assets-to-v60

c751fc9

chore: trigger CI

1c43684

Merge branch 'main' into chore/upgrade-assets-to-v60

abccd1a

fix: fix ignore tokens

530da94

salimtb requested a review from a team as a code owner April 30, 2025 09:46

fix: fix ignore tokens

6348b0b

salimtb requested a review from a team as a code owner April 30, 2025 10:51

Merge branch 'main' into chore/upgrade-assets-to-v60

bf3a4f0

salimtb and others added 2 commits April 30, 2025 17:29

Merge branch 'main' into chore/upgrade-assets-to-v60

c6ec2ec

Merge branch 'main' into chore/upgrade-assets-to-v60

9743747

sahar-fehri approved these changes May 1, 2025

View reviewed changes

darkwing approved these changes May 1, 2025

View reviewed changes

GustavoRSSilva approved these changes May 1, 2025

View reviewed changes

sahar-fehri added this pull request to the merge queue May 1, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2025

sahar-fehri added this pull request to the merge queue May 1, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2025

sahar-fehri added this pull request to the merge queue May 1, 2025

Merged via the queue into main with commit 740ce05 May 1, 2025
163 checks passed

sahar-fehri deleted the chore/upgrade-assets-to-v60 branch May 1, 2025 17:10

github-actions Bot locked and limited conversation to collaborators May 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to v60#32321

chore: upgrade to v60#32321
sahar-fehri merged 14 commits into
mainfrom
chore/upgrade-assets-to-v60

salimtb commented Apr 27, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 27, 2025

Uh oh!

socket-security Bot commented Apr 27, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 30, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

salimtb commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 27, 2025

Uh oh!

socket-security Bot commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented Apr 30, 2025

Uh oh!

metamaskbot commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

salimtb commented Apr 27, 2025 •

edited

Loading

socket-security Bot commented Apr 27, 2025 •

edited

Loading

metamaskbot commented Apr 30, 2025 •

edited

Loading