feat: bump `@metamask/chain-agnostic-permission` to `0.6.0` by jiexi · Pull Request #32152 · MetaMask/metamask-extension

jiexi · 2025-04-21T19:11:10Z

Description

Moves caip-25 helpers added in sip-26 branch into the core package

Related issues

See: MetaMask/core#5609

Manual testing steps

No user facing changes

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-21T19:11:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-04-21T19:11:48Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/chain-agnostic-permission@0.3.0 ⏵ 0.6.0	⁺¹		⁺¹

View full report

metamaskbot · 2025-04-21T19:12:57Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/confirmation/stories/success.stories.js

🖥️ @MetaMask/wallet-ux

ui/components/multichain/account-list-menu/account-list-menu.test.tsx
ui/components/multichain/connect-accounts-modal/connect-accounts-modal.stories.tsx
ui/components/multichain/connected-status/connected-status.tsx
ui/components/multichain/edit-accounts-modal/edit-accounts-modal.stories.tsx
ui/components/multichain/pages/review-permissions-page/review-permissions-page.tsx
ui/components/multichain/pages/send/send.test.js

…refactor' into jl/adopt-sip-26-post-merge-core-refactor

…cunt

metamaskbot · 2025-04-22T00:05:58Z

Builds ready [1e6c8b6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1188 ± 52 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1188	1095	1373	52	1223	1282
			load	1024	896	1172	51	1053	1116
			domContentLoaded	1018	889	1165	50	1049	1109
			domInteractive	16	13	51	5	16	26
			firstPaint	685	84	1145	406	1042	1112
			backgroundConnect	6	4	11	1	7	9
			firstReactRender	21	15	53	6	22	34
			getState	12	5	31	7	17	28
			initialActions	0	0	1	0	0	1
			loadScripts	784	664	919	49	815	878
			setupStore	7	5	16	2	8	12
	Webpack	Home	uiStartup	2104	1705	2725	176	2228	2303
			load	1623	1329	2007	129	1729	1776
			domContentLoaded	1616	1326	1996	127	1723	1768
			domInteractive	16	11	72	11	13	50
			firstPaint	206	67	1568	205	232	325
			backgroundConnect	24	9	88	14	25	56
			firstReactRender	201	55	382	116	331	356
			getState	11	4	43	6	14	26
			initialActions	3	1	6	1	4	5
			loadScripts	1612	1324	1973	127	1721	1764
			setupStore	21	6	279	30	21	35
Firefox	Browserify	Home	uiStartup	1370	1189	1714	98	1422	1556
			load	1216	1059	1560	105	1281	1414
			domContentLoaded	1216	1058	1559	105	1281	1413
			domInteractive	106	35	232	36	127	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	80	12	20	52
			firstReactRender	24	19	77	8	24	33
			getState	8	4	68	7	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1196	1038	1543	107	1264	1396
			setupStore	6	4	34	4	6	12
	Webpack	Home	uiStartup	1570	1368	1991	137	1640	1850
			load	1343	1185	1763	125	1412	1587
			domContentLoaded	1342	1185	1762	125	1412	1587
			domInteractive	83	56	151	22	90	138
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	125	12	24	40
			firstReactRender	36	30	57	5	39	45
			getState	9	5	32	5	9	20
			initialActions	1	0	2	1	1	1
			loadScripts	1321	1170	1676	121	1393	1564
			setupStore	10	5	63	10	9	43

Benchmark value 207 exceeds gate value 199 for chrome webpack home mean firstPaint
Benchmark value 43 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 15ms
Sum of all benchmark exceeds: 23ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -530 Bytes (-0.01%)
ui: -679 Bytes (-0.01%)
common: 1.18 KiB (0.01%)

metamaskbot · 2025-04-22T16:42:21Z

Builds ready [e1efe73]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1102	1405	67	1256	1351
			load	1054	955	1235	59	1088	1197
			domContentLoaded	1048	934	1221	59	1080	1191
			domInteractive	17	13	58	6	16	27
			firstPaint	674	81	1227	419	1055	1124
			backgroundConnect	7	4	33	4	8	13
			firstReactRender	20	16	48	5	21	32
			getState	14	5	33	8	20	27
			initialActions	0	0	1	0	0	1
			loadScripts	809	700	960	56	841	938
			setupStore	7	5	16	2	8	13
	Webpack	Home	uiStartup	2088	1695	2502	162	2202	2308
			load	1607	1259	1904	118	1709	1756
			domContentLoaded	1600	1255	1884	117	1705	1747
			domInteractive	15	11	54	9	13	41
			firstPaint	179	64	344	62	217	292
			backgroundConnect	23	9	101	15	26	57
			firstReactRender	189	54	417	119	331	362
			getState	13	4	249	24	14	22
			initialActions	3	1	6	1	3	5
			loadScripts	1596	1253	1862	118	1703	1745
			setupStore	20	6	271	30	19	30
Firefox	Browserify	Home	uiStartup	1396	1228	1727	105	1450	1616
			load	1243	1048	1561	111	1305	1459
			domContentLoaded	1242	1047	1560	111	1304	1458
			domInteractive	115	38	360	43	130	196
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	135	18	23	45
			firstReactRender	23	20	52	4	24	29
			getState	8	5	60	6	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1221	1031	1539	111	1289	1440
			setupStore	7	4	34	4	6	8
	Webpack	Home	uiStartup	1531	1327	2154	149	1587	1947
			load	1308	1144	1947	136	1354	1664
			domContentLoaded	1307	1144	1946	136	1354	1663
			domInteractive	79	38	166	22	82	139
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	111	13	25	41
			firstReactRender	36	29	58	6	39	50
			getState	10	5	30	6	10	30
			initialActions	1	0	1	1	1	1
			loadScripts	1286	1122	1877	133	1332	1636
			setupStore	9	5	47	7	9	26

cc: @HowardBraham
Benchmark value 1197 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1191 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1243 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 196 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 1947 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1663 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1636 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 44ms
Sum of all benchmark exceeds: 53ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -530 Bytes (-0.01%)
ui: 1.54 KiB (0.02%)
common: 1.18 KiB (0.01%)

jiexi · 2025-04-22T20:46:39Z

TODO: use account comparison helper after the following is merged

#32169 (review)

metamaskbot · 2025-04-22T22:02:04Z

Builds ready [79a0d1d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1204 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1204	1103	1403	59	1237	1328
			load	1039	945	1200	52	1064	1143
			domContentLoaded	1034	942	1173	51	1059	1138
			domInteractive	17	13	60	6	17	30
			firstPaint	790	159	1197	388	1060	1134
			backgroundConnect	7	4	27	2	7	10
			firstReactRender	19	15	36	3	20	27
			getState	14	4	41	9	19	30
			initialActions	0	0	1	0	0	1
			loadScripts	797	707	933	49	819	901
			setupStore	7	4	16	2	8	12
	Webpack	Home	uiStartup	2228	1835	2610	162	2342	2481
			load	1719	1407	2190	142	1811	1992
			domContentLoaded	1711	1403	2185	140	1806	1960
			domInteractive	16	11	57	9	14	44
			firstPaint	179	65	362	59	208	289
			backgroundConnect	29	8	95	18	36	74
			firstReactRender	221	55	405	117	333	373
			getState	16	4	199	21	17	32
			initialActions	3	1	7	1	4	6
			loadScripts	1706	1401	2183	139	1804	1935
			setupStore	24	7	301	33	26	44
Firefox	Browserify	Home	uiStartup	1343	1150	1706	102	1419	1512
			load	1200	1003	1540	106	1273	1368
			domContentLoaded	1199	1003	1540	106	1273	1368
			domInteractive	97	37	195	28	104	142
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	102	11	19	33
			firstReactRender	22	18	51	4	23	28
			getState	7	4	27	3	8	10
			initialActions	0	0	2	0	0	1
			loadScripts	1181	989	1523	106	1257	1350
			setupStore	6	4	53	5	6	7
	Webpack	Home	uiStartup	1471	1275	1918	112	1542	1689
			load	1261	1113	1536	95	1321	1464
			domContentLoaded	1261	1112	1535	95	1321	1464
			domInteractive	82	46	257	28	93	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	14	59	7	21	31
			firstReactRender	33	28	54	4	35	43
			getState	10	4	194	19	8	28
			initialActions	0	0	2	1	1	1
			loadScripts	1244	1099	1520	94	1305	1450
			setupStore	8	4	28	4	8	14

cc: @HowardBraham
Benchmark value 2228 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1719 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1712 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1707 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2481 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 373 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Sum of mean exceeds: 60ms | Sum of p95 exceeds: 30ms
Sum of all benchmark exceeds: 90ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -530 Bytes (-0.01%)
ui: 1.54 KiB (0.02%)
common: 1.18 KiB (0.01%)

vinnyhoward

Nice refactor LGTM

metamaskbot · 2025-05-15T19:18:02Z

Builds ready [8668abf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1204 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1204	1090	1416	66	1243	1334
			load	1043	932	1253	62	1068	1163
			domContentLoaded	1036	928	1247	62	1063	1158
			domInteractive	16	13	25	3	16	24
			firstPaint	774	133	1254	390	1054	1157
			backgroundConnect	8	4	23	4	8	18
			firstReactRender	19	16	33	3	20	27
			getState	15	5	95	11	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	800	704	1006	62	822	925
			setupStore	7	5	16	2	8	10
	Webpack	Home	uiStartup	2164	1672	2513	171	2281	2384
			load	1681	1310	1963	131	1773	1879
			domContentLoaded	1674	1307	1940	131	1769	1875
			domInteractive	16	11	65	12	13	56
			firstPaint	157	61	322	57	184	295
			backgroundConnect	32	9	237	34	38	63
			firstReactRender	145	43	339	99	253	321
			getState	13	4	46	7	17	26
			initialActions	3	1	7	1	3	6
			loadScripts	1669	1305	1916	132	1767	1869
			setupStore	18	7	204	20	20	34
Firefox	Browserify	Home	uiStartup	1343	1154	1893	139	1381	1626
			load	1185	1024	1577	111	1247	1411
			domContentLoaded	1185	1024	1577	111	1247	1411
			domInteractive	104	42	290	37	116	163
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	84	9	20	28
			firstReactRender	23	19	51	6	23	40
			getState	18	4	248	46	8	195
			initialActions	0	0	29	3	0	1
			loadScripts	1167	1008	1551	110	1227	1394
			setupStore	7	4	64	7	6	11
	Webpack	Home	uiStartup	1599	1377	2157	149	1690	1890
			load	1365	1180	1903	135	1448	1605
			domContentLoaded	1364	1179	1902	135	1447	1605
			domInteractive	84	37	382	36	91	128
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	56	7	22	40
			firstReactRender	35	30	52	4	37	42
			getState	13	5	237	31	9	15
			initialActions	1	0	2	1	1	1
			loadScripts	1346	1159	1885	135	1430	1583
			setupStore	10	5	78	11	8	28

Benchmark value 19 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 195 exceeds gate value 24 for firefox browserify home p95 getState
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 171ms
Sum of all benchmark exceeds: 179ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -530 Bytes (-0.01%)
ui: -637 Bytes (-0.01%)
common: 1.21 KiB (0.01%)

metamaskbot · 2025-05-15T20:33:56Z

Builds ready [a31d3c1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1126	1409	56	1266	1327
			load	1061	980	1200	53	1103	1165
			domContentLoaded	1054	961	1191	54	1096	1158
			domInteractive	16	14	31	3	16	25
			firstPaint	742	78	1165	418	1082	1145
			backgroundConnect	8	4	28	5	8	22
			firstReactRender	20	16	41	5	20	36
			getState	16	5	63	9	22	31
			initialActions	0	0	1	0	0	1
			loadScripts	810	723	945	52	846	905
			setupStore	8	5	19	2	8	10
	Webpack	Home	uiStartup	2184	1757	2541	175	2299	2445
			load	1694	1340	2094	152	1776	1966
			domContentLoaded	1686	1337	2091	149	1768	1935
			domInteractive	16	11	60	10	14	46
			firstPaint	164	65	678	78	176	297
			backgroundConnect	31	9	196	25	36	58
			firstReactRender	175	44	428	111	288	335
			getState	14	4	54	9	18	33
			initialActions	3	1	8	1	4	5
			loadScripts	1680	1335	2068	148	1765	1912
			setupStore	24	6	278	35	23	48
Firefox	Browserify	Home	uiStartup	1341	1174	1892	122	1390	1573
			load	1191	1027	1777	117	1245	1427
			domContentLoaded	1191	1026	1777	117	1244	1427
			domInteractive	104	37	273	38	121	170
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	71	8	21	40
			firstReactRender	24	19	63	8	22	51
			getState	9	4	194	19	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1173	1009	1751	116	1223	1406
			setupStore	7	3	65	7	6	16
	Webpack	Home	uiStartup	1545	1347	1941	127	1614	1814
			load	1323	1167	1681	114	1401	1549
			domContentLoaded	1322	1167	1681	114	1401	1548
			domInteractive	84	37	264	32	92	127
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	45	6	23	38
			firstReactRender	34	28	44	4	36	42
			getState	9	4	45	7	9	28
			initialActions	1	0	2	1	1	1
			loadScripts	1304	1152	1662	114	1383	1532
			setupStore	9	5	74	8	9	24

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 4ms
Sum of all benchmark exceeds: 5ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -530 Bytes (-0.01%)
ui: -637 Bytes (-0.01%)
common: 1.21 KiB (0.01%)

ui/components/app/connected-status-indicator/connected-status-indicator.js

ui/components/multichain/connected-status/connected-status.tsx

adonesky1

LGTM!

metamaskbot · 2025-05-20T21:11:33Z

Builds ready [c9937c4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1203 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1203	1074	1457	65	1226	1317
			load	1038	925	1301	61	1067	1142
			domContentLoaded	1030	921	1298	63	1060	1137
			domInteractive	16	13	36	4	16	24
			firstPaint	776	127	1161	385	1045	1132
			backgroundConnect	8	4	29	5	8	24
			firstReactRender	19	15	33	3	20	23
			getState	15	5	104	11	20	27
			initialActions	0	0	3	0	0	1
			loadScripts	791	689	1026	60	815	897
			setupStore	8	5	20	2	8	11
	Webpack	Home	uiStartup	2165	1752	2701	216	2314	2564
			load	1687	1371	2089	150	1786	1959
			domContentLoaded	1680	1366	2070	148	1776	1949
			domInteractive	18	12	235	24	13	48
			firstPaint	169	66	485	63	208	284
			backgroundConnect	23	10	61	10	28	45
			firstReactRender	153	43	371	111	295	356
			getState	12	4	47	7	14	26
			initialActions	6	1	281	28	4	6
			loadScripts	1677	1365	2058	146	1774	1937
			setupStore	38	7	303	74	24	282
Firefox	Browserify	Home	uiStartup	1317	1150	1873	140	1361	1590
			load	1164	1019	1604	115	1213	1404
			domContentLoaded	1163	1019	1603	115	1212	1403
			domInteractive	96	38	456	49	104	151
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	12	190	25	20	83
			firstReactRender	24	20	66	6	23	31
			getState	8	4	36	5	8	14
			initialActions	0	0	1	0	0	1
			loadScripts	1142	1006	1520	109	1192	1375
			setupStore	11	4	212	28	6	37
	Webpack	Home	uiStartup	1503	1292	1958	146	1571	1856
			load	1300	1144	1750	127	1374	1540
			domContentLoaded	1299	1144	1750	127	1374	1539
			domInteractive	76	59	146	16	80	124
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	60	7	23	33
			firstReactRender	37	27	49	4	41	45
			getState	8	4	32	5	9	19
			initialActions	0	0	1	0	1	1
			loadScripts	1281	1124	1729	126	1359	1520
			setupStore	14	5	229	35	8	23

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 39 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2564 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 282 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 83 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Sum of mean exceeds: 12ms | Sum of p95 exceeds: 356ms
Sum of all benchmark exceeds: 368ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -530 Bytes (-0.01%)
ui: -651 Bytes (-0.01%)
common: 1.21 KiB (0.01%)

jiexi added 6 commits April 21, 2025 11:44

delete inlined

ee1d790

use preview build 634cc823

da393fb

replace imports

23612f9

use preview build c76a33e4

b10942f

lint

bb48c8f

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

7f2728b

jiexi requested a review from a team as a code owner April 21, 2025 19:11

metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Apr 21, 2025

fix breaking renames

7e5c734

jiexi added 9 commits April 21, 2025 12:25

fix breaking renames

65be89c

DRY permission page account comparison

ecd2b24

Merge remote-tracking branch 'origin/jl/adopt-sip-26-post-merge-core-…

246bb9d

…refactor' into jl/adopt-sip-26-post-merge-core-refactor

use preview build 90695ddf

c42a9ce

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

86d3492

fix bad import

e0701a0

use preview build 363db98c

bf64354

use preview build 514219da

1c1af1e

use preview build 514219da

e410093

jiexi mentioned this pull request Apr 21, 2025

feat: Add more chain-agnostic-permission utility functions from sip-26 usage MetaMask/core#5609

Merged

jiexi added 2 commits April 21, 2025 14:13

fix renamed import

12c46ab

fix isInternalAccountInPermittedAccountIds called without internalAco…

1e6c8b6

…cunt

fix fixtures

e1efe73

storybook

79a0d1d

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

eaa781d

jiexi changed the title ~~feat: bump @metamask/chain-agnostic-permission to 0.5.0~~ feat: bump @metamask/chain-agnostic-permission to 0.6.0 May 7, 2025

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

8668abf

vinnyhoward previously approved these changes May 15, 2025

View reviewed changes

jiexi added 2 commits May 15, 2025 13:01

lint

7c6c6c1

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

a31d3c1

jiexi dismissed vinnyhoward’s stale review via a31d3c1 May 15, 2025 20:01

adonesky1 reviewed May 15, 2025

View reviewed changes

ui/components/app/connected-status-indicator/connected-status-indicator.js Show resolved Hide resolved

adonesky1 reviewed May 15, 2025

View reviewed changes

ui/components/multichain/connected-status/connected-status.tsx Show resolved Hide resolved

wenfix mentioned this pull request May 20, 2025

test: EIP-5792 methods on Multichain API #33077

Merged

7 tasks

adonesky1 previously approved these changes May 20, 2025

View reviewed changes

Merge branch 'main' into jl/adopt-sip-26-post-merge-core-refactor

c9937c4

jiexi dismissed adonesky1’s stale review via c9937c4 May 20, 2025 20:37

adonesky1 approved these changes May 20, 2025

View reviewed changes

ffmcgee725 approved these changes May 21, 2025

View reviewed changes

matthewwalsh0 approved these changes May 21, 2025

View reviewed changes

NidhiKJha approved these changes May 21, 2025

View reviewed changes

adonesky1 added this pull request to the merge queue May 21, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2025

adonesky1 added this pull request to the merge queue May 21, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2025

HowardBraham added this pull request to the merge queue May 21, 2025

Merged via the queue into main with commit d48277a May 21, 2025
157 checks passed

HowardBraham deleted the jl/adopt-sip-26-post-merge-core-refactor branch May 21, 2025 18:44

github-actions bot locked and limited conversation to collaborators May 21, 2025

metamaskbot added the release-12.20.0 Issue or pull request that will be included in release 12.20.0 label May 21, 2025

Conversation

jiexi commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 21, 2025

Uh oh!

socket-security bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Apr 22, 2025

Uh oh!

metamaskbot commented Apr 22, 2025

Uh oh!

jiexi commented Apr 22, 2025

Uh oh!

metamaskbot commented Apr 22, 2025

Uh oh!

vinnyhoward left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

metamaskbot commented May 15, 2025

Uh oh!

Uh oh!

Uh oh!

adonesky1 left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jiexi commented Apr 21, 2025 •

edited

Loading

socket-security bot commented Apr 21, 2025 •

edited

Loading

metamaskbot commented Apr 21, 2025 •

edited

Loading