enhance, cleanup, rename chain agnostic permission utilities#31748
Merged
enhance, cleanup, rename chain agnostic permission utilities#31748
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
adonesky1
commented
Apr 8, 2025
Contributor
Author
There was a problem hiding this comment.
Previously getAllAccountIdsFromCaip25CaveatValue
adonesky1
commented
Apr 8, 2025
Comment on lines
17
to
31
Contributor
Author
There was a problem hiding this comment.
Previously was:
export function getAllAccountsFromScopesObjects(
scopesObjects: InternalScopesObject[],
): CaipAccountId[] {
return Array.from(
new Set([...scopesObjects.flatMap(getAllAccountsFromScopesObject)]),
);
}
Member
There was a problem hiding this comment.
The main thing that needed to be removed was the two extra uniques, which this does
adonesky1
commented
Apr 8, 2025
Comment on lines
20
to
32
Contributor
Author
There was a problem hiding this comment.
Previously was:
export function getAllScopesFromScopesObjects(
scopesObjects: InternalScopesObject[],
): InternalScopeString[] {
return Array.from(
new Set([...scopesObjects.flatMap(getAllScopesFromScopesObject)]),
);
}
f208507 to
2946089
Compare
2946089 to
cdfb8b3
Compare
Collaborator
Builds ready [cdfb8b3]
UI Startup Metrics (1232 ± 70 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address some concerns about time complexity raised by @FrederikBolding
rename and reorganize these helpers for easier navigation.
I have an open PR against core here where I've made the improvements + name changes that can be reviewed and merged immediately after 12.17.0 cut