chore: remove MMI hooks and upgrade transaction controller by shane-t · Pull Request #31597 · MetaMask/metamask-extension

shane-t · 2025-04-04T10:10:34Z

Description

Upgrades @metamask/transaction-controller to v53.0.0

Also removes the MMI hooks, so that we are no longer dependent on the custodyStatus/custodyId properties from transaction controller, given that they were removed in v53.0.0. MMI is deprecated, so this code is gradually being cleared out.

Related issues

Core PR: MetaMask/core#5045

Manual testing steps

yarn lint will break otherwise

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2025-04-04T10:11:47Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/controller-utils@11.6.0 ➜ 11.7.0	None	`0`	0 B
npm/@metamask/transaction-controller@52.3.0 ➜ 53.0.0	None	`0`	2.71 MB	metamaskbot

View full report↗︎

metamaskbot · 2025-04-04T10:12:21Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

app/scripts/controller-init/confirmations/transaction-controller-init.ts

vinistevam · 2025-04-04T11:07:01Z

Should we keep the ^?

Good idea^^^^^^^^^

matthewwalsh0 · 2025-04-04T11:43:12Z

@metamaskbot update-policies

metamaskbot · 2025-04-04T11:56:12Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

socket-security · 2025-04-04T12:06:28Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

chore: upgrade transaction controller chore: update lavamoat chore: tweak build system lavamoat policy chore: satisfy yarn dedupe chore: unpin transaction-controller version Update LavaMoat policies chore: update lockfile since tx controller version was unpinned chore: update sentry constants chore: update sentry constants chore: update fixture chore: remove file

…ub.com/MetaMask/metamask-extension into remove-mmi-hooks-upgrade-tx-controller

github-actions · 2025-04-07T12:44:44Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-07T13:27:33Z

Builds ready [ea40927]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1238 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1238	1094	1378	58	1287	1330
			load	1085	976	1208	55	1153	993
			domContentLoaded	1079	971	1202	56	1147	987
			domInteractive	17	13	62	7	16	28
			firstPaint	800	130	1208	408	225	986
			backgroundConnect	11	6	79	10	9	10
			firstReactRender	19	14	49	5	20	29
			getState	13	5	44	8	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	825	712	957	56	881	907
			setupStore	7	5	25	3	7	8
	Webpack	Home	uiStartup	2163	1766	2489	188	2295	2410
			load	1705	1358	2070	167	1806	1968
			domContentLoaded	1695	1353	2060	165	1797	1963
			domInteractive	18	13	72	12	15	53
			firstPaint	165	65	361	62	248	84
			backgroundConnect	38	12	415	57	37	64
			firstReactRender	166	55	427	116	66	95
			getState	22	5	311	49	7	9
			initialActions	3	1	7	1	3	5
			loadScripts	1683	1346	2034	159	1790	1930
			setupStore	29	7	317	60	7	9
Firefox	Browserify	Home	uiStartup	1384	1214	1947	168	1428	1793
			load	1244	1070	1808	162	1293	1626
			domContentLoaded	1244	1069	1808	162	1293	1626
			domInteractive	101	42	190	27	89	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	109	12	24	47
			firstReactRender	22	19	53	4	22	28
			getState	7	3	13	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1220	1038	1775	159	1272	1600
			setupStore	6	4	31	3	6	7
	Webpack	Home	uiStartup	1598	1403	2180	151	1669	1926
			load	1376	1200	1890	143	1452	1677
			domContentLoaded	1375	1200	1889	143	1452	1676
			domInteractive	101	38	219	25	89	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	20	50	7	30	44
			firstReactRender	38	29	58	6	43	50
			getState	11	5	32	7	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1351	1178	1863	143	1425	1649
			setupStore	9	5	60	7	8	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 1.9 KiB (0.02%)

metamaskbot · 2025-04-07T14:06:44Z

Builds ready [a113d06]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1092	1405	64	1258	1383
			load	1065	921	1252	66	1145	991
			domContentLoaded	1059	915	1247	66	1201	987
			domInteractive	17	13	61	6	16	30
			firstPaint	730	125	1253	421	228	966
			backgroundConnect	10	7	27	3	9	10
			firstReactRender	20	14	53	7	19	35
			getState	13	5	48	8	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	808	669	989	64	842	965
			setupStore	8	4	24	3	7	9
	Webpack	Home	uiStartup	2165	1690	2538	195	2294	2414
			load	1706	1328	2078	169	1790	2015
			domContentLoaded	1700	1323	2068	167	1785	2007
			domInteractive	17	12	62	11	14	57
			firstPaint	169	67	436	72	252	81
			backgroundConnect	31	12	235	24	36	56
			firstReactRender	195	53	392	118	58	94
			getState	12	4	55	8	8	9
			initialActions	3	1	7	1	4	6
			loadScripts	1689	1317	2035	161	1779	1973
			setupStore	17	6	44	9	39	9
Firefox	Browserify	Home	uiStartup	1447	1234	1879	155	1501	1844
			load	1291	1087	1729	151	1359	1654
			domContentLoaded	1290	1087	1729	151	1358	1654
			domInteractive	111	42	364	47	89	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	17	70	10	28	52
			firstReactRender	24	20	63	5	24	31
			getState	10	4	182	18	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1264	1066	1704	151	1320	1626
			setupStore	7	4	23	3	6	8
	Webpack	Home	uiStartup	1511	1353	2106	161	1536	1921
			load	1305	1149	1874	150	1339	1676
			domContentLoaded	1305	1149	1874	150	1339	1676
			domInteractive	92	38	158	18	90	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	18	55	6	26	42
			firstReactRender	35	28	58	5	37	46
			getState	8	3	35	5	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1282	1130	1851	149	1316	1651
			setupStore	8	5	30	4	7	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 1.9 KiB (0.02%)

metamaskbot · 2025-04-07T16:30:16Z

Builds ready [68148fd]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1102	1436	55	1257	1329
			load	1074	981	1235	49	1113	991
			domContentLoaded	1067	975	1229	49	1110	993
			domInteractive	17	13	56	7	16	31
			firstPaint	770	89	1183	418	213	282
			backgroundConnect	10	7	38	4	9	10
			firstReactRender	19	14	43	5	20	31
			getState	13	4	33	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	815	727	952	46	845	894
			setupStore	8	5	15	2	7	9
	Webpack	Home	uiStartup	2217	1744	2670	191	2349	2573
			load	1734	1332	2230	165	1814	2021
			domContentLoaded	1728	1327	2225	163	1809	2006
			domInteractive	17	13	80	12	14	53
			firstPaint	165	68	524	67	249	83
			backgroundConnect	36	11	401	40	41	72
			firstReactRender	203	55	417	113	56	93
			getState	14	4	34	7	5	9
			initialActions	3	1	7	1	4	5
			loadScripts	1715	1318	2220	164	1801	1978
			setupStore	22	7	218	22	33	7
Firefox	Browserify	Home	uiStartup	1411	1219	1952	166	1471	1848
			load	1266	1074	1789	161	1325	1686
			domContentLoaded	1266	1074	1789	161	1325	1686
			domInteractive	104	39	286	39	88	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	63	8	26	45
			firstReactRender	23	19	41	4	24	31
			getState	7	4	14	2	8	8
			initialActions	0	0	1	0	0	1
			loadScripts	1242	1056	1760	160	1299	1665
			setupStore	6	4	25	3	6	7
	Webpack	Home	uiStartup	1536	1317	1984	157	1637	1877
			load	1323	1144	1761	147	1403	1655
			domContentLoaded	1322	1144	1760	147	1402	1654
			domInteractive	94	45	252	24	91	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	80	8	26	46
			firstReactRender	36	30	62	6	38	49
			getState	9	4	46	6	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1300	1125	1738	146	1381	1628
			setupStore	7	5	30	3	8	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 1.9 KiB (0.02%)

metamaskbot added the team-identity-deprecated DEPRECATED: team no longer exists label Apr 4, 2025

shane-t marked this pull request as ready for review April 4, 2025 10:12

shane-t requested a review from a team as a code owner April 4, 2025 10:12

matthewwalsh0 previously approved these changes Apr 4, 2025

View reviewed changes

shane-t dismissed matthewwalsh0’s stale review via 65e9335 April 4, 2025 10:52

shane-t requested review from a team as code owners April 4, 2025 10:52

vinistevam reviewed Apr 4, 2025

View reviewed changes

vinistevam previously approved these changes Apr 4, 2025

View reviewed changes

shane-t dismissed vinistevam’s stale review via ad8c028 April 4, 2025 13:44

shane-t force-pushed the remove-mmi-hooks-upgrade-tx-controller branch from 8bc12a9 to cc8a217 Compare April 5, 2025 01:36

shane-t and others added 6 commits April 7, 2025 10:02

chore: mask properties

deb4262

Merge branch 'main' into remove-mmi-hooks-upgrade-tx-controller

3145511

Merge branch 'main' into remove-mmi-hooks-upgrade-tx-controller

62b409a

Merge branch 'main' into remove-mmi-hooks-upgrade-tx-controller

332e7ca

fix: php mocking conversion

09bccdd

Merge branch 'remove-mmi-hooks-upgrade-tx-controller' of https://gith…

f7fa162

…ub.com/MetaMask/metamask-extension into remove-mmi-hooks-upgrade-tx-controller

fix mock cryptocompare

ea40927

Merge branch 'main' into remove-mmi-hooks-upgrade-tx-controller

a113d06

Merge branch 'main' into remove-mmi-hooks-upgrade-tx-controller

68148fd

shane-t requested review from matthewwalsh0 and vinistevam April 7, 2025 17:42

matthewwalsh0 approved these changes Apr 7, 2025

View reviewed changes

vinistevam approved these changes Apr 8, 2025

View reviewed changes

matthewwalsh0 added this pull request to the merge queue Apr 8, 2025

Merged via the queue into main with commit ac9c6f5 Apr 8, 2025

matthewwalsh0 deleted the remove-mmi-hooks-upgrade-tx-controller branch April 8, 2025 10:12

github-actions Bot locked and limited conversation to collaborators Apr 8, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove MMI hooks and upgrade transaction controller#31597

chore: remove MMI hooks and upgrade transaction controller#31597
matthewwalsh0 merged 10 commits into
mainfrom
remove-mmi-hooks-upgrade-tx-controller

shane-t commented Apr 4, 2025 •

edited

Loading

Uh oh!

socket-security Bot commented Apr 4, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 4, 2025 •

edited

Loading

Uh oh!

vinistevam Apr 4, 2025

Uh oh!

shane-t Apr 4, 2025

Uh oh!

shane-t Apr 4, 2025

Uh oh!

matthewwalsh0 commented Apr 4, 2025

Uh oh!

metamaskbot commented Apr 4, 2025

Uh oh!

socket-security Bot commented Apr 4, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

metamaskbot commented Apr 7, 2025

Uh oh!

metamaskbot commented Apr 7, 2025

Uh oh!

metamaskbot commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

shane-t commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security Bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

vinistevam Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

shane-t Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

shane-t Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

matthewwalsh0 commented Apr 4, 2025

Uh oh!

metamaskbot commented Apr 4, 2025

Uh oh!

socket-security Bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

metamaskbot commented Apr 7, 2025

Uh oh!

metamaskbot commented Apr 7, 2025

Uh oh!

metamaskbot commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shane-t commented Apr 4, 2025 •

edited

Loading

socket-security Bot commented Apr 4, 2025 •

edited

Loading

metamaskbot commented Apr 4, 2025 •

edited

Loading

socket-security Bot commented Apr 4, 2025 •

edited

Loading