Skip to content

fix: 31004 upgrade @metamask/eth-ledger-bridge-keyring library to fix the sign transaction issue.#31109

Merged
vivek-consensys merged 4 commits intomainfrom
fix/31004-ledger-sign-transaction-broken
Mar 25, 2025
Merged

fix: 31004 upgrade @metamask/eth-ledger-bridge-keyring library to fix the sign transaction issue.#31109
vivek-consensys merged 4 commits intomainfrom
fix/31004-ledger-sign-transaction-broken

Conversation

@dawnseeker8
Copy link
Copy Markdown
Contributor

@dawnseeker8 dawnseeker8 commented Mar 19, 2025 •
edited
Loading

Description

This PR will upgrade @metamask/eth-ledger-bridge-keyring library to fix the sign transaction issue.

Open in GitHub Codespaces

Related issues

Fixes: #31004

Manual testing steps

Need a full regression tests on ledger feature. Remember to change the network fee if you saw a alert.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead label Mar 19, 2025
@dawnseeker8 dawnseeker8 added team-accounts-framework Accounts team needs-qa Label will automate into QA workspace labels Mar 19, 2025
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 19, 2025 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 19, 2025

Builds ready [cedc129]
Page Load Metrics (2880 ± 942 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1722999327601952937
domContentLoaded1604965725561910917
load17411015228801962942
domInteractive272162159462222
backgroundConnect99919335226108
firstReactRender20188864522
getState3038816311455
initialActions01000
loadScripts1170802718861577757
setupStore8293847838
uiStartup212012501419623211114
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 18 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@dawnseeker8 dawnseeker8 mentioned this pull request Mar 20, 2025
Closed
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 21, 2025

Builds ready [0daf1de]
Page Load Metrics (2760 ± 988 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15911081825691972947
domContentLoaded15111031123251881903
load16031117127602057988
domInteractive245028011254
backgroundConnect901129397291140
firstReactRender223681129345
getState2571823019393
initialActions01000
loadScripts1079933117331765847
setupStore1258116216579
uiStartup195012448484030491464
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 18 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@dawnseeker8 dawnseeker8 mentioned this pull request Mar 21, 2025
Closed
@dawnseeker8 dawnseeker8 marked this pull request as ready for review March 24, 2025 09:15
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 24, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-ledger-bridge-keyring@10.0.0 ➜ 11.0.0 None 0 322 kB metamaskbot

View full report↗︎

@dawnseeker8 dawnseeker8 removed the needs-qa Label will automate into QA workspace label Mar 24, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 24, 2025
@angelcheung22 angelcheung22 reopened this Mar 24, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 24, 2025

Builds ready [02d877d]
Page Load Metrics (3424 ± 1547 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30115203271629531418
domContentLoaded154114476297530201450
load163815641342432231547
domInteractive24400749244
backgroundConnect1121174466313150
firstReactRender44178964019
getState421173240269129
initialActions01000
loadScripts111113126221527211307
setupStore173501239646
uiStartup229618139639145162168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 30 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 24, 2025
@vivek-consensys vivek-consensys added QA Passed release-blocker This bug is blocking the next release regression-RC-12.15.0 Regression bug that was found in release candidate (RC) for release 12.15.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Mar 24, 2025
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 25, 2025
@vivek-consensys vivek-consensys added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 17ce01e Mar 25, 2025
3 checks passed
@vivek-consensys vivek-consensys deleted the fix/31004-ledger-sign-transaction-broken branch March 25, 2025 12:32
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 25, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Akaryatrh Akaryatrh Akaryatrh approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

No one assigned

Labels

QA Passed regression-RC-12.15.0 Regression bug that was found in release candidate (RC) for release 12.15.0 release-12.16.0 Issue or pull request that will be included in release 12.16.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts-framework Accounts team team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Ledger ] Transactions are all failing in main

6 participants

@dawnseeker8 @metamaskbot @Akaryatrh @gantunesr @angelcheung22 @vivek-consensys