Skip to content

Additions to the UseStorageLocalInstead branch#3079

Merged
danfinlay merged 3 commits intoi3076-UseStorageLocalInsteadfrom
i3076-UseStorageLocalInstead-danjm-1
Jan 24, 2018
Merged

Additions to the UseStorageLocalInstead branch#3079
danfinlay merged 3 commits intoi3076-UseStorageLocalInsteadfrom
i3076-UseStorageLocalInstead-danjm-1

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Jan 24, 2018

@danfinlay This PR is off of your branch: https://github.com/MetaMask/metamask-extension/tree/i3076-UseStorageLocalInstead

I've made three changes:

  • error handling in place of the TODO comments you had in background.js
  • adds some null-safe property checks to the attempts to access the storage property in extension-store.js
  • completes the tests you outlined for extensions-store-test.js

Feel free to accept or reject changes as is useful to you.

@danfinlay danfinlay merged commit 84dfb19 into i3076-UseStorageLocalInstead Jan 24, 2018
@danfinlay danfinlay deleted the i3076-UseStorageLocalInstead-danjm-1 branch January 24, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants