Skip to content

chore: add @metamask/multichain-network-controller#30309

Closed
gantunesr wants to merge 60 commits intomainfrom
chore/add-mc-network-controller
Closed

chore: add @metamask/multichain-network-controller#30309
gantunesr wants to merge 60 commits intomainfrom
chore/add-mc-network-controller

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Feb 13, 2025 •
edited
Loading

Description

Adds a new controller to manage non-EVM networks (@metamask/multichain-network-controller).

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/810

Manual testing steps

  1. Unlock the wallet
  2. Select different network and verify that the behaviour has not changed
  3. Add a new couple of networks and verify that the behaviour has not changed

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Feb 13, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 14, 2025 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/accounts-controller@24.0.0 🔁 npm/@metamask/accounts-controller@23.0.1 None +1 1.08 MB metamaskbot
npm/@metamask/multichain-network-controller@0.1.0 None 0 110 kB metamaskbot
npm/@solana/addresses@2.0.0 🔁 npm/@solana/addresses@2.0.0-rc.4 None 0 198 kB lorisleiva
npm/@solana/assertions@2.0.0 🔁 npm/@solana/assertions@2.0.0-rc.4 None 0 51.4 kB lorisleiva
npm/@solana/codecs-core@2.0.0 🔁 npm/@solana/codecs-core@2.0.0-rc.4 None 0 495 kB lorisleiva
npm/@solana/codecs-numbers@2.0.0 🔁 npm/@solana/codecs-numbers@2.0.0-rc.4 None 0 246 kB lorisleiva
npm/@solana/codecs-strings@2.0.0 🔁 npm/@solana/codecs-strings@2.0.0-rc.4 None 0 208 kB lorisleiva
npm/@solana/errors@2.0.0 🔁 npm/@solana/errors@2.0.0-rc.4 None +1 1.39 MB lorisleiva

🚮 Removed packages: npm/@metamask/network-controller@22.1.1

View full report↗︎

@gantunesr
Copy link
Copy Markdown
Member Author

gantunesr commented Feb 14, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 14, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@gantunesr gantunesr marked this pull request as ready for review February 17, 2025 11:13
@gantunesr gantunesr requested review from a team as code owners February 17, 2025 11:13
@gantunesr gantunesr requested a review from a team as a code owner February 18, 2025 17:33
ccharly
ccharly reviewed Feb 18, 2025
View reviewed changes
test/data/mock-accounts.ts Outdated
},
};

export const MOCK_ACCOUNT_SOLANA_MAINNET: InternalAccount = {
Copy link
Copy Markdown
Contributor

@ccharly ccharly Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about removing the _MAINNET suffix here? This would match the "Bitcoin mainnet" account that has no prefix.

We should probably add it to the MOCK_ACCOUNTS map too?

Copy link
Copy Markdown
Member Author

@gantunesr gantunesr Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the name here 8a4f878. I haven't checked but some tests may break if I add it to MOCK_ACCOUNTS

gantunesr and others added 17 commits February 18, 2025 15:26
@gantunesr
Merge branch 'main' into chore/add-mc-network-controller
99238f5
@gantunesr
test: update mock name
8a4f878
@gantunesr
Merge branch 'chore/add-mc-network-controller' of https://github.com/…
a13ab7f 
…MetaMask/metamask-extension into chore/add-mc-network-controller
@gantunesr @ccharly
chore: update ui/selectors/multichain/networks.ts
1e9a317 
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@gantunesr
Merge branch 'main' into chore/add-mc-network-controller
45d13bd
@gantunesr
chroe: bump accounts, user-operation, and transaction controllers
4be5925
@gantunesr
fix: type error
9d3b2d6
@gantunesr
chore: remove ts directives
e112357
@gantunesr
chore: revert transaction and user-op controllers
a2465a2
@gantunesr
chore: pin transaction-controller version to 45.0.0
5cb7014
@gantunesr
Revert "chore: remove ts directives". This reverts commit e112357.
1302fd7
@metamaskbot
Update LavaMoat policies
782aad6
@gantunesr
Merge branch 'main' of https://github.com/MetaMask/metamask-extension …
c65c3ec 
…into chore/add-mc-network-controller
@gantunesr
Merge branch 'chore/bump-controllers' of https://github.com/MetaMask/…
1f233e9 
…metamask-extension into chore/add-mc-network-controller
@gantunesr
chore: update policies
ba11535
@gantunesr
Merge branch 'chore/add-mc-network-controller' of https://github.com/…
bb5bc25 
…MetaMask/metamask-extension into chore/add-mc-network-controller
@gantunesr
chore: lint
69c93b4
@gantunesr
Copy link
Copy Markdown
Member Author

gantunesr commented Feb 19, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 19, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 19, 2025

Builds ready [bfbaeeb]
Page Load Metrics (1852 ± 106 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41223261779382183
domContentLoaded149822561829213102
load153122611852221106
domInteractive16170433115
backgroundConnect88023199
firstReactRender1576442412
getState55612115
initialActions01000
loadScripts10831829135519191
setupStore876192010
uiStartup172324692103231111
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 229.62 KiB (3.85%)
  • ui: 0 Bytes (0.00%)
  • common: 496 Bytes (0.01%)

@ccharly ccharly mentioned this pull request Feb 19, 2025
Merged
7 tasks
@gantunesr
Copy link
Copy Markdown
Member Author

gantunesr commented Feb 19, 2025

Closed in favor of https://github.com/MetaMask/accounts-planning/issues/810

@gantunesr gantunesr closed this Feb 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@HowardBraham HowardBraham deleted the chore/add-mc-network-controller branch January 19, 2026 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ccharly ccharly ccharly left review comments

Assignees

No one assigned

Labels

team-accounts-framework Accounts team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gantunesr @metamaskbot @ccharly