Skip to content

Jl/caip multichain/flask#29003

Merged
adonesky1 merged 11 commits intojl/caip-multichain-migrate-corefrom
jl/caip-multichain/flask
Dec 13, 2024
Merged

Jl/caip multichain/flask#29003
adonesky1 merged 11 commits intojl/caip-multichain-migrate-corefrom
jl/caip-multichain/flask

Conversation

@jiexi
Copy link
Copy Markdown
Member

@jiexi jiexi commented Dec 6, 2024 •
edited by github-actions bot
Loading

Description

Remove BARAD_DUR env var and move into Flask code fence

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Dec 6, 2024
@jiexi jiexi mentioned this pull request Dec 6, 2024
Merged
7 tasks
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 6, 2024

Builds ready [64dca1f]
Page Load Metrics (1834 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36321101765337162
domContentLoaded1654208618109646
load1679211018349546
domInteractive25100392010
backgroundConnect981272110
firstReactRender15351952
getState751761172211
initialActions01000
loadScripts1202165613909345
setupStore611811
uiStartup19012384208911053
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 30.4 KiB (0.58%)
  • ui: 590 Bytes (0.01%)
  • common: 458.84 KiB (5.70%)

@jiexi
Copy link
Copy Markdown
Member Author

jiexi commented Dec 9, 2024 •
edited
Loading

TODO: I should code fence some of the imports

Codefenced more multichain code ca905a0

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 10, 2024

Builds ready [e5fc274]
Page Load Metrics (1693 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14621840169410149
domContentLoaded1456178016669646
load1463183816939847
domInteractive23482963
backgroundConnect87426188
firstReactRender14401873
getState64138112178
initialActions01000
loadScripts1065137612559546
setupStore617821
uiStartup17032093192611254
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13.39 KiB (0.25%)
  • ui: 590 Bytes (0.01%)
  • common: 459.06 KiB (5.70%)

adonesky1
adonesky1 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@adonesky1 adonesky1 marked this pull request as ready for review December 13, 2024 14:42
@adonesky1 adonesky1 requested a review from a team as a code owner December 13, 2024 14:42
@adonesky1 adonesky1 merged commit c6ab79e into jl/caip-multichain-migrate-core Dec 13, 2024
@adonesky1 adonesky1 deleted the jl/caip-multichain/flask branch December 13, 2024 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees

No one assigned

Labels

team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiexi @metamaskbot @adonesky1