chore: bump keyring-api to ^10.1.0 + eth-snap-keyring to ^5.0.1#28545
Merged
chore: bump keyring-api to ^10.1.0 + eth-snap-keyring to ^5.0.1#28545
keyring-api to ^10.1.0 + eth-snap-keyring to ^5.0.1#28545Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/accounts-controller@18.2.2, npm/@metamask/notification-services-controller@0.11.0, npm/@metamask/profile-sync-controller@1.0.2, npm/@metamask/signature-controller@21.1.0, npm/webextension-polyfill@0.10.0 |
keyring-api to ^9.0.0 + eth-snap-keyring to ^5.0.1keyring-api to ^10.1.0 + eth-snap-keyring to ^5.0.1
d0ccb76 to
8401814
Compare
Collaborator
Builds ready [e9da8e3]
Page Load Metrics (2072 ± 106 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
zone-live
approved these changes
Nov 22, 2024
Prithpal-Sooriya
approved these changes
Nov 22, 2024
Contributor
Prithpal-Sooriya
left a comment
There was a problem hiding this comment.
LGTM for notifications and identity teams
salimtb
approved these changes
Nov 22, 2024
pedronfigueiredo
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the
keyring-apiand Snap keyring alongside other controllers that depend on those versions too.Some controllers from this release were left out from this PR mainly because the current major version being used in the extension is not updated yet.
The current included controllers do have a peer dependency to either the
keyring-controlleror theaccounts-controllerwhich is why they are being included in this PR.Related issues
Manual testing steps
N/A
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist