chore: adds Solana support for the account overview by zone-live · Pull Request #28411 · MetaMask/metamask-extension

zone-live · 2024-11-11T15:42:07Z

Description

We added support for the Solana account overview. Now when we select a Solana address the user will be able to see its details in the home view.
Also since the overview is the same for SOL and BTC, in order to not repeat components, we've renamed as "non-evm" the existing BTC ones, and reused them.

Related issues

Fixes:

Manual testing steps

As of right now, manually testing is a bit complex, it needs to run the snap manually and the extension, since we 1st need to publish a new release to npm with more up to date work. The snap version we have in npm is outdated and won't support this flow. That said, if you want to go ahead and run locally the steps are the following:

Clone the Solana Snap monorepo and run it locally with yarn and then yarn start
In the extension, at this branch, apply the following changes and run the extension as flask:

At builds.yml add the solana feature to the flask build:
 
     features:
       - build-flask
       - keyring-snaps
+      - solana

At shared/lib/accounts/solana-wallet-snap.ts point the snap ID to the snap localhost:

-export const SOLANA_WALLET_SNAP_ID: SnapId = SolanaWalletSnap.snapId as SnapId;
+//export const SOLANA_WALLET_SNAP_ID: SnapId = SolanaWalletSnap.snapId as SnapId;
+export const SOLANA_WALLET_SNAP_ID: SnapId = "local:http://localhost:8080/";

Manually install the snap via the snap dapp at http://localhost:3000
Enable the Solana account via Settings > Experimental > Enable Solana account
Create a Solana account from the account-list menu and see the account overview of it

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-11T15:42:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

zone-live · 2024-11-12T14:06:38Z

@metamaskbot update-policies

metamaskbot · 2024-11-12T14:18:15Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2024-11-13T11:23:50Z

Builds ready [9d4e4f2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2087 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	280	2562	1818	660	317
		domContentLoaded	1725	2506	2054	199	95
		load	1739	2563	2087	202	97
		domInteractive	26	87	51	17	8
		backgroundConnect	7	86	33	27	13
		firstReactRender	66	390	128	73	35
		getState	5	63	26	21	10
		initialActions	0	1	0	0	0
		loadScripts	1240	1996	1522	196	94
		setupStore	5	57	15	17	8
		uiStartup	1932	2828	2351	247	119

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 19.01 KiB (0.31%)
ui: 622 Bytes (0.01%)
common: 907 Bytes (0.01%)

metamaskbot · 2024-11-25T14:52:34Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

package.json

test/e2e/flask/create-watch-account.spec.ts

test/e2e/tests/privacy/basic-functionality.spec.js

yarn.lock

.yarn/patches/@metamask-assets-controllers-npm-43.1.0-253de35116.patch

ccharly · 2024-11-25T14:44:29Z

app/scripts/lib/accounts/BalancesController.ts

+    const updateTimes = {
+      [BtcAccountType.P2wpkh]: BTC_AVG_BLOCK_TIME,
+      [SolAccountType.DataAccount]: SOLANA_AVG_BLOCK_TIME,
+    };

-    this.#tracker.track(account.id, BTC_AVG_BLOCK_TIME);
-    // NOTE: Unfortunately, we cannot update the balance right away here, because
+    const updateTime =
+      updateTimes[account.type as keyof typeof updateTimes] ||
+      SOLANA_AVG_BLOCK_TIME;
+    this.#tracker.track(account.id, updateTime); // NOTE: Unfortunately, we cannot update the balance right away here, because


Good catch, but actually it should uses the same values, at least for Bitcoin. Since the block time is much higher, we use this "trick" to wait blockTime / 2 to minimize the downtime.

So actually this was an error 😅

Could you re-use #getBlockTimeFor here too then? (that does not change anything for Solana block time anyway).

shared/constants/multichain/assets.ts

app/scripts/lib/accounts/BalancesController.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

zone-live · 2024-11-25T15:22:45Z

@metamaskbot update-policies

metamaskbot · 2024-11-25T15:35:53Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

…ask/metamask-extension into SOL-2-view-solana-account-overview

metamaskbot · 2024-11-25T16:39:54Z

Builds ready [6875fa2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2084 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	323	2509	1990	438	210
		domContentLoaded	1640	2442	2041	192	92
		load	1652	2511	2084	216	104
		domInteractive	25	195	51	36	17
		backgroundConnect	9	151	40	39	19
		firstReactRender	89	316	167	83	40
		getState	4	89	24	25	12
		initialActions	0	1	0	0	0
		loadScripts	1183	1849	1523	159	77
		setupStore	6	84	22	23	11
		uiStartup	1955	3095	2421	308	148

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 900 Bytes (0.01%)
ui: 370 Bytes (0.00%)
common: 806 Bytes (0.01%)

app/scripts/lib/accounts/BalancesController.ts

ui/selectors/multichain.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

metamaskbot · 2024-11-25T18:01:16Z

Builds ready [785b0a1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2236 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	250	2678	2135	467	224
		domContentLoaded	1898	2573	2187	160	77
		load	1963	2688	2236	177	85
		domInteractive	26	194	51	38	18
		backgroundConnect	15	112	49	28	14
		firstReactRender	58	289	128	50	24
		getState	7	89	28	22	11
		initialActions	0	1	0	0	0
		loadScripts	1364	1895	1630	139	67
		setupStore	6	56	16	16	7
		uiStartup	2120	3209	2507	258	124

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 900 Bytes (0.01%)
ui: 370 Bytes (0.00%)
common: 806 Bytes (0.01%)

ccharly

LGTM and manually tested as well:

aganglada · 2024-11-26T13:14:06Z

Tested manually as well. Works for me

chore: adds SOL support

73c498f

zone-live added the team-networks PRs from the Networks team label Nov 11, 2024

Morhef approved these changes Nov 11, 2024

View reviewed changes

zone-live added 5 commits November 12, 2024 09:22

chore: prettier run

dd6fcbf

chore: clean up

8a51986

chore: adds comment and btc check for now

a56008b

chore: updates packages version to support Solana

f503046

Merge branch 'develop' into SOL-2-view-solana-account-overview

3684963

Update LavaMoat policies

3cbd887

zone-live added 11 commits November 12, 2024 14:41

chore: update enum value

6248ba5

chore: undo

97c7198

chore: improvements

b0dd1c6

chore: prettier

e40f75c

chore: undo change

1a81480

chore: test update for balancesController

d7da72a

chore: prettier

7743068

chore: import order, lint

7daa2ac

chore: test update

e6e8485

chore: test update

9142284

Merge branch 'develop' into SOL-2-view-solana-account-overview

9d4e4f2

zone-live marked this pull request as ready for review November 13, 2024 13:10

zone-live requested review from a team as code owners November 13, 2024 13:10

zone-live changed the title ~~chore: adds SOL support~~ chore: adds Solana support for the account overview Nov 13, 2024

chore: updates the metamask/assets-controllers package

3a16d1c

metamaskbot dismissed aganglada’s stale review via bb86bfd November 25, 2024 14:52

ccharly requested changes Nov 25, 2024

View reviewed changes

zone-live and others added 2 commits November 25, 2024 14:58

Update test/e2e/flask/create-watch-account.spec.ts

6ae3f91

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

chore: review update

f4bb0e3

Update LavaMoat policies

f0bc3fe

zone-live added 2 commits November 25, 2024 16:05

chore: clean up

865a95e

Merge branch 'SOL-2-view-solana-account-overview' of github.com:MetaM…

6875fa2

…ask/metamask-extension into SOL-2-view-solana-account-overview

zone-live requested review from aganglada and ccharly November 25, 2024 16:07

ccharly reviewed Nov 25, 2024

View reviewed changes

app/scripts/lib/accounts/BalancesController.ts Show resolved Hide resolved

ui/selectors/multichain.ts Show resolved Hide resolved

zone-live and others added 2 commits November 25, 2024 17:28

Update app/scripts/lib/accounts/BalancesController.ts

143b921

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

Update ui/selectors/multichain.ts

785b0a1

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

zone-live requested a review from ccharly November 25, 2024 17:58

ccharly approved these changes Nov 26, 2024

View reviewed changes

aganglada approved these changes Nov 26, 2024

View reviewed changes

darkwing approved these changes Nov 26, 2024

View reviewed changes

zone-live added this pull request to the merge queue Nov 26, 2024

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 26, 2024

zone-live added this pull request to the merge queue Nov 26, 2024

Merged via the queue into develop with commit be2b439 Nov 26, 2024

zone-live deleted the SOL-2-view-solana-account-overview branch November 26, 2024 16:51

github-actions bot locked and limited conversation to collaborators Nov 26, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024

Conversation

zone-live commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 11, 2024

Uh oh!

zone-live commented Nov 12, 2024

Uh oh!

metamaskbot commented Nov 12, 2024

Uh oh!

metamaskbot commented Nov 13, 2024

Uh oh!

metamaskbot commented Nov 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccharly Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zone-live commented Nov 25, 2024

Uh oh!

metamaskbot commented Nov 25, 2024

Uh oh!

metamaskbot commented Nov 25, 2024

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 25, 2024

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

aganglada commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zone-live commented Nov 11, 2024 •

edited

Loading

aganglada commented Nov 26, 2024 •

edited

Loading