fix: bump @metamask/queued-request-controller with patch fix#28355
Merged
fix: bump @metamask/queued-request-controller with patch fix#28355
@metamask/queued-request-controller with patch fix#28355Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@metamask/queued-request-controller with patch fix
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/queued-request-controller@7.0.0 |
Collaborator
Builds ready [f080630]
Page Load Metrics (2030 ± 117 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
FrederikBolding
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps version of QueuedRequestController, with a patch that fixes an issue where
QueuedRequestController.state.queuedRequestCountis not updated after flushing requests for an originReferences
QueuedRequestControllerfor requests that can switch the network without prompting user approval core#4846QueuedRequestControllerfrom^2.0.0to^7.0.0#28090Fixes
Fixes #28358
Slack discussion in v12.7.0 RC Thread
Before
https://drive.google.com/file/d/1ujdQgVLlT8KlwRwO-Cc3XvRHPrkpxIg_/view?usp=drive_link
After
Screen.Recording.2024-11-06.at.3.41.05.PM.mov
Manual testing steps
On a dapp permissioned for chain A and B, on chain A, queue up one send transaction, then use wallet_switchEthereumChain to switch to chain B, then queue up several more send transactions. Reject/approve the first transaction. Afterwards, you should see chain B as the active chain for the dapp, and all subsequent approvals cleared/rejected automatically.
Pre-merge reviewer checklist