Skip to content

chore: Cherry pick data deletion into v12.6.0#28223

Merged
danjm merged 1 commit intoVersion-v12.6.0from
cherry-pick-data-deletion-v12.6.0
Oct 31, 2024
Merged

chore: Cherry pick data deletion into v12.6.0#28223
danjm merged 1 commit intoVersion-v12.6.0from
cherry-pick-data-deletion-v12.6.0

Conversation

@hjetpoluru
Copy link
Copy Markdown
Contributor

@hjetpoluru hjetpoluru commented Oct 31, 2024

Description

Cherry-pick PR #28221

Open in GitHub Codespaces

## **Description**

The "Delete MetaMetrics Data" e2e tests were recently broken due to a
change in CI configuration. The code-under-test was written to always
use the environment variable present for the data deletion source ID and
endpoint, but the e2e tests wrongly assumed that it would never be
present.

The service has been updated to use the fallback values for e2e test
builds, even if the environment variable is present.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28221?quickstart=1)

## **Related issues**

Fixes CI failure currently on all branches (e.g.
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/108823/workflows/cbc57b89-8647-4219-b413-24df4fdad95c/jobs/4070258
)

This bug was introduced in #24503, but only began causing failures
recently when CI configuration was updated with these new environment
variables.

## **Manual testing steps**

See that the data deletion e2e tests succeed even with both data
deletion environment variables set.

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@hjetpoluru hjetpoluru added extension-delivery INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 31, 2024
@hjetpoluru hjetpoluru self-assigned this Oct 31, 2024
@hjetpoluru hjetpoluru requested a review from a team as a code owner October 31, 2024 15:41
@github-actions github-actions bot added the team-extension-platform Extension Platform team label Oct 31, 2024
@danjm danjm merged commit eb9a2ed into Version-v12.6.0 Oct 31, 2024
@danjm danjm deleted the cherry-pick-data-deletion-v12.6.0 branch October 31, 2024 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 31, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.6.0 on PR, as PR was cherry-picked in branch 12.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

extension-delivery INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants