Skip to content

feat: Add re-simulation logic#28104

Merged
OGPoyraz merged 41 commits intodevelopfrom
3380-simulation-retrigger
Oct 30, 2024
Merged

feat: Add re-simulation logic#28104
OGPoyraz merged 41 commits intodevelopfrom
3380-simulation-retrigger

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Oct 25, 2024 •
edited
Loading

Description

This PR aims to add re-simulation logic which recently added at MetaMask/core#4792

Patch note:
Transaction controller patch adds the re-simulate feature, branched belove to keep track.
https://github.com/MetaMask/core/tree/patch/extension-transaction-controller-37-2-0

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3380

Manual testing steps

TBD

Screenshots/Recordings

Before

After

1
2

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners October 25, 2024 11:09
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 25, 2024
@OGPoyraz OGPoyraz changed the base branch from develop to Version-v12.5.1 October 25, 2024 11:46
@OGPoyraz OGPoyraz requested review from a team and kumavis as code owners October 25, 2024 11:46
@OGPoyraz OGPoyraz changed the base branch from Version-v12.5.1 to develop October 25, 2024 11:46
@OGPoyraz OGPoyraz removed request for a team and kumavis October 25, 2024 11:47
@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 29, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/base-controller@7.0.2 None +1 1.06 MB metamaskbot

🚮 Removed packages: npm/@metamask/base-controller@7.0.1

View full report↗︎

@OGPoyraz OGPoyraz force-pushed the 3380-simulation-retrigger branch from ee81c0d to 1713489 Compare October 29, 2024 15:28
@OGPoyraz
Copy link
Copy Markdown
Member Author

OGPoyraz commented Oct 29, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 29, 2024

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 29, 2024
View reviewed changes
sleepytanya
sleepytanya previously approved these changes Oct 29, 2024
View reviewed changes
@OGPoyraz OGPoyraz dismissed stale reviews from sleepytanya and matthewwalsh0 via 097d33b October 29, 2024 17:35
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 29, 2024

Builds ready [097d33b]
Page Load Metrics (1862 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16982236187114268
domContentLoaded16882176183613666
load16982239186213967
domInteractive17222514220
backgroundConnect106226199
firstReactRender492951035526
getState469202412
initialActions00000
loadScripts12121617134411053
setupStore1170262211
uiStartup18612587209219292
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.71 KiB (0.04%)
  • common: 106.22 KiB (1.34%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2024
@OGPoyraz OGPoyraz added this pull request to the merge queue Oct 30, 2024
Merged via the queue into develop with commit 2c86162 Oct 30, 2024
@OGPoyraz OGPoyraz deleted the 3380-simulation-retrigger branch October 30, 2024 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri left review comments

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@sleepytanya sleepytanya sleepytanya approved these changes

+1 more reviewer

@dabossdana dabossdana dabossdana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@OGPoyraz @sleepytanya @metamaskbot @jpuri @matthewwalsh0 @dabossdana