Skip to content

fix: Reduce gas limit fallback from 95% to 35% of the block gas limit on failed gas limit estimations#27954

Merged
OGPoyraz merged 9 commits intodevelopfrom
19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
Oct 29, 2024
Merged

fix: Reduce gas limit fallback from 95% to 35% of the block gas limit on failed gas limit estimations#27954
OGPoyraz merged 9 commits intodevelopfrom
19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Oct 18, 2024 •
edited by github-actions bot
Loading

Description

This PR applies the latest transaction-controller version that reduces gas limit fallback.

Open in GitHub Codespaces

Related issues

Fixes: MetaMask/core#4739

Manual testing steps

NA

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner October 18, 2024 11:09
@OGPoyraz OGPoyraz linked an issue Oct 18, 2024 that may be closed by this pull request
Reduce gas limit fallback from 95% to 35% of the block gas limit to improve how we handle failed gas limit estimations #19692
Closed
@OGPoyraz OGPoyraz added the team-confirmations Push issues to confirmations team label Oct 18, 2024
@OGPoyraz
Merge branch 'develop' into 19692-reduce-gas-limit-fallback-from-95-t…
a930a84 
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
jpuri
jpuri previously approved these changes Oct 18, 2024
View reviewed changes
@OGPoyraz
Merge branch 'develop' into 19692-reduce-gas-limit-fallback-from-95-t…
db2473b 
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
@OGPoyraz
Fix ts error
918b5ed
@OGPoyraz OGPoyraz dismissed stale reviews from pedronfigueiredo and jpuri via 918b5ed October 21, 2024 13:29
OGPoyraz and others added 4 commits October 21, 2024 16:07
@OGPoyraz
Merge branch 'develop' into 19692-reduce-gas-limit-fallback-from-95-t…
5967749 
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
@OGPoyraz
Merge branch 'develop' into 19692-reduce-gas-limit-fallback-from-95-t…
667245e 
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
@OGPoyraz
Merge branch 'develop' into 19692-reduce-gas-limit-fallback-from-95-t…
6e3b6ec 
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
@matthewwalsh0
Update mock ownerOf responses
684be5e
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 29, 2024

Builds ready [684be5e]
Page Load Metrics (2003 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17842255201014067
domContentLoaded17632180197012058
load17842244200312962
domInteractive158850199
backgroundConnect10107292713
firstReactRender501941042713
getState584272612
initialActions01000
loadScripts1288162714639445
setupStore11124312914
uiStartup19812529223816579
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 68 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 664 Bytes (0.01%)

@OGPoyraz
Merge branch 'develop' into 19692-reduce-gas-limit-fallback-from-95-t…
cfcadc0 
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 29, 2024

Builds ready [cfcadc0]
Page Load Metrics (2353 ± 448 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43536931854746358
domContentLoaded167449062323932447
load169549442353932448
domInteractive22186755225
backgroundConnect148332199
firstReactRender4850612710148
getState576242311
initialActions01000
loadScripts121938861765748359
setupStore11106392814
uiStartup1888548826741091524
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 664 Bytes (0.01%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Oct 29, 2024
Merged via the queue into develop with commit f6b9e79 Oct 29, 2024
@OGPoyraz OGPoyraz deleted the 19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations branch October 29, 2024 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce gas limit fallback from 95% to 35% of the block gas limit to improve how we handle failed gas limit estimations

6 participants

@OGPoyraz @metamaskbot @jpuri @pedronfigueiredo @matthewwalsh0 @vinistevam