Skip to content

fix: bump @metamask/ppom-validator from 0.34.0 to 0.35.1#27939

Merged
cryptodev-2s merged 2 commits intodevelopfrom
chore/bump-ppom-validator-v0.35.1
Oct 17, 2024
Merged

fix: bump @metamask/ppom-validator from 0.34.0 to 0.35.1#27939
cryptodev-2s merged 2 commits intodevelopfrom
chore/bump-ppom-validator-v0.35.1

Conversation

@cryptodev-2s
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s commented Oct 17, 2024 •
edited
Loading

Description

This PR bumps @metamask/ppom-validator from 0.34.0 to 0.35.1

Open in GitHub Codespaces

Related issues

Fixes: #27909

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner October 17, 2024 16:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 17, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s changed the title chore: bump @metamask/ppom-validator from 0.34.0 t 0.35.1 chore: bump @metamask/ppom-validator from 0.34.0 to 0.35.1 Oct 17, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/ppom-validator@0.35.1 None 0 122 kB metamaskbot

🚮 Removed packages: npm/@metamask/ppom-validator@0.34.0

View full report↗︎

@cryptodev-2s cryptodev-2s changed the title chore: bump @metamask/ppom-validator from 0.34.0 to 0.35.1 fix: bump @metamask/ppom-validator from 0.34.0 to 0.35.1 Oct 17, 2024
@cryptodev-2s cryptodev-2s force-pushed the chore/bump-ppom-validator-v0.35.1 branch from a2fc098 to d2997d8 Compare October 17, 2024 16:56
@cryptodev-2s
Copy link
Copy Markdown
Contributor Author

cryptodev-2s commented Oct 17, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 17, 2024

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested a review from a team as a code owner October 17, 2024 17:18
Gudahtt
Gudahtt approved these changes Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 17, 2024

Builds ready [fb8f62d]
Page Load Metrics (1933 ± 147 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint160730131932305147
domContentLoaded158929601896296142
load160130101933305147
domInteractive13315696129
backgroundConnect11104362412
firstReactRender49287985627
getState5112252914
initialActions01000
loadScripts11481965140019895
setupStore1098393215
uiStartup178031682174333160
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -115.95 KiB (-2.30%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit 9716e94 Oct 17, 2024
@cryptodev-2s cryptodev-2s deleted the chore/bump-ppom-validator-v0.35.1 branch October 17, 2024 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@metamaskbot metamaskbot added release-12.7.0 Issue or pull request that will be included in release 12.7.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 17, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 18, 2024

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.7.0), as PR was cherry-picked in branch 12.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@MajorLift MajorLift MajorLift approved these changes

Assignees

No one assigned

Labels

regression-RC-12.5.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ppom failing on RC v12.5

5 participants

@cryptodev-2s @metamaskbot @Gudahtt @MajorLift @gauthierpetetin