Skip to content

fix: [cherry-pick][V12.5.0] sticky footer UI issue on Snaps Home Page…#27830

Merged
danjm merged 1 commit intoVersion-v12.5.0from
dd/fix-snaps-home-footer-extended
Oct 15, 2024
Merged

fix: [cherry-pick][V12.5.0] sticky footer UI issue on Snaps Home Page…#27830
danjm merged 1 commit intoVersion-v12.5.0from
dd/fix-snaps-home-footer-extended

Conversation

@david0xd
Copy link
Copy Markdown
Contributor

@david0xd david0xd commented Oct 14, 2024

Cherry-picked from: #27799

Description

Fix issue with sticky Snaps UI Footer component in extended view.

Open in GitHub Codespaces

Related issues

Fixes: n/a

Manual testing steps

  1. Try all the Snaps that use custom footer (Home Page Snap, Custom Dialog Snap with custom UI, etc.).
  2. Make sure that footer has correct width matching the width of the content view.

Screenshots/Recordings

Before

image

After

Screenshot 2024-10-11 at 20 38 13
Screenshot 2024-10-11 at 20 38 48
Screenshot 2024-10-11 at 20 40 55
Screenshot 2024-10-11 at 20 41 15
Screenshot 2024-10-11 at 20 56 29

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added type-bug Something isn't working team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) regression-RC-12.5.0 labels Oct 14, 2024
@david0xd david0xd self-assigned this Oct 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 14, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd marked this pull request as ready for review October 14, 2024 14:44
@david0xd david0xd requested a review from a team as a code owner October 14, 2024 14:44
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 15, 2024

Builds ready [6db098a]
Page Load Metrics (1842 ± 137 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint152023851844286137
domContentLoaded150923271818276133
load152423881842286137
domInteractive22102452010

@danjm danjm merged commit 5b4c287 into Version-v12.5.0 Oct 15, 2024
@danjm danjm deleted the dd/fix-snaps-home-footer-extended branch October 15, 2024 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Oct 15, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 15, 2024

No release label on PR. Adding release label release-12.5.0 on PR, as PR was cherry-picked in branch 12.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees

@david0xd david0xd

Labels

regression-RC-12.5.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) type-bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@david0xd @metamaskbot @FrederikBolding @danjm