fix: hackily wait longer for linea swap approval tx to increase chance of success#27810
Merged
fix: hackily wait longer for linea swap approval tx to increase chance of success#27810
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [697d1f9]
Page Load Metrics (1683 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bef65f6]
Page Load Metrics (1732 ± 110 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Collaborator
Builds ready [c2bcb19]
Page Load Metrics (1786 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jclancy93
reviewed
Oct 14, 2024
jclancy93
approved these changes
Oct 15, 2024
infiniteflower
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linea seems to be taking longer than other chains to process the approve transaction after it is submitted, so the trade transaction is erroring. This PR adds a hacky workaround where we artificially delay if we're on Linea to give the trade transaction more time. In the future, we'd want to avoid this hack, but for now it should increase the swap success rate on Linea.
With the delay, the token symbol also wasn't immediately populating on the awaiting swap page, so this PR also updates how it's retrieved.
Related issues
Fixes: #27804
Manual testing steps
Screenshots/Recordings
Before
375871389-343ab5ee-1bcb-45cb-9d42-c753b80c1fea.mov
After
LineaSwap.mov
Pre-merge author checklist
Pre-merge reviewer checklist