Skip to content

Multichain: Fix snaps connection#27803

Merged
jiexi merged 7 commits intocaip-multichainfrom
jl/caip-multichain/fix-snaps-connection
Oct 14, 2024
Merged

Multichain: Fix snaps connection#27803
jiexi merged 7 commits intocaip-multichainfrom
jl/caip-multichain/fix-snaps-connection

Conversation

@jiexi
Copy link
Copy Markdown
Member

@jiexi jiexi commented Oct 11, 2024

Description

  • Exclude permittedChains in eth_requestAccounts and wallet_requestPermissions if origin is snapId
  • Allow all subjectTypes to create endowment:caip25 permissions (this is the same as eth_accounts now, i.e. not limited to certain subject types)
  • Set eth accounts on upserted empty optional wallet and wallet:eip155 scopes

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3492

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Oct 11, 2024
@jiexi
Copy link
Copy Markdown
Member Author

jiexi commented Oct 11, 2024

REMINDER: some of these changes need to be migrated to core now. Honestly it may be easier to pick those changes out directly into core and push the extension ones only to the feature branch

@jiexi jiexi marked this pull request as ready for review October 14, 2024 16:51
@jiexi jiexi requested a review from a team as a code owner October 14, 2024 16:51
@jiexi jiexi merged commit cd1861d into caip-multichain Oct 14, 2024
@jiexi jiexi deleted the jl/caip-multichain/fix-snaps-connection branch October 14, 2024 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants