Skip to content

Multichain: Lint#27745

Merged
jiexi merged 3 commits intocaip-multichainfrom
jl/caip-multichain/lint
Oct 9, 2024
Merged

Multichain: Lint#27745
jiexi merged 3 commits intocaip-multichainfrom
jl/caip-multichain/lint

Conversation

@jiexi
Copy link
Copy Markdown
Member

@jiexi jiexi commented Oct 9, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Oct 9, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 9, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@json-schema-tools/traverse@1.10.4 None 0 26.4 kB belfordz

🚮 Removed packages: npm/@json-schema-tools/traverse@1.10.3

View full report↗︎

@jiexi jiexi changed the title Jl/caip multichain/lint Multichain: Lint Oct 9, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@jiexi jiexi marked this pull request as ready for review October 9, 2024 22:46
@jiexi jiexi requested a review from a team as a code owner October 9, 2024 22:46
@jiexi jiexi merged commit 6c3bc39 into caip-multichain Oct 9, 2024
@jiexi jiexi deleted the jl/caip-multichain/lint branch October 9, 2024 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees

No one assigned

Labels

team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiexi @adonesky1