Skip to content

fix: get wallet_getSession/revokeSession passing#27741

Merged
jiexi merged 4 commits intocaip-multichainfrom
fix/uncomment-revoke-getsession
Oct 9, 2024
Merged

fix: get wallet_getSession/revokeSession passing#27741
jiexi merged 4 commits intocaip-multichainfrom
fix/uncomment-revoke-getsession

Conversation

@shanejonas
Copy link
Copy Markdown
Contributor

@shanejonas shanejonas commented Oct 9, 2024

Description

uncomment revokeSession and getSession and get them passing

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shanejonas shanejonas requested a review from a team as a code owner October 9, 2024 19:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Oct 9, 2024
} from '@metamask/api-specs';

import { MethodObject, OpenrpcDocument } from '@open-rpc/meta-schema';
import { ContentDescriptorObject, MethodObject, OpenrpcDocument } from '@open-rpc/meta-schema';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 is this used?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 9, 2024

@jiexi jiexi merged commit a19cf08 into caip-multichain Oct 9, 2024
@jiexi jiexi deleted the fix/uncomment-revoke-getsession branch October 9, 2024 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants