Skip to content

fix: fix api spec multichain bump issues#27669

Merged
shanejonas merged 8 commits intocaip-multichainfrom
fix/api-specs-bump-multichain-2
Oct 9, 2024
Merged

fix: fix api spec multichain bump issues#27669
shanejonas merged 8 commits intocaip-multichainfrom
fix/api-specs-bump-multichain-2

Conversation

@shanejonas
Copy link
Copy Markdown
Contributor

@shanejonas shanejonas commented Oct 7, 2024

Description

Remove unused error codes and skip wallet_getSession and revokeSession for now. bump schema-utils-js with a couple bug fixes. Fixed parsing ordering.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shanejonas shanejonas requested a review from a team as a code owner October 7, 2024 16:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Oct 7, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@open-rpc/schema-utils-js@2.0.5 filesystem 0 88.2 kB belfordz

🚮 Removed packages: npm/@open-rpc/schema-utils-js@2.0.3

View full report↗︎

@shanejonas shanejonas requested review from a team and kumavis as code owners October 7, 2024 19:51
@metamaskbot
Copy link
Copy Markdown
Collaborator

❌ API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

❌ API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

❌ API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

❌ API Spec Test Failed. View the report here.

if (method.errors) {
method.errors.forEach((err) => {
const unsupportedErrorCodes = [5000, 5300, 5301];
const unsupportedErrorCodes = [5000, 5100, 5101, 5102, 5300, 5301];
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update the spec to remove these errors. Or if we are adding them as warnings we should be able to write a new Rule to test for that based on the errors in the spec.

Comment on lines +186 to +187
// 'wallet_getSession',
// 'wallet_revokeSession'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these no longer throw now. may require API specs update though

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shanejonas shanejonas merged commit 2456465 into caip-multichain Oct 9, 2024
@shanejonas shanejonas deleted the fix/api-specs-bump-multichain-2 branch October 9, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants