Skip to content

chore: Fix changelog for v12.4.0#27558

Merged
danjm merged 2 commits intoVersion-v12.4.0from
v12.4.0-changelog
Oct 8, 2024
Merged

chore: Fix changelog for v12.4.0#27558
danjm merged 2 commits intoVersion-v12.4.0from
v12.4.0-changelog

Conversation

@chloeYue
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue commented Oct 2, 2024 •
edited by github-actions bot
Loading

Description

Fix changelog for v12.4.0

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue self-assigned this Oct 2, 2024
@chloeYue chloeYue requested a review from a team as a code owner October 2, 2024 10:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 2, 2024

Builds ready [a180f9c]
Page Load Metrics (1896 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24223031651608292
domContentLoaded15682288186717986
load15772304189618086
domInteractive1392412311

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (bc08781) to head (a180f9c).

Additional details and impacted files 
@@               Coverage Diff                @@
##           Version-v12.4.0   #27558   +/-   ##
================================================
  Coverage            70.05%   70.05%           
================================================
  Files                 1422     1422           
  Lines                49677    49677           
  Branches             13887    13887           
================================================
  Hits                 34800    34800           
  Misses               14877    14877

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru
Copy link
Copy Markdown
Contributor

hjetpoluru commented Oct 2, 2024

@chloeYue, could you please add this in the changelog under the fixed section
Improved extension load time by using an interstitial page and deferred script tags. (#26555)

@chloeYue
Copy link
Copy Markdown
Contributor Author

chloeYue commented Oct 2, 2024 •
edited
Loading

@chloeYue, could you please add this in the changelog under the fixed section Improved extension load time by using an interstitial page and deferred script tags. (#26555)

this one was for release 12.2.0, we should remove this one from google sheet and not add it here

@hjetpoluru
Copy link
Copy Markdown
Contributor

hjetpoluru commented Oct 2, 2024

ok thanks @chloeYue, I have removed it from the excel too.

@danjm danjm merged commit dfbead6 into Version-v12.4.0 Oct 8, 2024
@danjm danjm deleted the v12.4.0-changelog branch October 8, 2024 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@chloeYue chloeYue

Labels

extension-delivery team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chloeYue @metamaskbot @hjetpoluru @danjm