Skip to content

fix: updated ui for connect and review page#27478

Merged
NidhiKJha merged 2 commits intodevelopfrom
fix-connect-rview-page
Oct 1, 2024
Merged

fix: updated ui for connect and review page#27478
NidhiKJha merged 2 commits intodevelopfrom
fix-connect-rview-page

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

This PR is to update the following UI changes in the connect and the new permissions page

Description

  • Fix the Typography
  • Update background color on Connect Page
  • Don't show header on review permissions page

Related issues

Fixes:

Manual testing steps

  1. Run extension with CHAIN_PERMISSIONS=1 yarn start
  2. Check the following changes in Connect Page: Background color is fixed, Typography looks aligned with design, Bottom learn more message
  3. Fix Permissions Page: Typography is fixed, the list item has border radius and proper padding, three dot menu replaced by Edit button

Screenshots/Recordings

Before

Screenshot 2024-09-30 at 3 53 23 AM

Screenshot 2024-09-30 at 3 53 09 AM

After

Connect Page

Screenshot 2024-09-30 at 4 01 38 AM

Permission Page

Screenshot 2024-09-30 at 3 52 38 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested review from a team as code owners September 30, 2024 03:02
@github-actions github-actions bot added the team-core-extension-ux Core Extension UX team label Sep 30, 2024
@NidhiKJha NidhiKJha added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Sep 30, 2024
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [8431154]
Page Load Metrics (1774 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31129301703443213
domContentLoaded141229051755305146
load141929241774305146
domInteractive228238136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 769 Bytes (0.01%)
  • common: 201 Bytes (0.00%)

Copy link
Copy Markdown

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NidhiKJha NidhiKJha merged commit 9b50f59 into develop Oct 1, 2024
@NidhiKJha NidhiKJha deleted the fix-connect-rview-page branch October 1, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants