Skip to content

feat: Double Sentry performance trace sample rate#27468

Merged
hjetpoluru merged 1 commit intodevelopfrom
double-sentry-trace-sample-rate
Sep 30, 2024
Merged

feat: Double Sentry performance trace sample rate#27468
hjetpoluru merged 1 commit intodevelopfrom
double-sentry-trace-sample-rate

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Sep 27, 2024

Description

The Sentry trace sample rate for production has been doubled, to take advantage of increased Sentry transaction quotas for our account.

Open in GitHub Codespaces

Related issues

Closes #27467

Manual testing steps

It's not easy to test this because it's probabilistic.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label Sep 27, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [68ad4fa]
Page Load Metrics (1802 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15492328180719795
domContentLoaded15072277176517484
load15522287180218288
domInteractive178145189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review September 30, 2024 12:23
@Gudahtt Gudahtt requested a review from a team as a code owner September 30, 2024 12:23
The Sentry trace sample rate for production has been doubled, to take
advantage of increased Sentry transaction quotas for our account.

Closes #27467
@Gudahtt Gudahtt force-pushed the double-sentry-trace-sample-rate branch from 68ad4fa to d91ca41 Compare September 30, 2024 12:24
@sonarqubecloud
Copy link
Copy Markdown

@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 30, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d91ca41]
Page Load Metrics (2189 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26828011921720346
domContentLoaded167726762151240115
load168728062189263126
domInteractive1999592211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review September 30, 2024 13:15
@hjetpoluru hjetpoluru merged commit b665a1c into develop Sep 30, 2024
@hjetpoluru hjetpoluru deleted the double-sentry-trace-sample-rate branch September 30, 2024 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 30, 2024
@hjetpoluru hjetpoluru added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Increase Sentry trace sample rate

4 participants