Skip to content

fix: removed closeMenu for ConnectedAccountsMenu#27460

Merged
NidhiKJha merged 1 commit intodevelopfrom
fix-27454
Sep 27, 2024
Merged

fix: removed closeMenu for ConnectedAccountsMenu#27460
NidhiKJha merged 1 commit intodevelopfrom
fix-27454

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

Description

This PR is to remove the unused closeMenu prop from ConnectedAccountsMenu

Related issues

Fixes: #27454

Manual testing steps

  1. Go to the connections page
  2. click on three dot menu for connected accounts
  3. everything should be working as it is

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner September 27, 2024 16:34
@NidhiKJha NidhiKJha added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Sep 27, 2024
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✅

@EtherWizard33 EtherWizard33 self-requested a review September 27, 2024 17:05
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [2b564a9]
Page Load Metrics (1640 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33023561582346166
domContentLoaded14172297162118589
load14242348164019392
domInteractive239842209
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -28 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha merged commit 8d667a3 into develop Sep 27, 2024
@NidhiKJha NidhiKJha deleted the fix-27454 branch September 27, 2024 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: f is not a function

5 participants