fix: Fix snaps permission connection for CHAIN_PERMISSIONS feature flag#27459
Merged
fix: Fix snaps permission connection for CHAIN_PERMISSIONS feature flag#27459
CHAIN_PERMISSIONS feature flag#27459Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
reviewed
Sep 27, 2024
| path={confirmPermissionPath} | ||
| exact | ||
| render={() => | ||
| process.env.CHAIN_PERMISSIONS && !permissionsRequest?.diff ? ( |
Contributor
There was a problem hiding this comment.
could you briefly explain why !permissionsRequest?.diff isn't necessary anymore?
Member
Author
There was a problem hiding this comment.
This guard was ensuring that the incremental request for permittedChains goes to the confirmPermissionPath route in the first place. Now the new ConnectPage component has been moved out of the confirmPermissionPath and into the connectPath route.
I recommend viewing the file as a whole as the github diff makes it a little bit difficult to notice this change
CHAIN_PERMISSIONS feature flag
|
Collaborator
Builds ready [ed3311a]
Page Load Metrics (1792 ± 83 ms)
Bundle size diffs
|
NidhiKJha
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent permission flow changes introduced behind the
CHAIN_PERMISSIONSfeature flag have broken permission connection for Snaps. This PR fixes it by removing an incorrect forced route direct in the permission connection component.Related issues
Fixes: #26635
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist