Skip to content

fix: Remove duplication#27421

Merged
OGPoyraz merged 2 commits intodevelopfrom
fix/remove-duplicated-package
Sep 26, 2024
Merged

fix: Remove duplication#27421
OGPoyraz merged 2 commits intodevelopfrom
fix/remove-duplicated-package

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Sep 26, 2024

Description

This PR removes the duplication introduced in https://github.com/MetaMask/metamask-extension/pull/26967/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R354-R355

Open in GitHub Codespaces

Related issues

Fixes: develop branch

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner September 26, 2024 13:04
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 26, 2024
Copy link
Copy Markdown
Contributor

@kanthesha kanthesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud
Copy link
Copy Markdown

@OGPoyraz OGPoyraz merged commit 8e31bbc into develop Sep 26, 2024
@OGPoyraz OGPoyraz deleted the fix/remove-duplicated-package branch September 26, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3d67ef9]
Page Load Metrics (1852 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16662414184515675
domContentLoaded16572343181414771
load16652382185214771
domInteractive227838188
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants