fix: flaky test Responsive UI Send Transaction from responsive window#27417
Merged
fix: flaky test Responsive UI Send Transaction from responsive window#27417
Responsive UI Send Transaction from responsive window#27417Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [5ab38ed]
Page Load Metrics (1927 ± 108 ms)
Bundle size diffs
|
chloeYue
approved these changes
Sep 26, 2024
Contributor
chloeYue
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for the fix !
Collaborator
Builds ready [5522a43]
Page Load Metrics (1884 ± 99 ms)
Bundle size diffs
|
|
Collaborator
Builds ready [7351963]
Page Load Metrics (1927 ± 172 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before clicking Confirm, we wait until the transaction gas and amount are loaded to avoid any possible rerender.
We also login with balance validation, so we can get rid of the initial delay.
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102392/workflows/75210923-91d6-44cc-b224-72f3f530dbb2/jobs/3815538/tests
Related issues
Fixes: #27418
Manual testing steps
yarn test:e2e:single test/e2e/tests/responsive-ui/metamask-responsive-ui.spec.js --browser=chrome --leave-running=trueScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist