Skip to content

fix(NOTIFY-1166): rename account sync event names#27413

Merged
mathieuartu merged 2 commits intodevelopfrom
fix/account_sync_event_names
Sep 26, 2024
Merged

fix(NOTIFY-1166): rename account sync event names#27413
mathieuartu merged 2 commits intodevelopfrom
fix/account_sync_event_names

Conversation

@mathieuartu
Copy link
Copy Markdown
Contributor

@mathieuartu mathieuartu commented Sep 26, 2024 •
edited
Loading

Description

This PR simplifies account syncing event names

Open in GitHub Codespaces

Related issues

Fixes: NOTIFY-1166

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mathieuartu mathieuartu added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label Sep 26, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 26, 2024

Builds ready [90ecf89]
Page Load Metrics (2131 ± 224 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28437681955709340
domContentLoaded153837092100458220
load154737492131467224
domInteractive18146502814
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -14 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -30 Bytes (-0.00%)

@mathieuartu mathieuartu marked this pull request as ready for review September 26, 2024 07:36
@mathieuartu mathieuartu requested a review from a team as a code owner September 26, 2024 07:36
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mathieuartu mathieuartu merged commit 5df205d into develop Sep 26, 2024
@mathieuartu mathieuartu deleted the fix/account_sync_event_names branch September 26, 2024 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 26, 2024

Builds ready [a1aad6d]
Page Load Metrics (1874 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16392087186512761
domContentLoaded15782022183811756
load16372167187413465
domInteractive25215514119
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -14 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -30 Bytes (-0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

+1 more reviewer

@matteoscurati matteoscurati matteoscurati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mathieuartu @metamaskbot @matteoscurati @Prithpal-Sooriya