Skip to content

feat: Display setApprovalForAll and revoke setApprovalForAll to users…#27401

Merged
pedronfigueiredo merged 1 commit intodevelopfrom
pnf/show-set-approval-for-all
Sep 26, 2024
Merged

feat: Display setApprovalForAll and revoke setApprovalForAll to users…#27401
pedronfigueiredo merged 1 commit intodevelopfrom
pnf/show-set-approval-for-all

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 25, 2024 •
edited
Loading

… that opt in

Description

This makes both redesigned screens available for users that opt into redesigned transaction screens in the experimental settings page.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 25, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 25, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner September 25, 2024 16:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 25, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 25, 2024

Builds ready [a84a280]
Page Load Metrics (1895 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34924291744489235
domContentLoaded15362353185819895
load153823611895216104
domInteractive227043178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

vinistevam
vinistevam previously approved these changes Sep 26, 2024
View reviewed changes
jpuri
jpuri previously approved these changes Sep 26, 2024
View reviewed changes
@pedronfigueiredo pedronfigueiredo dismissed stale reviews from jpuri and vinistevam via c92983d September 26, 2024 13:23
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/show-set-approval-for-all branch from a84a280 to c92983d Compare September 26, 2024 13:23
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 26, 2024

Builds ready [c92983d]
Page Load Metrics (1783 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30323541717384184
domContentLoaded14852284176319493
load15032287178319795
domInteractive237035147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/show-set-approval-for-all branch from c92983d to 3d941eb Compare September 26, 2024 14:22
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 26, 2024

Builds ready [3d941eb]
Page Load Metrics (1714 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23821361644346166
domContentLoaded15151960168110048
load15222166171413665
domInteractive257337157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo merged commit 0e2d3e5 into develop Sep 26, 2024
@pedronfigueiredo pedronfigueiredo deleted the pnf/show-set-approval-for-all branch September 26, 2024 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

@pedronfigueiredo pedronfigueiredo

Labels

release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pedronfigueiredo @metamaskbot @jpuri @vinistevam