Skip to content

chore: Add useLedgerConnection unit tests#27358

Merged
OGPoyraz merged 3 commits intodevelopfrom
chore/add-use-ledger-connection-tests
Sep 30, 2024
Merged

chore: Add useLedgerConnection unit tests#27358
OGPoyraz merged 3 commits intodevelopfrom
chore/add-use-ledger-connection-tests

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Sep 24, 2024

Description

This PR adds useLedgerConnnection hook unit tests.

Open in GitHub Codespaces

Related issues

Fixes: -

Manual testing steps

No QA needed.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner September 24, 2024 11:13
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 24, 2024
@sonarqubecloud
Copy link
Copy Markdown

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [ba83b47]
Page Load Metrics (1768 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15992427175618689
domContentLoaded15942314173416579
load15992437176818790
domInteractive22189574220
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@OGPoyraz OGPoyraz merged commit cd2aefb into develop Sep 30, 2024
@OGPoyraz OGPoyraz deleted the chore/add-use-ledger-connection-tests branch September 30, 2024 10:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants