fix(snaps): Set proper text color for secondary button#27335
Merged
GuillaumeRx merged 2 commits intodevelopfrom Sep 27, 2024
Merged
fix(snaps): Set proper text color for secondary button#27335GuillaumeRx merged 2 commits intodevelopfrom
GuillaumeRx merged 2 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hmalik88
previously approved these changes
Sep 23, 2024
Mrtenz
requested changes
Sep 23, 2024
Member
Mrtenz
left a comment
There was a problem hiding this comment.
Can you fix the cursor issue too?
Mrtenz
approved these changes
Sep 24, 2024
Collaborator
Builds ready [ab0f362]
Page Load Metrics (1697 ± 74 ms)
Bundle size diffs
|
ab0f362 to
6b3c232
Compare
Collaborator
Builds ready [6b3c232]
Page Load Metrics (1845 ± 88 ms)
Bundle size diffs
|
6b3c232 to
cd8c5c4
Compare
|
hmalik88
approved these changes
Sep 27, 2024
Collaborator
Builds ready [cd8c5c4]
Page Load Metrics (1772 ± 59 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the button in snaps footer of type
secondaryhaving the wrong text color on hover.It also fixes a wrong variant if the interface on had one action provided in the footer.
Related issues
Fixes:
Manual testing steps
getHideSnapBrandingto returntrueScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist